hexagon: do not specify inputs to semantics_generated.pyinc generation

[PATCH] hexagon: do not specify inputs to semantics_generated.pyinc generation

Paolo Bonzini posted 1 patch 4 years, 8 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210309151907.201528-1-pbonzini@redhat.com

Maintainers: Taylor Simpson <tsimpson@quicinc.com>

target/hexagon/meson.build | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Expand all Fold all

[PATCH] hexagon: do not specify inputs to semantics_generated.pyinc generation

Posted by Paolo Bonzini 4 years, 8 months ago

gen_semantics is an executable, not an input.  Meson 0.57 special cases
the first argument and @INPUT@ is not expanded there.  Fix that by
not including it in the input, only in the command.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 target/hexagon/meson.build | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/target/hexagon/meson.build b/target/hexagon/meson.build
index 15318a6fa7..8724f8f1fb 100644
--- a/target/hexagon/meson.build
+++ b/target/hexagon/meson.build
@@ -33,8 +33,7 @@ gen_semantics = executable(
 semantics_generated = custom_target(
     'semantics_generated.pyinc',
     output: 'semantics_generated.pyinc',
-    input: gen_semantics,
-    command: ['@INPUT@', '@OUTPUT@'],
+    command: [gen_semantics, '@OUTPUT@'],
 )
 hexagon_ss.add(semantics_generated)
 
-- 
2.29.2

Re: [PATCH] hexagon: do not specify inputs to semantics_generated.pyinc generation

Posted by Richard Henderson 4 years, 8 months ago

On 3/9/21 7:19 AM, Paolo Bonzini wrote:
> gen_semantics is an executable, not an input.  Meson 0.57 special cases
> the first argument and @INPUT@ is not expanded there.  Fix that by
> not including it in the input, only in the command.
> 
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
>   target/hexagon/meson.build | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~