[PULL 00/14] Gitlab, testing and misc patches

Thomas Huth posted 14 patches 3 years, 2 months ago
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210309104617.714908-1-thuth@redhat.com
Maintainers: Fam Zheng <fam@euphon.net>, Thomas Huth <thuth@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Max Reitz <mreitz@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, Alistair Francis <alistair@alistair23.me>, Kevin Wolf <kwolf@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, "Hervé Poussineau" <hpoussin@reactos.org>, "Michael S. Tsirkin" <mst@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, Cleber Rosa <crosa@redhat.com>, Palmer Dabbelt <palmer@dabbelt.com>, BALATON Zoltan <balaton@eik.bme.hu>, Sagar Karandikar <sagark@eecs.berkeley.edu>, Paolo Bonzini <pbonzini@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Laurent Vivier <lvivier@redhat.com>, Markus Armbruster <armbru@redhat.com>, Jason Wang <jasowang@redhat.com>, Andrzej Zaborowski <balrogg@gmail.com>, Greg Kurz <groug@kaod.org>, Richard Henderson <richard.henderson@linaro.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Christian Schoenebeck <qemu_oss@crudebyte.com>
.gitlab-ci.d/edk2.yml                         |    1 +
.gitlab-ci.d/opensbi.yml                      |    1 +
.gitlab-ci.yml                                |    5 +-
MAINTAINERS                                   |    6 +-
accel/tcg/cpu-exec.c                          |    1 -
blockdev.c                                    |    1 -
configure                                     |    2 +-
default-configs/targets/tilegx-linux-user.mak |    1 -
docs/devel/index.rst                          |    1 +
docs/devel/qgraph.rst                         |  568 ++++
docs/devel/qtest.rst                          |    8 +
docs/system/deprecated.rst                    |    8 -
docs/system/removed-features.rst              |   14 +
hw/9pfs/9p.c                                  |    1 -
hw/arm/armv7m.c                               |    1 -
hw/arm/mainstone.c                            |    1 -
hw/arm/xlnx-zcu102.c                          |    1 -
hw/arm/z2.c                                   |    1 -
hw/i386/pc.c                                  |    1 -
hw/misc/ivshmem.c                             |    1 -
hw/ppc/ppc440_bamboo.c                        |    1 -
hw/ppc/prep.c                                 |    1 -
hw/ppc/sam460ex.c                             |    1 -
hw/ppc/spapr_caps.c                           |    1 -
hw/ppc/spapr_pci_vfio.c                       |    1 -
hw/ppc/spapr_vio.c                            |    1 -
hw/ppc/virtex_ml507.c                         |    1 -
hw/riscv/spike.c                              |    1 -
hw/rx/rx62n.c                                 |    1 -
include/elf.h                                 |    2 -
include/exec/poison.h                         |    1 -
linux-user/elfload.c                          |   23 -
linux-user/syscall_defs.h                     |   10 +-
linux-user/tilegx/cpu_loop.c                  |  287 --
linux-user/tilegx/signal.c                    |  178 --
linux-user/tilegx/sockbits.h                  |    1 -
linux-user/tilegx/syscall_nr.h                |  327 ---
linux-user/tilegx/target_cpu.h                |   44 -
linux-user/tilegx/target_elf.h                |   14 -
linux-user/tilegx/target_fcntl.h              |   11 -
linux-user/tilegx/target_signal.h             |   23 -
linux-user/tilegx/target_structs.h            |   46 -
linux-user/tilegx/target_syscall.h            |   44 -
linux-user/tilegx/termbits.h                  |    1 -
net/net.c                                     |    1 -
scripts/ci/gitlab-pipeline-status             |   25 +-
scripts/mtest2make.py                         |    2 +-
softmmu/cpu-timers.c                          |    1 -
target/meson.build                            |    1 -
target/ppc/translate_init.c.inc               |    1 -
target/tilegx/cpu-param.h                     |   17 -
target/tilegx/cpu.c                           |  182 --
target/tilegx/cpu.h                           |  160 --
target/tilegx/helper.c                        |  147 -
target/tilegx/helper.h                        |   23 -
target/tilegx/meson.build                     |   13 -
target/tilegx/opcode_tilegx.h                 | 1406 ----------
target/tilegx/simd_helper.c                   |  165 --
target/tilegx/spr_def_64.h                    |  212 --
target/tilegx/translate.c                     | 2437 -----------------
tests/Makefile.include                        |    5 +-
tests/qtest/libqos/qgraph.h                   |  450 +--
util/main-loop.c                              |    1 -
util/qemu-timer.c                             |    1 -
64 files changed, 741 insertions(+), 6154 deletions(-)
delete mode 100644 default-configs/targets/tilegx-linux-user.mak
create mode 100644 docs/devel/qgraph.rst
delete mode 100644 linux-user/tilegx/cpu_loop.c
delete mode 100644 linux-user/tilegx/signal.c
delete mode 100644 linux-user/tilegx/sockbits.h
delete mode 100644 linux-user/tilegx/syscall_nr.h
delete mode 100644 linux-user/tilegx/target_cpu.h
delete mode 100644 linux-user/tilegx/target_elf.h
delete mode 100644 linux-user/tilegx/target_fcntl.h
delete mode 100644 linux-user/tilegx/target_signal.h
delete mode 100644 linux-user/tilegx/target_structs.h
delete mode 100644 linux-user/tilegx/target_syscall.h
delete mode 100644 linux-user/tilegx/termbits.h
delete mode 100644 target/tilegx/cpu-param.h
delete mode 100644 target/tilegx/cpu.c
delete mode 100644 target/tilegx/cpu.h
delete mode 100644 target/tilegx/helper.c
delete mode 100644 target/tilegx/helper.h
delete mode 100644 target/tilegx/meson.build
delete mode 100644 target/tilegx/opcode_tilegx.h
delete mode 100644 target/tilegx/simd_helper.c
delete mode 100644 target/tilegx/spr_def_64.h
delete mode 100644 target/tilegx/translate.c
[PULL 00/14] Gitlab, testing and misc patches
Posted by Thomas Huth 3 years, 2 months ago
 Hi Peter,

the following changes since commit 229a834518b950d56fd1bc94923276504d0ee9d4:

  Merge remote-tracking branch 'remotes/philmd-gitlab/tags/renesas-20210306' into staging (2021-03-08 15:45:48 +0000)

are available in the Git repository at:

  https://gitlab.com/thuth/qemu.git tags/pull-request-2021-03-09

for you to fetch changes up to 65a9d3807e9a0ffd9f9719416a07be41b6f39e94:

  bsd-user: Add new maintainers (2021-03-09 11:26:32 +0100)

Gitlab-CI run can be found here:

 https://gitlab.com/thuth/qemu/-/pipelines/267522743

----------------------------------------------------------------
* Add some missing gitlab-CI job dependencies
* Re-enable "make check SPEED=slow"
* Improve the gitlab-pipeline-status script
* Clean up inclusing of qtest.h headers
* Improve libqos/qgraph documentation
* Fix downloading problem in the acceptance tests
* Remove deprecated target tilegx
* Add new bsd-user maintainers
----------------------------------------------------------------

Chen Qun (1):
  qtest: delete superfluous inclusions of qtest.h

Cleber Rosa (5):
  scripts/ci/gitlab-pipeline-status: split utlity function for HTTP GET
  scripts/ci/gitlab-pipeline-status: give more information on failures
  scripts/ci/gitlab-pipeline-status: give more info when pipeline not
    found
  Acceptance Tests: restore downloading of VM images
  Acceptance Tests: restore filtering of tests by target arch

Emanuele Giuseppe Esposito (2):
  libqos/qgraph: format qgraph comments for sphinx documentation
  docs/devel/qgraph: improve qgraph documentation

Philippe Mathieu-Daudé (3):
  docker: Alpine build job depends on Alpine container
  docker: EDK2 build job depends on EDK2 container
  docker: OpenSBI build job depends on OpenSBI container

Thomas Huth (2):
  meson: Re-enable the possibility to run "make check SPEED=slow"
  Remove deprecated target tilegx

Warner Losh (1):
  bsd-user: Add new maintainers

 .gitlab-ci.d/edk2.yml                         |    1 +
 .gitlab-ci.d/opensbi.yml                      |    1 +
 .gitlab-ci.yml                                |    5 +-
 MAINTAINERS                                   |    6 +-
 accel/tcg/cpu-exec.c                          |    1 -
 blockdev.c                                    |    1 -
 configure                                     |    2 +-
 default-configs/targets/tilegx-linux-user.mak |    1 -
 docs/devel/index.rst                          |    1 +
 docs/devel/qgraph.rst                         |  568 ++++
 docs/devel/qtest.rst                          |    8 +
 docs/system/deprecated.rst                    |    8 -
 docs/system/removed-features.rst              |   14 +
 hw/9pfs/9p.c                                  |    1 -
 hw/arm/armv7m.c                               |    1 -
 hw/arm/mainstone.c                            |    1 -
 hw/arm/xlnx-zcu102.c                          |    1 -
 hw/arm/z2.c                                   |    1 -
 hw/i386/pc.c                                  |    1 -
 hw/misc/ivshmem.c                             |    1 -
 hw/ppc/ppc440_bamboo.c                        |    1 -
 hw/ppc/prep.c                                 |    1 -
 hw/ppc/sam460ex.c                             |    1 -
 hw/ppc/spapr_caps.c                           |    1 -
 hw/ppc/spapr_pci_vfio.c                       |    1 -
 hw/ppc/spapr_vio.c                            |    1 -
 hw/ppc/virtex_ml507.c                         |    1 -
 hw/riscv/spike.c                              |    1 -
 hw/rx/rx62n.c                                 |    1 -
 include/elf.h                                 |    2 -
 include/exec/poison.h                         |    1 -
 linux-user/elfload.c                          |   23 -
 linux-user/syscall_defs.h                     |   10 +-
 linux-user/tilegx/cpu_loop.c                  |  287 --
 linux-user/tilegx/signal.c                    |  178 --
 linux-user/tilegx/sockbits.h                  |    1 -
 linux-user/tilegx/syscall_nr.h                |  327 ---
 linux-user/tilegx/target_cpu.h                |   44 -
 linux-user/tilegx/target_elf.h                |   14 -
 linux-user/tilegx/target_fcntl.h              |   11 -
 linux-user/tilegx/target_signal.h             |   23 -
 linux-user/tilegx/target_structs.h            |   46 -
 linux-user/tilegx/target_syscall.h            |   44 -
 linux-user/tilegx/termbits.h                  |    1 -
 net/net.c                                     |    1 -
 scripts/ci/gitlab-pipeline-status             |   25 +-
 scripts/mtest2make.py                         |    2 +-
 softmmu/cpu-timers.c                          |    1 -
 target/meson.build                            |    1 -
 target/ppc/translate_init.c.inc               |    1 -
 target/tilegx/cpu-param.h                     |   17 -
 target/tilegx/cpu.c                           |  182 --
 target/tilegx/cpu.h                           |  160 --
 target/tilegx/helper.c                        |  147 -
 target/tilegx/helper.h                        |   23 -
 target/tilegx/meson.build                     |   13 -
 target/tilegx/opcode_tilegx.h                 | 1406 ----------
 target/tilegx/simd_helper.c                   |  165 --
 target/tilegx/spr_def_64.h                    |  212 --
 target/tilegx/translate.c                     | 2437 -----------------
 tests/Makefile.include                        |    5 +-
 tests/qtest/libqos/qgraph.h                   |  450 +--
 util/main-loop.c                              |    1 -
 util/qemu-timer.c                             |    1 -
 64 files changed, 741 insertions(+), 6154 deletions(-)
 delete mode 100644 default-configs/targets/tilegx-linux-user.mak
 create mode 100644 docs/devel/qgraph.rst
 delete mode 100644 linux-user/tilegx/cpu_loop.c
 delete mode 100644 linux-user/tilegx/signal.c
 delete mode 100644 linux-user/tilegx/sockbits.h
 delete mode 100644 linux-user/tilegx/syscall_nr.h
 delete mode 100644 linux-user/tilegx/target_cpu.h
 delete mode 100644 linux-user/tilegx/target_elf.h
 delete mode 100644 linux-user/tilegx/target_fcntl.h
 delete mode 100644 linux-user/tilegx/target_signal.h
 delete mode 100644 linux-user/tilegx/target_structs.h
 delete mode 100644 linux-user/tilegx/target_syscall.h
 delete mode 100644 linux-user/tilegx/termbits.h
 delete mode 100644 target/tilegx/cpu-param.h
 delete mode 100644 target/tilegx/cpu.c
 delete mode 100644 target/tilegx/cpu.h
 delete mode 100644 target/tilegx/helper.c
 delete mode 100644 target/tilegx/helper.h
 delete mode 100644 target/tilegx/meson.build
 delete mode 100644 target/tilegx/opcode_tilegx.h
 delete mode 100644 target/tilegx/simd_helper.c
 delete mode 100644 target/tilegx/spr_def_64.h
 delete mode 100644 target/tilegx/translate.c

-- 
2.27.0


Re: [PULL 00/14] Gitlab, testing and misc patches
Posted by no-reply@patchew.org 3 years, 2 months ago
Patchew URL: https://patchew.org/QEMU/20210309104617.714908-1-thuth@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210309104617.714908-1-thuth@redhat.com
Subject: [PULL 00/14] Gitlab, testing and misc patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210211141515.8755-1-peter.maydell@linaro.org -> patchew/20210211141515.8755-1-peter.maydell@linaro.org
 * [new tag]         patchew/20210309104617.714908-1-thuth@redhat.com -> patchew/20210309104617.714908-1-thuth@redhat.com
Switched to a new branch 'test'
001e0f6 bsd-user: Add new maintainers
cd54f81 Remove deprecated target tilegx
4dee290 Acceptance Tests: restore filtering of tests by target arch
7e2d943 Acceptance Tests: restore downloading of VM images
1767be5 docs/devel/qgraph: improve qgraph documentation
a634eaa libqos/qgraph: format qgraph comments for sphinx documentation
1403828 scripts/ci/gitlab-pipeline-status: give more info when pipeline not found
9617084 scripts/ci/gitlab-pipeline-status: give more information on failures
9c1ae24 scripts/ci/gitlab-pipeline-status: split utlity function for HTTP GET
2c190bb meson: Re-enable the possibility to run "make check SPEED=slow"
861d83e docker: OpenSBI build job depends on OpenSBI container
60fbc18 docker: EDK2 build job depends on EDK2 container
994ed82 docker: Alpine build job depends on Alpine container
fb49f31 qtest: delete superfluous inclusions of qtest.h

=== OUTPUT BEGIN ===
1/14 Checking commit fb49f3160768 (qtest: delete superfluous inclusions of qtest.h)
2/14 Checking commit 994ed821f8ca (docker: Alpine build job depends on Alpine container)
3/14 Checking commit 60fbc1850698 (docker: EDK2 build job depends on EDK2 container)
4/14 Checking commit 861d83ed84ea (docker: OpenSBI build job depends on OpenSBI container)
5/14 Checking commit 2c190bb5a241 (meson: Re-enable the possibility to run "make check SPEED=slow")
ERROR: line over 90 characters
#29: FILE: scripts/mtest2make.py:24:
+.test-human-tap = $1 $(if $4,(cd $4 && $2),$2) -m $(SPEED) < /dev/null | ./scripts/tap-driver.pl --test-name="$3" $(if $(V),,--show-failures-only)

total: 1 errors, 0 warnings, 8 lines checked

Patch 5/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/14 Checking commit 9c1ae2452947 (scripts/ci/gitlab-pipeline-status: split utlity function for HTTP GET)
7/14 Checking commit 961708432958 (scripts/ci/gitlab-pipeline-status: give more information on failures)
8/14 Checking commit 14038289c263 (scripts/ci/gitlab-pipeline-status: give more info when pipeline not found)
9/14 Checking commit a634eaa7abff (libqos/qgraph: format qgraph comments for sphinx documentation)
10/14 Checking commit 1767be58ba47 (docs/devel/qgraph: improve qgraph documentation)
11/14 Checking commit 7e2d943e6431 (Acceptance Tests: restore downloading of VM images)
12/14 Checking commit 4dee2904be7a (Acceptance Tests: restore filtering of tests by target arch)
13/14 Checking commit cd54f81d00d6 (Remove deprecated target tilegx)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#82: 
deleted file mode 100644

total: 0 errors, 1 warnings, 130 lines checked

Patch 13/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/14 Checking commit 001e0f6d9cce (bsd-user: Add new maintainers)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210309104617.714908-1-thuth@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PULL 00/14] Gitlab, testing and misc patches
Posted by Peter Maydell 3 years, 2 months ago
On Tue, 9 Mar 2021 at 10:55, Thomas Huth <thuth@redhat.com> wrote:
>
>  Hi Peter,
>
> the following changes since commit 229a834518b950d56fd1bc94923276504d0ee9d4:
>
>   Merge remote-tracking branch 'remotes/philmd-gitlab/tags/renesas-20210306' into staging (2021-03-08 15:45:48 +0000)
>
> are available in the Git repository at:
>
>   https://gitlab.com/thuth/qemu.git tags/pull-request-2021-03-09
>
> for you to fetch changes up to 65a9d3807e9a0ffd9f9719416a07be41b6f39e94:
>
>   bsd-user: Add new maintainers (2021-03-09 11:26:32 +0100)
>
> Gitlab-CI run can be found here:
>
>  https://gitlab.com/thuth/qemu/-/pipelines/267522743
>
> ----------------------------------------------------------------
> * Add some missing gitlab-CI job dependencies
> * Re-enable "make check SPEED=slow"
> * Improve the gitlab-pipeline-status script
> * Clean up inclusing of qtest.h headers
> * Improve libqos/qgraph documentation
> * Fix downloading problem in the acceptance tests
> * Remove deprecated target tilegx
> * Add new bsd-user maintainers


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
for any user-visible changes.

-- PMM