[PATCH 0/4] vhost-user-blk-test: add vhost-user-blk server tests

Stefan Hajnoczi posted 4 patches 4 years, 8 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210309094106.196911-1-stefanha@redhat.com
MAINTAINERS                          |   2 +
tests/qtest/libqos/vhost-user-blk.h  |  48 ++
block/export/vhost-user-blk-server.c |   3 +-
tests/qtest/libqos/vhost-user-blk.c  | 130 ++++
tests/qtest/vhost-user-blk-test.c    | 983 +++++++++++++++++++++++++++
tests/qtest/libqos/meson.build       |   1 +
tests/qtest/meson.build              |   4 +
7 files changed, 1169 insertions(+), 2 deletions(-)
create mode 100644 tests/qtest/libqos/vhost-user-blk.h
create mode 100644 tests/qtest/libqos/vhost-user-blk.c
create mode 100644 tests/qtest/vhost-user-blk-test.c
[PATCH 0/4] vhost-user-blk-test: add vhost-user-blk server tests
Posted by Stefan Hajnoczi 4 years, 8 months ago
These patches were dropped from Kevin's last block pull request due to a GitLab
CI failure. The old CentOS 7 and opensuse Leap build images lack
memfd_create(2) (introduced in Linux around 2014). The vhost-user-blk server
had a dependency on memfd_create(2) due to VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD
and qemu-storage-daemon would fail to create a vhost-user-blk export.

Since we have not thought about or tested VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD
anyway, disable it for now. It can be re-enabled again later when it's needed
for reconnection support.

Coiby Xu (1):
  test: new qTest case to test the vhost-user-blk-server

Stefan Hajnoczi (3):
  block/export: disable VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD for now
  tests/qtest: add multi-queue test case to vhost-user-blk-test
  vhost-user-blk-test: test discard/write zeroes invalid inputs

 MAINTAINERS                          |   2 +
 tests/qtest/libqos/vhost-user-blk.h  |  48 ++
 block/export/vhost-user-blk-server.c |   3 +-
 tests/qtest/libqos/vhost-user-blk.c  | 130 ++++
 tests/qtest/vhost-user-blk-test.c    | 983 +++++++++++++++++++++++++++
 tests/qtest/libqos/meson.build       |   1 +
 tests/qtest/meson.build              |   4 +
 7 files changed, 1169 insertions(+), 2 deletions(-)
 create mode 100644 tests/qtest/libqos/vhost-user-blk.h
 create mode 100644 tests/qtest/libqos/vhost-user-blk.c
 create mode 100644 tests/qtest/vhost-user-blk-test.c

-- 
2.29.2

Re: [PATCH 0/4] vhost-user-blk-test: add vhost-user-blk server tests
Posted by Kevin Wolf 4 years, 8 months ago
Am 09.03.2021 um 10:41 hat Stefan Hajnoczi geschrieben:
> These patches were dropped from Kevin's last block pull request due to a GitLab
> CI failure. The old CentOS 7 and opensuse Leap build images lack
> memfd_create(2) (introduced in Linux around 2014). The vhost-user-blk server
> had a dependency on memfd_create(2) due to VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD
> and qemu-storage-daemon would fail to create a vhost-user-blk export.
> 
> Since we have not thought about or tested VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD
> anyway, disable it for now. It can be re-enabled again later when it's needed
> for reconnection support.

Thanks, applied to the block branch.

Kevin