improve loading of 32 bit PVH kernels

[PATCH 0/2] improve loading of 32 bit PVH kernels

David Edmondson posted 2 patches 3 years, 2 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210302090315.3031492-1-david.edmondson@oracle.com

Maintainers: Eduardo Habkost <ehabkost@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com>

hw/i386/x86.c        | 6 ++++--
include/hw/elf_ops.h | 4 +---
2 files changed, 5 insertions(+), 5 deletions(-)

Expand all Fold all

[PATCH 0/2] improve loading of 32 bit PVH kernels

Posted by David Edmondson 3 years, 2 months ago

While testing a non-Linux 32 bit PVH "kernel" (it's really just a
bunch of test code), I ran into some problems with the current PVH
loader in QEMU, which seems to work somewhat by accident for 32 bit
kernels today, having been fortunate in the layout of the object files
it typically encounters.

Non-PAE 32 bit Linux kernels still don't appear to work even with this
change, but I think that problem is somewhere else (the kernel is
loaded and starts, but the VM resets when it attempts to enable PG/PE)
and I haven't tracked it down yet.

David Edmondson (2):
  elf_ops: correct loading of 32 bit PVH kernel
  x86/pvh: extract only 4 bytes of start address for 32 bit kernels

 hw/i386/x86.c        | 6 ++++--
 include/hw/elf_ops.h | 4 +---
 2 files changed, 5 insertions(+), 5 deletions(-)

-- 
2.30.0

Re: [PATCH 0/2] improve loading of 32 bit PVH kernels

Posted by Philippe Mathieu-Daudé 3 years, 2 months ago

Cc'ing Stefano

On 3/2/21 10:03 AM, David Edmondson wrote:
> While testing a non-Linux 32 bit PVH "kernel" (it's really just a
> bunch of test code), I ran into some problems with the current PVH
> loader in QEMU, which seems to work somewhat by accident for 32 bit
> kernels today, having been fortunate in the layout of the object files
> it typically encounters.
> 
> Non-PAE 32 bit Linux kernels still don't appear to work even with this
> change, but I think that problem is somewhere else (the kernel is
> loaded and starts, but the VM resets when it attempts to enable PG/PE)
> and I haven't tracked it down yet.
> 
> David Edmondson (2):
>   elf_ops: correct loading of 32 bit PVH kernel
>   x86/pvh: extract only 4 bytes of start address for 32 bit kernels
> 
>  hw/i386/x86.c        | 6 ++++--
>  include/hw/elf_ops.h | 4 +---
>  2 files changed, 5 insertions(+), 5 deletions(-)
>

Re: [PATCH 0/2] improve loading of 32 bit PVH kernels

Posted by Paolo Bonzini 3 years, 2 months ago

On 02/03/21 10:03, David Edmondson wrote:
> While testing a non-Linux 32 bit PVH "kernel" (it's really just a
> bunch of test code), I ran into some problems with the current PVH
> loader in QEMU, which seems to work somewhat by accident for 32 bit
> kernels today, having been fortunate in the layout of the object files
> it typically encounters.
> 
> Non-PAE 32 bit Linux kernels still don't appear to work even with this
> change, but I think that problem is somewhere else (the kernel is
> loaded and starts, but the VM resets when it attempts to enable PG/PE)
> and I haven't tracked it down yet.
> 
> David Edmondson (2):
>    elf_ops: correct loading of 32 bit PVH kernel
>    x86/pvh: extract only 4 bytes of start address for 32 bit kernels
> 
>   hw/i386/x86.c        | 6 ++++--
>   include/hw/elf_ops.h | 4 +---
>   2 files changed, 5 insertions(+), 5 deletions(-)
> 

Queued, thanks.

Paolo