The STATUS register will be reset to IDLE in
cnpcm7xx_smbus_enter_reset(), no need to preset
it in instance_init().
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/i2c/npcm7xx_smbus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/i2c/npcm7xx_smbus.c b/hw/i2c/npcm7xx_smbus.c
index 6b2f9e1aaad..e7e0ba66fe7 100644
--- a/hw/i2c/npcm7xx_smbus.c
+++ b/hw/i2c/npcm7xx_smbus.c
@@ -1040,7 +1040,6 @@ static void npcm7xx_smbus_init(Object *obj)
sysbus_init_mmio(sbd, &s->iomem);
s->bus = i2c_init_bus(DEVICE(s), "i2c-bus");
- s->status = NPCM7XX_SMBUS_STATUS_IDLE;
}
static const VMStateDescription vmstate_npcm7xx_smbus = {
--
2.26.2
On Sun, Feb 28, 2021 at 2:50 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > The STATUS register will be reset to IDLE in > cnpcm7xx_smbus_enter_reset(), no need to preset > it in instance_init(). > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > Reviewed-by: Hao Wu <wuhaotsh@google.com> > --- > hw/i2c/npcm7xx_smbus.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/i2c/npcm7xx_smbus.c b/hw/i2c/npcm7xx_smbus.c > index 6b2f9e1aaad..e7e0ba66fe7 100644 > --- a/hw/i2c/npcm7xx_smbus.c > +++ b/hw/i2c/npcm7xx_smbus.c > @@ -1040,7 +1040,6 @@ static void npcm7xx_smbus_init(Object *obj) > sysbus_init_mmio(sbd, &s->iomem); > > s->bus = i2c_init_bus(DEVICE(s), "i2c-bus"); > - s->status = NPCM7XX_SMBUS_STATUS_IDLE; > } > > static const VMStateDescription vmstate_npcm7xx_smbus = { > -- > 2.26.2 > > >
On Sun, 28 Feb 2021 at 22:50, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > The STATUS register will be reset to IDLE in > cnpcm7xx_smbus_enter_reset(), no need to preset > it in instance_init(). > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/i2c/npcm7xx_smbus.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/i2c/npcm7xx_smbus.c b/hw/i2c/npcm7xx_smbus.c > index 6b2f9e1aaad..e7e0ba66fe7 100644 > --- a/hw/i2c/npcm7xx_smbus.c > +++ b/hw/i2c/npcm7xx_smbus.c > @@ -1040,7 +1040,6 @@ static void npcm7xx_smbus_init(Object *obj) > sysbus_init_mmio(sbd, &s->iomem); > > s->bus = i2c_init_bus(DEVICE(s), "i2c-bus"); > - s->status = NPCM7XX_SMBUS_STATUS_IDLE; > } > > static const VMStateDescription vmstate_npcm7xx_smbus = Applied to target-arm.next, thanks. -- PMM
© 2016 - 2024 Red Hat, Inc.