Hi,

This series is a rework of the 'Add Dockerfile for hexagon' patch
from Alessandro/Brian that Taylor sent in v8:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg780330.html
but adapted to mainstream.

Gitlab shared runner are usually capped to 2/4 cores and timeout
after 2h30 to 3h. We need a beefy custom runner to get the image
built and stored in the registry. For now the image is added in
manual mode, hopping we'll have magic runners added some day to
build the image, then developers can directly pull it from the
registry.

Alessandro Di Federico (2):
  docker: Add Hexagon image
  tests/tcg: Use Hexagon Docker image

Philippe Mathieu-Daud=C3=A9 (2):
  gitlab-ci: Pass optional EXTRA_FILES when building docker images
  gitlab-ci: Build Hexagon cross-toolchain

 .gitlab-ci.d/containers.yml                   |  11 ++
 tests/docker/Makefile.include                 |   2 +
 .../dockerfiles/debian-hexagon-cross.docker   |  23 +++
 .../build-toolchain.sh                        | 141 ++++++++++++++++++
 tests/tcg/configure.sh                        |   4 +
 5 files changed, 181 insertions(+)
 create mode 100644 tests/docker/dockerfiles/debian-hexagon-cross.docker
 create mode 100755 tests/docker/dockerfiles/debian-hexagon-cross.docker.d/bu=
ild-toolchain.sh

--=20
2.26.2

On Sun, 28 Feb 2021 23:23:10 +0100
Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:

> This series is a rework of the 'Add Dockerfile for hexagon' patch
> from Alessandro/Brian that Taylor sent in v8:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg780330.html
> but adapted to mainstream.

All of this looks good to me.

Sadly, we've been doing internally exactly the same thing and were close
to push it upstream. We'll be more explicit on what we're doing.

Anyway, thanks for taking care of this!

-- 
Alessandro Di Federico
rev.ng

On 3/1/21 2:25 PM, Alessandro Di Federico wrote:
> On Sun, 28 Feb 2021 23:23:10 +0100
> Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> 
>> This series is a rework of the 'Add Dockerfile for hexagon' patch
>> from Alessandro/Brian that Taylor sent in v8:
>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg780330.html
>> but adapted to mainstream.
> 
> All of this looks good to me.
> 
> Sadly, we've been doing internally exactly the same thing and were close
> to push it upstream. We'll be more explicit on what we're doing.

Great. I don't have much time for this, but I'd rather not have
the hexagon port start to bitrot because untested, which is why
I tried to get the testing loop started. I'll let you following
with it then, thanks!

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> Hi,
>
> This series is a rework of the 'Add Dockerfile for hexagon' patch
> from Alessandro/Brian that Taylor sent in v8:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg780330.html
> but adapted to mainstream.

Queued patches 1 and 2 to testing/next, thanks.

>
> Gitlab shared runner are usually capped to 2/4 cores and timeout
> after 2h30 to 3h. We need a beefy custom runner to get the image
> built and stored in the registry. For now the image is added in
> manual mode, hopping we'll have magic runners added some day to
> build the image, then developers can directly pull it from the
> registry.
>
> Alessandro Di Federico (2):
>   docker: Add Hexagon image
>   tests/tcg: Use Hexagon Docker image
>
> Philippe Mathieu-Daud=C3=A9 (2):
>   gitlab-ci: Pass optional EXTRA_FILES when building docker images
>   gitlab-ci: Build Hexagon cross-toolchain
>
>  .gitlab-ci.d/containers.yml                   |  11 ++
>  tests/docker/Makefile.include                 |   2 +
>  .../dockerfiles/debian-hexagon-cross.docker   |  23 +++
>  .../build-toolchain.sh                        | 141 ++++++++++++++++++
>  tests/tcg/configure.sh                        |   4 +
>  5 files changed, 181 insertions(+)
>  create mode 100644 tests/docker/dockerfiles/debian-hexagon-cross.docker
>  create mode 100755 tests/docker/dockerfiles/debian-hexagon-cross.docker.d/bu=
> ild-toolchain.sh
>
> --=20
> 2.26.2


-- 
Alex Bennée

I of course meant 1 and 4 (skipping the gitlab bits)

On Thu, 4 Mar 2021 at 13:45, Alex Bennée <alex.bennee@linaro.org> wrote:
>
>
> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
>
> > Hi,
> >
> > This series is a rework of the 'Add Dockerfile for hexagon' patch
> > from Alessandro/Brian that Taylor sent in v8:
> > https://www.mail-archive.com/qemu-devel@nongnu.org/msg780330.html
> > but adapted to mainstream.
>
> Queued patches 1 and 2 to testing/next, thanks.
>
> >
> > Gitlab shared runner are usually capped to 2/4 cores and timeout
> > after 2h30 to 3h. We need a beefy custom runner to get the image
> > built and stored in the registry. For now the image is added in
> > manual mode, hopping we'll have magic runners added some day to
> > build the image, then developers can directly pull it from the
> > registry.
> >
> > Alessandro Di Federico (2):
> >   docker: Add Hexagon image
> >   tests/tcg: Use Hexagon Docker image
> >
> > Philippe Mathieu-Daud=C3=A9 (2):
> >   gitlab-ci: Pass optional EXTRA_FILES when building docker images
> >   gitlab-ci: Build Hexagon cross-toolchain
> >
> >  .gitlab-ci.d/containers.yml                   |  11 ++
> >  tests/docker/Makefile.include                 |   2 +
> >  .../dockerfiles/debian-hexagon-cross.docker   |  23 +++
> >  .../build-toolchain.sh                        | 141 ++++++++++++++++++
> >  tests/tcg/configure.sh                        |   4 +
> >  5 files changed, 181 insertions(+)
> >  create mode 100644 tests/docker/dockerfiles/debian-hexagon-cross.docker
> >  create mode 100755 tests/docker/dockerfiles/debian-hexagon-cross.docker.d/bu=
> > ild-toolchain.sh
> >
> > --=20
> > 2.26.2
>
>
> --
> Alex Bennée



-- 
Alex Bennée
KVM/QEMU Hacker for Linaro

> -----Original Message-----
> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Sunday, February 28, 2021 4:23 PM
> To: qemu-devel@nongnu.org
> Cc: Fam Zheng <fam@euphon.net>; Taylor Simpson
> <tsimpson@quicinc.com>; Philippe Mathieu-Daudé <philmd@redhat.com>;
> Alex Bennée <alex.bennee@linaro.org>; Alessandro Di Federico
> <ale.qemu@rev.ng>; Brian Cain <bcain@quicinc.com>; Philippe Mathieu-
> Daudé <f4bug@amsat.org>
> Subject: [PATCH 0/4] hexagon: Add Docker image & testing to gitlab-ci
>
> Hi,
>
> This series is a rework of the 'Add Dockerfile for hexagon' patch
> from Alessandro/Brian that Taylor sent in v8:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg780330.html
> but adapted to mainstream.
>
> Gitlab shared runner are usually capped to 2/4 cores and timeout
> after 2h30 to 3h. We need a beefy custom runner to get the image
> built and stored in the registry. For now the image is added in
> manual mode, hopping we'll have magic runners added some day to
> build the image, then developers can directly pull it from the
> registry.

Thanks a ton for doing this.

Do I understand correctly that someone will manually run the toolchain build scripts to create the container and others will be able to use the prebuilt container after that?

Taylor

Patchew URL: https://patchew.org/QEMU/20210228222314.304787-1-f4bug@amsat.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210228222314.304787-1-f4bug@amsat.org
Subject: [PATCH 0/4] hexagon: Add Docker image & testing to gitlab-ci

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210227232519.222663-1-richard.henderson@linaro.org -> patchew/20210227232519.222663-1-richard.henderson@linaro.org
 - [tag update]      patchew/20210228050609.24779-1-bmeng.cn@gmail.com -> patchew/20210228050609.24779-1-bmeng.cn@gmail.com
 - [tag update]      patchew/20210228111657.23240-1-ashe@kivikakk.ee -> patchew/20210228111657.23240-1-ashe@kivikakk.ee
 * [new tag]         patchew/20210228222314.304787-1-f4bug@amsat.org -> patchew/20210228222314.304787-1-f4bug@amsat.org
Switched to a new branch 'test'
4307c0a tests/tcg: Use Hexagon Docker image
5979932 gitlab-ci: Build Hexagon cross-toolchain
ef6031b gitlab-ci: Pass optional EXTRA_FILES when building docker images
65568ad docker: Add Hexagon image

=== OUTPUT BEGIN ===
1/4 Checking commit 65568ad6da35 (docker: Add Hexagon image)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

WARNING: line over 80 characters
#127: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:63:
+    -DCMAKE_ASM_FLAGS="-G0 -mlong-calls -fno-pic --target=hexagon-unknown-linux-musl " \

ERROR: line over 90 characters
#154: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:90:
+    CROSS_CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \

ERROR: line over 90 characters
#191: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:127:
+    CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \

total: 2 errors, 2 warnings, 172 lines checked

Patch 1/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/4 Checking commit ef6031b9a8b8 (gitlab-ci: Pass optional EXTRA_FILES when building docker images)
3/4 Checking commit 597993295a13 (gitlab-ci: Build Hexagon cross-toolchain)
4/4 Checking commit 4307c0a16c21 (tests/tcg: Use Hexagon Docker image)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210228222314.304787-1-f4bug@amsat.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com