hw/sd: sd: Fix build error when DEBUG_SD is on

[PATCH] hw/sd: sd: Fix build error when DEBUG_SD is on

Bin Meng posted 1 patch 4 years, 11 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210228050609.24779-1-bmeng.cn@gmail.com

Maintainers: Bin Meng <bin.meng@windriver.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>

hw/sd/sd.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] hw/sd: sd: Fix build error when DEBUG_SD is on

Posted by Bin Meng 4 years, 11 months ago

From: Bin Meng <bin.meng@windriver.com>

"qemu-common.h" should be included to provide the forward declaration
of qemu_hexdump() when DEBUG_SD is on.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
---

 hw/sd/sd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 8b397effbc..7b09ce9c2e 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -47,6 +47,7 @@
 #include "qemu/timer.h"
 #include "qemu/log.h"
 #include "qemu/module.h"
+#include "qemu-common.h"
 #include "sdmmc-internal.h"
 #include "trace.h"
 
-- 
2.25.1

Re: [PATCH] hw/sd: sd: Fix build error when DEBUG_SD is on

Posted by Philippe Mathieu-Daudé 4 years, 10 months ago

On 2/28/21 6:06 AM, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
> 
> "qemu-common.h" should be included to provide the forward declaration
> of qemu_hexdump() when DEBUG_SD is on.
> 
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
> 
>  hw/sd/sd.c | 1 +
>  1 file changed, 1 insertion(+)

Thanks, patch applied to sdmmc-fixes.

Re: [PATCH] hw/sd: sd: Fix build error when DEBUG_SD is on

Posted by Philippe Mathieu-Daudé 4 years, 11 months ago

On 2/28/21 6:06 AM, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
> 
> "qemu-common.h" should be included to provide the forward declaration
> of qemu_hexdump() when DEBUG_SD is on.
> 
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
> 
>  hw/sd/sd.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>