hw/net: fsl_etsec: Fix build error when HEX_DUMP is on

[PATCH] hw/net: fsl_etsec: Fix build error when HEX_DUMP is on

Bin Meng posted 1 patch 4 years, 11 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210228050431.24647-1-bmeng.cn@gmail.com

Maintainers: Jason Wang <jasowang@redhat.com>, Greg Kurz <groug@kaod.org>, David Gibson <david@gibson.dropbear.id.au>

hw/net/fsl_etsec/etsec.c | 1 +
hw/net/fsl_etsec/rings.c | 1 +
2 files changed, 2 insertions(+)

Expand all Fold all

[PATCH] hw/net: fsl_etsec: Fix build error when HEX_DUMP is on

Posted by Bin Meng 4 years, 11 months ago

From: Bin Meng <bin.meng@windriver.com>

"qemu-common.h" should be included to provide the forward declaration
of qemu_hexdump() when HEX_DUMP is on.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
---

 hw/net/fsl_etsec/etsec.c | 1 +
 hw/net/fsl_etsec/rings.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
index 93886bba60..bd9d62b559 100644
--- a/hw/net/fsl_etsec/etsec.c
+++ b/hw/net/fsl_etsec/etsec.c
@@ -27,6 +27,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu-common.h"
 #include "hw/sysbus.h"
 #include "hw/irq.h"
 #include "hw/ptimer.h"
diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c
index fe055d3381..d6be0d7d18 100644
--- a/hw/net/fsl_etsec/rings.c
+++ b/hw/net/fsl_etsec/rings.c
@@ -22,6 +22,7 @@
  * THE SOFTWARE.
  */
 #include "qemu/osdep.h"
+#include "qemu-common.h"
 #include "net/checksum.h"
 #include "qemu/log.h"
 #include "etsec.h"
-- 
2.25.1

Re: [PATCH] hw/net: fsl_etsec: Fix build error when HEX_DUMP is on

Posted by David Gibson 4 years, 11 months ago

On Sun, Feb 28, 2021 at 01:04:31PM +0800, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
> 
> "qemu-common.h" should be included to provide the forward declaration
> of qemu_hexdump() when HEX_DUMP is on.

Applied to ppc-for-6.0, thanks.

> 
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
> 
>  hw/net/fsl_etsec/etsec.c | 1 +
>  hw/net/fsl_etsec/rings.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
> index 93886bba60..bd9d62b559 100644
> --- a/hw/net/fsl_etsec/etsec.c
> +++ b/hw/net/fsl_etsec/etsec.c
> @@ -27,6 +27,7 @@
>   */
>  
>  #include "qemu/osdep.h"
> +#include "qemu-common.h"
>  #include "hw/sysbus.h"
>  #include "hw/irq.h"
>  #include "hw/ptimer.h"
> diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c
> index fe055d3381..d6be0d7d18 100644
> --- a/hw/net/fsl_etsec/rings.c
> +++ b/hw/net/fsl_etsec/rings.c
> @@ -22,6 +22,7 @@
>   * THE SOFTWARE.
>   */
>  #include "qemu/osdep.h"
> +#include "qemu-common.h"
>  #include "net/checksum.h"
>  #include "qemu/log.h"
>  #include "etsec.h"

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson