[v1] net: Fix build error when DEBUG_NET is on

[PATCH] net: Fix build error when DEBUG_NET is on

Bin Meng posted 1 patch 4 years, 8 months ago

Diff against v1
Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210228050218.24517-1-bmeng.cn@gmail.com

net/net.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] net: Fix build error when DEBUG_NET is on

Posted by Bin Meng 4 years, 8 months ago

From: Bin Meng <bin.meng@windriver.com>

"qemu-common.h" should be included to provide the forward declaration
of qemu_hexdump() when DEBUG_NET is on.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

---

Changes in v2:
- add "Reviewed-By" tag

 net/net.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/net.c b/net/net.c
index fb7b7dcc25..32d71c1172 100644
--- a/net/net.c
+++ b/net/net.c
@@ -23,6 +23,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu-common.h"
 
 #include "net/net.h"
 #include "clients.h"
-- 
2.25.1

Re: [PATCH] net: Fix build error when DEBUG_NET is on

Posted by Jason Wang 4 years, 8 months ago

On 2021/2/28 1:02 下午, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
>
> "qemu-common.h" should be included to provide the forward declaration
> of qemu_hexdump() when DEBUG_NET is on.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


Applied.

Thanks


>
> ---
>
> Changes in v2:
> - add "Reviewed-By" tag
>
>   net/net.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/net/net.c b/net/net.c
> index fb7b7dcc25..32d71c1172 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -23,6 +23,7 @@
>    */
>   
>   #include "qemu/osdep.h"
> +#include "qemu-common.h"
>   
>   #include "net/net.h"
>   #include "clients.h"