Fix mips jazz vs constant TCGCPUOps

[PATCH 0/2] Fix mips jazz vs constant TCGCPUOps

Richard Henderson posted 2 patches 4 years, 9 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210227232519.222663-1-richard.henderson@linaro.org

Maintainers: Sarah Harris <S.E.Harris@kent.ac.uk>, Michael Rolnik <mrolnik@gmail.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, David Hildenbrand <david@redhat.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Richard Henderson <richard.henderson@linaro.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Laurent Vivier <laurent@vivier.eu>, Marek Vasut <marex@denx.de>, Max Filippov <jcmvbkbc@gmail.com>, Alistair Francis <Alistair.Francis@wdc.com>, Eduardo Habkost <ehabkost@redhat.com>, Anthony Green <green@moxielogic.com>, Aurelien Jarno <aurelien@aurel32.net>, Thomas Huth <thuth@redhat.com>, Taylor Simpson <tsimpson@quicinc.com>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Peter Maydell <peter.maydell@linaro.org>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>, Stafford Horne <shorne@gmail.com>, Greg Kurz <groug@kaod.org>, Sagar Karandikar <sagark@eecs.berkeley.edu>, David Gibson <david@gibson.dropbear.id.au>, Chris Wulff <crwulff@gmail.com>, Michael Walle <michael@walle.cc>, "Hervé Poussineau" <hpoussin@reactos.org>, Palmer Dabbelt <palmer@dabbelt.com>, Cornelia Huck <cohuck@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>

include/hw/core/cpu.h           |  2 +-
target/mips/cpu-qom.h           |  3 +++
hw/mips/jazz.c                  | 35 +++------------------------------
target/alpha/cpu.c              |  2 +-
target/arm/cpu.c                |  2 +-
target/arm/cpu_tcg.c            |  2 +-
target/avr/cpu.c                |  2 +-
target/cris/cpu.c               |  4 ++--
target/hexagon/cpu.c            |  2 +-
target/hppa/cpu.c               |  2 +-
target/i386/tcg/tcg-cpu.c       |  2 +-
target/lm32/cpu.c               |  2 +-
target/m68k/cpu.c               |  2 +-
target/microblaze/cpu.c         |  2 +-
target/mips/cpu.c               |  2 +-
target/mips/op_helper.c         |  3 ++-
target/moxie/cpu.c              |  2 +-
target/nios2/cpu.c              |  2 +-
target/openrisc/cpu.c           |  2 +-
target/riscv/cpu.c              |  2 +-
target/rx/cpu.c                 |  2 +-
target/s390x/cpu.c              |  2 +-
target/sh4/cpu.c                |  2 +-
target/sparc/cpu.c              |  2 +-
target/tilegx/cpu.c             |  2 +-
target/tricore/cpu.c            |  2 +-
target/unicore32/cpu.c          |  2 +-
target/xtensa/cpu.c             |  2 +-
target/ppc/translate_init.c.inc |  2 +-
29 files changed, 35 insertions(+), 60 deletions(-)

Expand all Fold all

[PATCH 0/2] Fix mips jazz vs constant TCGCPUOps

Posted by Richard Henderson 4 years, 9 months ago

We can implement the jazz behaviour with a flag on MIPSCPUClass,
rather than by adjusting the do_transaction_failed callback.


r~


Richard Henderson (2):
  target/mips: Fold jazz behaviour into mips_cpu_do_transaction_failed
  hw/core: Constify TCGCPUOps

 include/hw/core/cpu.h           |  2 +-
 target/mips/cpu-qom.h           |  3 +++
 hw/mips/jazz.c                  | 35 +++------------------------------
 target/alpha/cpu.c              |  2 +-
 target/arm/cpu.c                |  2 +-
 target/arm/cpu_tcg.c            |  2 +-
 target/avr/cpu.c                |  2 +-
 target/cris/cpu.c               |  4 ++--
 target/hexagon/cpu.c            |  2 +-
 target/hppa/cpu.c               |  2 +-
 target/i386/tcg/tcg-cpu.c       |  2 +-
 target/lm32/cpu.c               |  2 +-
 target/m68k/cpu.c               |  2 +-
 target/microblaze/cpu.c         |  2 +-
 target/mips/cpu.c               |  2 +-
 target/mips/op_helper.c         |  3 ++-
 target/moxie/cpu.c              |  2 +-
 target/nios2/cpu.c              |  2 +-
 target/openrisc/cpu.c           |  2 +-
 target/riscv/cpu.c              |  2 +-
 target/rx/cpu.c                 |  2 +-
 target/s390x/cpu.c              |  2 +-
 target/sh4/cpu.c                |  2 +-
 target/sparc/cpu.c              |  2 +-
 target/tilegx/cpu.c             |  2 +-
 target/tricore/cpu.c            |  2 +-
 target/unicore32/cpu.c          |  2 +-
 target/xtensa/cpu.c             |  2 +-
 target/ppc/translate_init.c.inc |  2 +-
 29 files changed, 35 insertions(+), 60 deletions(-)

-- 
2.25.1

Re: [PATCH 0/2] Fix mips jazz vs constant TCGCPUOps

Posted by Claudio Fontana 4 years, 9 months ago

On 2/28/21 12:25 AM, Richard Henderson wrote:
> We can implement the jazz behaviour with a flag on MIPSCPUClass,
> rather than by adjusting the do_transaction_failed callback.
> 
> 
> r~
> 

Reviewed-by: Claudio Fontana <cfontana@suse.de>

> 
> Richard Henderson (2):
>   target/mips: Fold jazz behaviour into mips_cpu_do_transaction_failed
>   hw/core: Constify TCGCPUOps
> 
>  include/hw/core/cpu.h           |  2 +-
>  target/mips/cpu-qom.h           |  3 +++
>  hw/mips/jazz.c                  | 35 +++------------------------------
>  target/alpha/cpu.c              |  2 +-
>  target/arm/cpu.c                |  2 +-
>  target/arm/cpu_tcg.c            |  2 +-
>  target/avr/cpu.c                |  2 +-
>  target/cris/cpu.c               |  4 ++--
>  target/hexagon/cpu.c            |  2 +-
>  target/hppa/cpu.c               |  2 +-
>  target/i386/tcg/tcg-cpu.c       |  2 +-
>  target/lm32/cpu.c               |  2 +-
>  target/m68k/cpu.c               |  2 +-
>  target/microblaze/cpu.c         |  2 +-
>  target/mips/cpu.c               |  2 +-
>  target/mips/op_helper.c         |  3 ++-
>  target/moxie/cpu.c              |  2 +-
>  target/nios2/cpu.c              |  2 +-
>  target/openrisc/cpu.c           |  2 +-
>  target/riscv/cpu.c              |  2 +-
>  target/rx/cpu.c                 |  2 +-
>  target/s390x/cpu.c              |  2 +-
>  target/sh4/cpu.c                |  2 +-
>  target/sparc/cpu.c              |  2 +-
>  target/tilegx/cpu.c             |  2 +-
>  target/tricore/cpu.c            |  2 +-
>  target/unicore32/cpu.c          |  2 +-
>  target/xtensa/cpu.c             |  2 +-
>  target/ppc/translate_init.c.inc |  2 +-
>  29 files changed, 35 insertions(+), 60 deletions(-)
>