[v4] hw/sh4: Kconfig cleanups

[PATCH v4 0/8] hw/sh4: Kconfig cleanups

Posted by Philippe Mathieu-Daudé 3 years, 2 months ago

Missing review: 1 (license)

Since v3:
- Include full MIT license text (Peter)

Since v2:
- Added missing TC58128/SH_PCI Kconfig entries (Peter)

Since v1:
- Addressed Peter Maydell review comments from
https://www.mail-archive.com/qemu-block@nongnu.org/msg80599.html

Philippe Mathieu-Daudé (8):
  hw/sh4: Add missing license
  hw/sh4: Add missing Kconfig dependency on SH7750 for the R2D board
  hw/intc: Introduce SH_INTC Kconfig entry
  hw/char: Introduce SH_SCI Kconfig entry
  hw/timer: Introduce SH_TIMER Kconfig entry
  hw/block: Introduce TC58128 eeprom Kconfig entry
  hw/pci-host: Introduce SH_PCI Kconfig entry
  hw/sh4: Remove now unused CONFIG_SH4 from Kconfig

 include/hw/sh4/sh.h           | 31 ++++++++++++++++++++++++++++---
 hw/block/tc58128.c            | 26 ++++++++++++++++++++++++++
 hw/{sh4 => pci-host}/sh_pci.c |  0
 MAINTAINERS                   |  6 ++++++
 hw/block/Kconfig              |  3 +++
 hw/block/meson.build          |  2 +-
 hw/char/Kconfig               |  3 +++
 hw/char/meson.build           |  2 +-
 hw/intc/Kconfig               |  3 +++
 hw/intc/meson.build           |  2 +-
 hw/pci-host/Kconfig           |  4 ++++
 hw/pci-host/meson.build       |  1 +
 hw/sh4/Kconfig                | 12 ++++++------
 hw/sh4/meson.build            |  1 -
 hw/timer/Kconfig              |  4 ++++
 hw/timer/meson.build          |  2 +-
 16 files changed, 88 insertions(+), 14 deletions(-)
 rename hw/{sh4 => pci-host}/sh_pci.c (100%)

-- 
2.26.2

Re: [PATCH v4 0/8] hw/sh4: Kconfig cleanups

Posted by Paolo Bonzini 3 years, 2 months ago

On 22/02/21 15:15, Philippe Mathieu-Daudé wrote:
> Missing review: 1 (license)
> 
> Since v3:
> - Include full MIT license text (Peter)
> 
> Since v2:
> - Added missing TC58128/SH_PCI Kconfig entries (Peter)
> 
> Since v1:
> - Addressed Peter Maydell review comments from
> https://www.mail-archive.com/qemu-block@nongnu.org/msg80599.html
> 
> Philippe Mathieu-Daudé (8):
>    hw/sh4: Add missing license
>    hw/sh4: Add missing Kconfig dependency on SH7750 for the R2D board
>    hw/intc: Introduce SH_INTC Kconfig entry
>    hw/char: Introduce SH_SCI Kconfig entry
>    hw/timer: Introduce SH_TIMER Kconfig entry
>    hw/block: Introduce TC58128 eeprom Kconfig entry
>    hw/pci-host: Introduce SH_PCI Kconfig entry
>    hw/sh4: Remove now unused CONFIG_SH4 from Kconfig
> 
>   include/hw/sh4/sh.h           | 31 ++++++++++++++++++++++++++++---
>   hw/block/tc58128.c            | 26 ++++++++++++++++++++++++++
>   hw/{sh4 => pci-host}/sh_pci.c |  0
>   MAINTAINERS                   |  6 ++++++
>   hw/block/Kconfig              |  3 +++
>   hw/block/meson.build          |  2 +-
>   hw/char/Kconfig               |  3 +++
>   hw/char/meson.build           |  2 +-
>   hw/intc/Kconfig               |  3 +++
>   hw/intc/meson.build           |  2 +-
>   hw/pci-host/Kconfig           |  4 ++++
>   hw/pci-host/meson.build       |  1 +
>   hw/sh4/Kconfig                | 12 ++++++------
>   hw/sh4/meson.build            |  1 -
>   hw/timer/Kconfig              |  4 ++++
>   hw/timer/meson.build          |  2 +-
>   16 files changed, 88 insertions(+), 14 deletions(-)
>   rename hw/{sh4 => pci-host}/sh_pci.c (100%)
> 

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo

Re: [PATCH v4 0/8] hw/sh4: Kconfig cleanups

Posted by Richard Henderson 3 years, 2 months ago

On 2/22/21 6:15 AM, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (8):
>   hw/sh4: Add missing license
>   hw/sh4: Add missing Kconfig dependency on SH7750 for the R2D board
>   hw/intc: Introduce SH_INTC Kconfig entry
>   hw/char: Introduce SH_SCI Kconfig entry
>   hw/timer: Introduce SH_TIMER Kconfig entry
>   hw/block: Introduce TC58128 eeprom Kconfig entry
>   hw/pci-host: Introduce SH_PCI Kconfig entry
>   hw/sh4: Remove now unused CONFIG_SH4 from Kconfig

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH v4 0/8] hw/sh4: Kconfig cleanups

Posted by Philippe Mathieu-Daudé 3 years, 2 months ago

On 2/22/21 3:15 PM, Philippe Mathieu-Daudé wrote:

> Philippe Mathieu-Daudé (8):
>   hw/sh4: Add missing license
>   hw/sh4: Add missing Kconfig dependency on SH7750 for the R2D board
>   hw/intc: Introduce SH_INTC Kconfig entry
>   hw/char: Introduce SH_SCI Kconfig entry
>   hw/timer: Introduce SH_TIMER Kconfig entry
>   hw/block: Introduce TC58128 eeprom Kconfig entry
>   hw/pci-host: Introduce SH_PCI Kconfig entry
>   hw/sh4: Remove now unused CONFIG_SH4 from Kconfig
> 
>  include/hw/sh4/sh.h           | 31 ++++++++++++++++++++++++++++---
>  hw/block/tc58128.c            | 26 ++++++++++++++++++++++++++
>  hw/{sh4 => pci-host}/sh_pci.c |  0
>  MAINTAINERS                   |  6 ++++++
>  hw/block/Kconfig              |  3 +++
>  hw/block/meson.build          |  2 +-
>  hw/char/Kconfig               |  3 +++
>  hw/char/meson.build           |  2 +-
>  hw/intc/Kconfig               |  3 +++
>  hw/intc/meson.build           |  2 +-
>  hw/pci-host/Kconfig           |  4 ++++
>  hw/pci-host/meson.build       |  1 +
>  hw/sh4/Kconfig                | 12 ++++++------
>  hw/sh4/meson.build            |  1 -
>  hw/timer/Kconfig              |  4 ++++
>  hw/timer/meson.build          |  2 +-
>  16 files changed, 88 insertions(+), 14 deletions(-)
>  rename hw/{sh4 => pci-host}/sh_pci.c (100%)

As SH4 is not very active, I'm queuing this and will send a pull
request in a few days.