[v2] target/sh4: Pass MMUAccessType to get_physical_address()

[PATCH v2 0/5] target/sh4: Pass MMUAccessType to get_physical_address()

Philippe Mathieu-Daudé posted 5 patches 3 years, 2 months ago

Diff against v1
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210218145111.1591763-1-f4bug@amsat.org

target/sh4/cpu.h    |  11 -----
target/sh4/helper.c | 101 ++++++++++++++++++++++----------------------
2 files changed, 50 insertions(+), 62 deletions(-)

Expand all Fold all

[PATCH v2 0/5] target/sh4: Pass MMUAccessType to get_physical_address()

Posted by Philippe Mathieu-Daudé 3 years, 2 months ago

Taking notes while reviewing commit 671a0a1265a
("use MMUAccessType instead of int in mmu_translate").

Since v1:
- Do not provide unuseful MMU index argument (Richard)

Missing review: patch 3 (Remove unused 'int access_type' argument)

Philippe Mathieu-Daudé (5):
  target/sh4: Fix code style for checkpatch.pl
  target/sh4: Replace magic value by MMUAccessType definitions
  target/sh4: Remove unused 'int access_type' argument
  target/sh4: Let get_physical_address() use MMUAccessType access_type
  target/sh4: Remove unused definitions

 target/sh4/cpu.h    |  11 -----
 target/sh4/helper.c | 101 ++++++++++++++++++++++----------------------
 2 files changed, 50 insertions(+), 62 deletions(-)

-- 
2.26.2

Re: [PATCH v2 0/5] target/sh4: Pass MMUAccessType to get_physical_address()

Posted by Philippe Mathieu-Daudé 3 years, 2 months ago

On 2/18/21 3:51 PM, Philippe Mathieu-Daudé wrote:
> Taking notes while reviewing commit 671a0a1265a
> ("use MMUAccessType instead of int in mmu_translate").

> Philippe Mathieu-Daudé (5):
>   target/sh4: Fix code style for checkpatch.pl
>   target/sh4: Replace magic value by MMUAccessType definitions
>   target/sh4: Remove unused 'int access_type' argument
>   target/sh4: Let get_physical_address() use MMUAccessType access_type
>   target/sh4: Remove unused definitions
> 
>  target/sh4/cpu.h    |  11 -----
>  target/sh4/helper.c | 101 ++++++++++++++++++++++----------------------
>  2 files changed, 50 insertions(+), 62 deletions(-)

As SH4 is not very active, I'm queuing this and will send a pull
request in a few days.