fuzz-test: remove unneccessary debugging flags

[PATCH] fuzz-test: remove unneccessary debugging flags

Posted by Alexander Bulekov 4 years, 9 months ago

These flags cause the output to look strange for 'make check', and
they aren't needed to reproduce bugs, if they reappear.

Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
---
 tests/qtest/fuzz-test.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/qtest/fuzz-test.c b/tests/qtest/fuzz-test.c
index cdb1100a0b..6f161c93be 100644
--- a/tests/qtest/fuzz-test.c
+++ b/tests/qtest/fuzz-test.c
@@ -39,8 +39,7 @@ static void test_lp1878642_pci_bus_get_irq_level_assert(void)
     QTestState *s;
 
     s = qtest_init("-M pc-q35-5.0 "
-                   "-nographic -monitor none -serial none "
-                   "-d guest_errors -trace pci*");
+                   "-nographic -monitor none -serial none");
 
     qtest_outl(s, 0xcf8, 0x8400f841);
     qtest_outl(s, 0xcfc, 0xebed205d);
-- 
2.28.0

Re: [PATCH] fuzz-test: remove unneccessary debugging flags

Posted by Peter Maydell 4 years, 9 months ago

On Tue, 16 Feb 2021 at 18:13, Alexander Bulekov <alxndr@bu.edu> wrote:
>
> These flags cause the output to look strange for 'make check', and
> they aren't needed to reproduce bugs, if they reappear.
>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
>  tests/qtest/fuzz-test.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM

Re: [PATCH] fuzz-test: remove unneccessary debugging flags

Posted by Thomas Huth 4 years, 9 months ago

On 16/02/2021 19.13, Alexander Bulekov wrote:
> These flags cause the output to look strange for 'make check', and
> they aren't needed to reproduce bugs, if they reappear.
> 
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
>   tests/qtest/fuzz-test.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tests/qtest/fuzz-test.c b/tests/qtest/fuzz-test.c
> index cdb1100a0b..6f161c93be 100644
> --- a/tests/qtest/fuzz-test.c
> +++ b/tests/qtest/fuzz-test.c
> @@ -39,8 +39,7 @@ static void test_lp1878642_pci_bus_get_irq_level_assert(void)
>       QTestState *s;
>   
>       s = qtest_init("-M pc-q35-5.0 "
> -                   "-nographic -monitor none -serial none "
> -                   "-d guest_errors -trace pci*");
> +                   "-nographic -monitor none -serial none");
>   
>       qtest_outl(s, 0xcf8, 0x8400f841);
>       qtest_outl(s, 0xcfc, 0xebed205d);
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH] fuzz-test: remove unneccessary debugging flags

Posted by Philippe Mathieu-Daudé 4 years, 9 months ago

On 2/16/21 7:13 PM, Alexander Bulekov wrote:
> These flags cause the output to look strange for 'make check', and
> they aren't needed to reproduce bugs, if they reappear.
> 
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
>  tests/qtest/fuzz-test.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [PATCH] fuzz-test: remove unneccessary debugging flags

Posted by Laurent Vivier 4 years, 8 months ago

Le 16/02/2021 à 19:13, Alexander Bulekov a écrit :
> These flags cause the output to look strange for 'make check', and
> they aren't needed to reproduce bugs, if they reappear.
> 
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
>  tests/qtest/fuzz-test.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tests/qtest/fuzz-test.c b/tests/qtest/fuzz-test.c
> index cdb1100a0b..6f161c93be 100644
> --- a/tests/qtest/fuzz-test.c
> +++ b/tests/qtest/fuzz-test.c
> @@ -39,8 +39,7 @@ static void test_lp1878642_pci_bus_get_irq_level_assert(void)
>      QTestState *s;
>  
>      s = qtest_init("-M pc-q35-5.0 "
> -                   "-nographic -monitor none -serial none "
> -                   "-d guest_errors -trace pci*");
> +                   "-nographic -monitor none -serial none");
>  
>      qtest_outl(s, 0xcf8, 0x8400f841);
>      qtest_outl(s, 0xcfc, 0xebed205d);
> 

Applied to my trivial-patches branch.

Thanks,
Laurent