tests/qemu-iotests: Remove test 259 from the "auto" group

[PATCH] tests/qemu-iotests: Remove test 259 from the "auto" group

Thomas Huth posted 1 patch 4 years, 9 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210215103835.1129145-1-thuth@redhat.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>

tests/qemu-iotests/259 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] tests/qemu-iotests: Remove test 259 from the "auto" group

Posted by Thomas Huth 4 years, 9 months ago

Tests in the "auto" group should support qcow2 so that they can
be run during "make check-block". Test 259 only supports "raw", so
it currently always gets skipped when running "make check-block".
Let's skip this unnecessary step and remove it from the auto group.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qemu-iotests/259 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/259 b/tests/qemu-iotests/259
index 76cde429c4..1b15e8fb48 100755
--- a/tests/qemu-iotests/259
+++ b/tests/qemu-iotests/259
@@ -1,5 +1,5 @@
 #!/usr/bin/env bash
-# group: rw auto quick
+# group: rw quick
 #
 # Test generic image creation fallback (by using NBD)
 #
-- 
2.27.0

Re: [PATCH] tests/qemu-iotests: Remove test 259 from the "auto" group

Posted by Kevin Wolf 4 years, 9 months ago

Am 15.02.2021 um 11:38 hat Thomas Huth geschrieben:
> Tests in the "auto" group should support qcow2 so that they can
> be run during "make check-block". Test 259 only supports "raw", so
> it currently always gets skipped when running "make check-block".
> Let's skip this unnecessary step and remove it from the auto group.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

And it's only nbd, too.

Thanks, applied to the block branch.

Kevin