monitor: Shutdown fixes

[PATCH 0/2] monitor: Shutdown fixes

Posted by Kevin Wolf 4 years, 9 months ago

This fixes the bug(s) that Markus reported here:
https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg07719.html

Kevin Wolf (2):
  monitor: Fix assertion failure on shutdown
  monitor/qmp: Stop processing requests when shutdown is requested

 monitor/monitor.c | 25 +++++++++++++++----------
 monitor/qmp.c     |  5 +++++
 2 files changed, 20 insertions(+), 10 deletions(-)

-- 
2.29.2

Re: [PATCH 0/2] monitor: Shutdown fixes

Posted by Markus Armbruster 4 years, 9 months ago

Kevin Wolf <kwolf@redhat.com> writes:

> This fixes the bug(s) that Markus reported here:
> https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg07719.html

Tested-by: Markus Armbruster <armbru@redhat.com>

Re: [PATCH 0/2] monitor: Shutdown fixes

Posted by Markus Armbruster 4 years, 9 months ago

Kevin Wolf <kwolf@redhat.com> writes:

> This fixes the bug(s) that Markus reported here:
> https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg07719.html

Mostly thanks to the helpful commit messages and code comments:
Reviewed-by: Markus Armbruster <armbru@redhat.com>

Re: [PATCH 0/2] monitor: Shutdown fixes

Posted by Vladimir Sementsov-Ogievskiy 4 years, 4 months ago

12.02.2021 20:20, Kevin Wolf wrote:
> This fixes the bug(s) that Markus reported here:
> https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg07719.html
> 
> Kevin Wolf (2):
>    monitor: Fix assertion failure on shutdown
>    monitor/qmp: Stop processing requests when shutdown is requested
> 
>   monitor/monitor.c | 25 +++++++++++++++----------
>   monitor/qmp.c     |  5 +++++
>   2 files changed, 20 insertions(+), 10 deletions(-)
> 


Hi!

Now we faced this bug after rebasing Virtuozzo qemu package onto qemu-kvm-5.2.0-16.module+el8.4.0+10806+b7d97207.src.rpm

So, I'm backporting these patches.

This probably should go to stable and/or to further Rhel packages.

-- 
Best regards,
Vladimir

Re: [PATCH 0/2] monitor: Shutdown fixes

Posted by Markus Armbruster 4 years, 4 months ago

Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:

> 12.02.2021 20:20, Kevin Wolf wrote:
>> This fixes the bug(s) that Markus reported here:
>> https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg07719.html
>> Kevin Wolf (2):
>>    monitor: Fix assertion failure on shutdown
>>    monitor/qmp: Stop processing requests when shutdown is requested
>>   monitor/monitor.c | 25 +++++++++++++++----------
>>   monitor/qmp.c     |  5 +++++
>>   2 files changed, 20 insertions(+), 10 deletions(-)
>> 
>
>
> Hi!
>
> Now we faced this bug after rebasing Virtuozzo qemu package onto qemu-kvm-5.2.0-16.module+el8.4.0+10806+b7d97207.src.rpm
>
> So, I'm backporting these patches.
>
> This probably should go to stable and/or to further Rhel packages.

Cc'ing qemu-stable, so it gets considered.