hw/arm/virt: Improve CPU help and fix testing under KVM

[PATCH 0/9] hw/arm/virt: Improve CPU help and fix testing under KVM

Posted by Philippe Mathieu-Daudé 3 years, 3 months ago

Yet again bugfixes and cleanup patches noticed while
rebasing my "Support disabling TCG on ARM (part 2)" series.

Sending them independently as they aren't directly dependent
of it so don't have to be delayed by other unanswered questions.

Please review,

Phil.

Philippe Mathieu-Daudé (9):
  tests/qtest/arm-cpu-features: Remove Cortex-A15 check
  tests/qtest: Restrict xlnx-can-test to TCG builds
  tests/qtest/boot-serial-test: Test Virt machine with 'max'
  tests/qtest/cdrom-test: Only allow the Virt machine under KVM
  hw/arm/virt: Improve CPU name in help message
  hw/arm/virt: Display list of valid CPUs for the Virt machine
  hw/arm/virt: Do not include 64-bit CPUs in 32-bit build
  hw/arm/virt: Restrict 32-bit CPUs to TCG
  tests/qtest/arm-cpu-features: Restrict TCG-only tests

 hw/arm/virt.c                  | 20 +++++++++++++++++-
 tests/qtest/arm-cpu-features.c | 37 ++++++++++++++++++++++++++--------
 tests/qtest/boot-serial-test.c |  2 +-
 tests/qtest/cdrom-test.c       |  5 ++++-
 tests/qtest/meson.build        |  2 +-
 5 files changed, 54 insertions(+), 12 deletions(-)

-- 
2.26.2

Re: [PATCH 0/9] hw/arm/virt: Improve CPU help and fix testing under KVM

Posted by Philippe Mathieu-Daudé 3 years, 3 months ago

On 2/5/21 3:43 PM, Philippe Mathieu-Daudé wrote:
> Yet again bugfixes and cleanup patches noticed while
> rebasing my "Support disabling TCG on ARM (part 2)" series.
> 
> Sending them independently as they aren't directly dependent
> of it so don't have to be delayed by other unanswered questions.

Proven wrong 45min later, not trivial and not ready yet =)

> Please review,
> 
> Phil.

Re: [PATCH 0/9] hw/arm/virt: Improve CPU help and fix testing under KVM

Posted by Claudio Fontana 3 years, 2 months ago

On 2/5/21 3:43 PM, Philippe Mathieu-Daudé wrote:
> Yet again bugfixes and cleanup patches noticed while
> rebasing my "Support disabling TCG on ARM (part 2)" series.
> 
> Sending them independently as they aren't directly dependent
> of it so don't have to be delayed by other unanswered questions.
> 
> Please review,
> 
> Phil.
> 
> Philippe Mathieu-Daudé (9):
>   tests/qtest/arm-cpu-features: Remove Cortex-A15 check
>   tests/qtest: Restrict xlnx-can-test to TCG builds
>   tests/qtest/boot-serial-test: Test Virt machine with 'max'
>   tests/qtest/cdrom-test: Only allow the Virt machine under KVM
>   hw/arm/virt: Improve CPU name in help message
>   hw/arm/virt: Display list of valid CPUs for the Virt machine
>   hw/arm/virt: Do not include 64-bit CPUs in 32-bit build
>   hw/arm/virt: Restrict 32-bit CPUs to TCG
>   tests/qtest/arm-cpu-features: Restrict TCG-only tests
> 
>  hw/arm/virt.c                  | 20 +++++++++++++++++-
>  tests/qtest/arm-cpu-features.c | 37 ++++++++++++++++++++++++++--------
>  tests/qtest/boot-serial-test.c |  2 +-
>  tests/qtest/cdrom-test.c       |  5 ++++-
>  tests/qtest/meson.build        |  2 +-
>  5 files changed, 54 insertions(+), 12 deletions(-)
> 

Hi Philippe, Markus,

I encountered an issue where device-introspect-test.c gets me a qemu-system-aarch64 launched as:

./qemu-system-aarch64 -qtest ... -display none -nodefaults -machine none -accel qtest

and results in an attempt to create a device "ast2400-a1",
which tries to create a arm926-arm-cpu, which fails because it is a "TCG" cpu, that is not built in my kvm-only build.

Any ideas why this happens?

Thanks,

Claudio