[v2] exec/cpu-defs: Remove TCG backends dependency

[PATCH v2] exec/cpu-defs: Remove TCG backends dependency

Philippe Mathieu-Daudé posted 1 patch 3 years, 3 months ago

Diff against v1
Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210204191423.1754158-1-f4bug@amsat.org

include/exec/cpu-defs.h | 3 ---
1 file changed, 3 deletions(-)

Expand all Fold all

[PATCH v2] exec/cpu-defs: Remove TCG backends dependency

Posted by Philippe Mathieu-Daudé 3 years, 3 months ago

"exec/cpu-defs.h" contains generic CPU definitions for the
TCG frontends (mostly related to TLB). TCG backends definitions
aren't relevant here.

See tcg/README description:

  4) Backend

  tcg-target.h contains the target specific definitions. tcg-target.c.inc
  contains the target specific code; it is #included by tcg/tcg.c, rather
  than being a standalone C file.

So far only "tcg/tcg.h" requires these headers.

Remove the "target-tcg.h" header dependency on TCG frontends, so we
don't have to rebuild all frontends when hacking a single backend.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
v2: Reword description (bonzini)
---
 include/exec/cpu-defs.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h
index d1f5e3fc3d8..ba3cd32a1ec 100644
--- a/include/exec/cpu-defs.h
+++ b/include/exec/cpu-defs.h
@@ -25,9 +25,6 @@
 
 #include "qemu/host-utils.h"
 #include "qemu/thread.h"
-#ifdef CONFIG_TCG
-#include "tcg-target.h"
-#endif
 #ifndef CONFIG_USER_ONLY
 #include "exec/hwaddr.h"
 #endif
-- 
2.26.2

Re: [PATCH v2] exec/cpu-defs: Remove TCG backends dependency

Posted by Richard Henderson 3 years, 3 months ago

On 2/4/21 9:14 AM, Philippe Mathieu-Daudé wrote:
> "exec/cpu-defs.h" contains generic CPU definitions for the
> TCG frontends (mostly related to TLB). TCG backends definitions
> aren't relevant here.
> 
> See tcg/README description:
> 
>   4) Backend
> 
>   tcg-target.h contains the target specific definitions. tcg-target.c.inc
>   contains the target specific code; it is #included by tcg/tcg.c, rather
>   than being a standalone C file.
> 
> So far only "tcg/tcg.h" requires these headers.
> 
> Remove the "target-tcg.h" header dependency on TCG frontends, so we
> don't have to rebuild all frontends when hacking a single backend.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> v2: Reword description (bonzini)
> ---
>  include/exec/cpu-defs.h | 3 ---
>  1 file changed, 3 deletions(-)

Queued, thanks.


r~