[v1] Acceptance Test: introduce base class for Linux based tests

[PATCH 12/22] Acceptance tests: clarify ssh connection failure reason

Posted by Cleber Rosa 5 years ago

If the connection to the ssh server fails, it may indeed be a "sshd"
issue, but it may also not be that.  Let's state what we know: the
establishment of the connection from the client side was not possible.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 tests/acceptance/linux_ssh_mips_malta.py | 2 +-
 tests/acceptance/virtiofs_submounts.py   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/acceptance/linux_ssh_mips_malta.py b/tests/acceptance/linux_ssh_mips_malta.py
index ab6cb94aef..1742235758 100644
--- a/tests/acceptance/linux_ssh_mips_malta.py
+++ b/tests/acceptance/linux_ssh_mips_malta.py
@@ -89,7 +89,7 @@ class LinuxSSH(Test):
             except:
                 time.sleep(4)
                 pass
-        self.fail("sshd timeout")
+        self.fail("ssh connection timeout")
 
     def ssh_disconnect_vm(self):
         self.ssh_session.quit()
diff --git a/tests/acceptance/virtiofs_submounts.py b/tests/acceptance/virtiofs_submounts.py
index bf99164fcb..c998b297ee 100644
--- a/tests/acceptance/virtiofs_submounts.py
+++ b/tests/acceptance/virtiofs_submounts.py
@@ -94,7 +94,7 @@ class VirtiofsSubmountsTest(BootLinux):
             except:
                 time.sleep(4)
                 pass
-        self.fail('sshd timeout')
+        self.fail('ssh connection timeout')
 
     def ssh_command(self, command):
         self.ssh_logger.info(command)
-- 
2.25.4

Re: [PATCH 12/22] Acceptance tests: clarify ssh connection failure reason

Posted by Philippe Mathieu-Daudé 5 years ago

On 2/3/21 6:23 PM, Cleber Rosa wrote:
> If the connection to the ssh server fails, it may indeed be a "sshd"
> issue, but it may also not be that.  Let's state what we know: the
> establishment of the connection from the client side was not possible.
> 
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  tests/acceptance/linux_ssh_mips_malta.py | 2 +-
>  tests/acceptance/virtiofs_submounts.py   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>