[PATCH v2 0/4] migration: Fixes and cleanups aroung migrate-set-parameters

Markus Armbruster posted 4 patches 3 years, 2 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210202141734.2488076-1-armbru@redhat.com
Maintainers: Eric Blake <eblake@redhat.com>, Juan Quintela <quintela@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>
qapi/migration.json    | 32 ++++++++++++++++----------------
migration/migration.h  |  2 +-
migration/page_cache.h |  2 +-
migration/ram.h        |  2 +-
migration/migration.c  | 27 +++++++++++++--------------
migration/page_cache.c |  8 +++-----
migration/ram.c        |  2 +-
monitor/hmp-cmds.c     | 24 ++++++++++++------------
8 files changed, 48 insertions(+), 51 deletions(-)
[PATCH v2 0/4] migration: Fixes and cleanups aroung migrate-set-parameters
Posted by Markus Armbruster 3 years, 2 months ago
v2:
* Rebased
* PATCH 1 dropped.  Fixes a crash bug.  Daniel asked me to modify the
  fix.  Unfortunately, I don't understand this anymore, and don't have
  the time & energy to start over.
* PATCH 4 dropped.  Plugs a hole in input validation.  David pointed
  asked me to additionally fix an error message, but I don't quite
  understand what he wants.

We can discuss what to do about the dropped patches, but I don't want
to hold the remainder of the series any longer just for that.

Markus Armbruster (4):
  migration: Fix migrate-set-parameters argument validation
  migration: Clean up signed vs. unsigned XBZRLE cache-size
  migration: Fix cache_init()'s "Failed to allocate" error messages
  migration: Fix a few absurdly defective error messages

 qapi/migration.json    | 32 ++++++++++++++++----------------
 migration/migration.h  |  2 +-
 migration/page_cache.h |  2 +-
 migration/ram.h        |  2 +-
 migration/migration.c  | 27 +++++++++++++--------------
 migration/page_cache.c |  8 +++-----
 migration/ram.c        |  2 +-
 monitor/hmp-cmds.c     | 24 ++++++++++++------------
 8 files changed, 48 insertions(+), 51 deletions(-)

-- 
2.26.2


Re: [PATCH v2 0/4] migration: Fixes and cleanups aroung migrate-set-parameters
Posted by Dr. David Alan Gilbert 3 years, 2 months ago
* Markus Armbruster (armbru@redhat.com) wrote:
> v2:
> * Rebased
> * PATCH 1 dropped.  Fixes a crash bug.  Daniel asked me to modify the
>   fix.  Unfortunately, I don't understand this anymore, and don't have
>   the time & energy to start over.
> * PATCH 4 dropped.  Plugs a hole in input validation.  David pointed
>   asked me to additionally fix an error message, but I don't quite
>   understand what he wants.
> 
> We can discuss what to do about the dropped patches, but I don't want
> to hold the remainder of the series any longer just for that.

Queued (with double . removed)

> 
> Markus Armbruster (4):
>   migration: Fix migrate-set-parameters argument validation
>   migration: Clean up signed vs. unsigned XBZRLE cache-size
>   migration: Fix cache_init()'s "Failed to allocate" error messages
>   migration: Fix a few absurdly defective error messages
> 
>  qapi/migration.json    | 32 ++++++++++++++++----------------
>  migration/migration.h  |  2 +-
>  migration/page_cache.h |  2 +-
>  migration/ram.h        |  2 +-
>  migration/migration.c  | 27 +++++++++++++--------------
>  migration/page_cache.c |  8 +++-----
>  migration/ram.c        |  2 +-
>  monitor/hmp-cmds.c     | 24 ++++++++++++------------
>  8 files changed, 48 insertions(+), 51 deletions(-)
> 
> -- 
> 2.26.2
> 
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK