virtiofsd: Add restart_syscall to the seccomp whitelist

[PATCH] virtiofsd: Add restart_syscall to the seccomp whitelist

Posted by Greg Kurz 3 years, 2 months ago

This is how linux restarts some system calls after SIGSTOP/SIGCONT.
This is needed to avoid virtiofsd termination when resuming execution
under GDB for example.

Signed-off-by: Greg Kurz <groug@kaod.org>
---

This has passed Travis and gitlab CI without errors.

 tools/virtiofsd/passthrough_seccomp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/virtiofsd/passthrough_seccomp.c b/tools/virtiofsd/passthrough_seccomp.c
index a60d7da4b4e2..da03e97d35e4 100644
--- a/tools/virtiofsd/passthrough_seccomp.c
+++ b/tools/virtiofsd/passthrough_seccomp.c
@@ -88,6 +88,7 @@ static const int syscall_whitelist[] = {
     SCMP_SYS(renameat),
     SCMP_SYS(renameat2),
     SCMP_SYS(removexattr),
+    SCMP_SYS(restart_syscall),
     SCMP_SYS(rt_sigaction),
     SCMP_SYS(rt_sigprocmask),
     SCMP_SYS(rt_sigreturn),
-- 
2.26.2

Re: [PATCH] virtiofsd: Add restart_syscall to the seccomp whitelist

Posted by Dr. David Alan Gilbert 3 years, 2 months ago

* Greg Kurz (groug@kaod.org) wrote:
> This is how linux restarts some system calls after SIGSTOP/SIGCONT.
> This is needed to avoid virtiofsd termination when resuming execution
> under GDB for example.

Ah!


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> 
> This has passed Travis and gitlab CI without errors.
> 
>  tools/virtiofsd/passthrough_seccomp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/virtiofsd/passthrough_seccomp.c b/tools/virtiofsd/passthrough_seccomp.c
> index a60d7da4b4e2..da03e97d35e4 100644
> --- a/tools/virtiofsd/passthrough_seccomp.c
> +++ b/tools/virtiofsd/passthrough_seccomp.c
> @@ -88,6 +88,7 @@ static const int syscall_whitelist[] = {
>      SCMP_SYS(renameat),
>      SCMP_SYS(renameat2),
>      SCMP_SYS(removexattr),
> +    SCMP_SYS(restart_syscall),
>      SCMP_SYS(rt_sigaction),
>      SCMP_SYS(rt_sigprocmask),
>      SCMP_SYS(rt_sigreturn),
> -- 
> 2.26.2
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

Re: [PATCH] virtiofsd: Add restart_syscall to the seccomp whitelist

Posted by Stefan Hajnoczi 3 years, 2 months ago

On Mon, Feb 01, 2021 at 08:33:05PM +0100, Greg Kurz wrote:
> This is how linux restarts some system calls after SIGSTOP/SIGCONT.
> This is needed to avoid virtiofsd termination when resuming execution
> under GDB for example.
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> 
> This has passed Travis and gitlab CI without errors.
> 
>  tools/virtiofsd/passthrough_seccomp.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>