Maximize QMP availability for OOB commands

[PATCH 0/3] Maximize QMP availability for OOB commands

Posted by Markus Armbruster 3 years, 2 months ago

While bisecting a crash bug, I noticed OOB commands can get delayed
unduly when a full request queue becomes non-full.  Improve that.

Related:

* [PATCH] docs/interop/qmp-spec: Document the request queue limit
  Message-Id: <20210127144734.2367693-1-armbru@redhat.com>
  https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg06931.html

* Crash bug report (regression):
  Message-ID: <87bld7ucor.fsf@dusky.pond.sub.org>
  https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg07719.html


Markus Armbruster (3):
  qmp: Fix up comments after commit 9ce44e2ce2
  qmp: Add more tracepoints
  qmp: Resume OOB-enabled monitor before processing the request

 monitor/qmp.c        | 44 ++++++++++++++++++++++++++++++++++++--------
 monitor/trace-events |  4 ++++
 2 files changed, 40 insertions(+), 8 deletions(-)

-- 
2.26.2

Re: [PATCH 0/3] Maximize QMP availability for OOB commands

Posted by no-reply@patchew.org 3 years, 2 months ago

Patchew URL: https://patchew.org/QEMU/20210201161504.1976989-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210201161504.1976989-1-armbru@redhat.com
Subject: [PATCH 0/3] Maximize QMP availability for OOB commands

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210201161024.127921-1-kwolf@redhat.com -> patchew/20210201161024.127921-1-kwolf@redhat.com
 * [new tag]         patchew/20210201161504.1976989-1-armbru@redhat.com -> patchew/20210201161504.1976989-1-armbru@redhat.com
Switched to a new branch 'test'
fadfb04 qmp: Resume OOB-enabled monitor before processing the request
1ad8f04 qmp: Add more tracepoints
ee6df8f qmp: Fix up comments after commit 9ce44e2ce2

=== OUTPUT BEGIN ===
1/3 Checking commit ee6df8f36aee (qmp: Fix up comments after commit 9ce44e2ce2)
2/3 Checking commit 1ad8f04f15fe (qmp: Add more tracepoints)
3/3 Checking commit fadfb0405308 (qmp: Resume OOB-enabled monitor before processing the request)
ERROR: trailing whitespace
#61: FILE: monitor/qmp.c:289:
+         *    Resume only after we're done processing the request, $

total: 1 errors, 0 warnings, 55 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210201161504.1976989-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com