[PULL 00/36] Misc patches (buildsys, i386, fuzzing) for 2021-01-29

Paolo Bonzini posted 36 patches 3 years, 3 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210129111814.566629-1-pbonzini@redhat.com
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Cameron Esfahani <dirty@apple.com>, Stefan Hajnoczi <stefanha@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Igor Mammedov <imammedo@redhat.com>, Alexander Bulekov <alxndr@bu.edu>, Laurent Vivier <lvivier@redhat.com>, Fam Zheng <fam@euphon.net>, Bandan Das <bsd@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Roman Bolshakov <r.bolshakov@yadro.com>, Thomas Huth <thuth@redhat.com>
There is a newer version of this series
.gitmodules                              |   4 +-
MAINTAINERS                              |   1 +
accel/kvm/kvm-all.c                      |  21 ++-
backends/hostmem.c                       |  10 ++
configure                                |   9 +-
docs/devel/build-system.rst              |   2 +-
docs/devel/fuzzing.rst                   |  35 +++-
docs/meson.build                         |   6 +-
hw/scsi/virtio-scsi-dataplane.c          |   8 +-
include/exec/memory.h                    |   8 +-
include/exec/memory_ldst_cached.h.inc    |   6 +-
include/qemu/event_notifier.h            |   1 +
memory_ldst.c.inc                        |   8 +-
meson.build                              | 277 ++++++++++++++-----------------
meson_options.txt                        |   2 +-
pc-bios/meson.build                      |   1 +
qapi/meson.build                         |  34 ++--
qemu-options.hx                          |  26 ++-
scripts/oss-fuzz/minimize_qtest_trace.py |   2 +-
slirp                                    |   2 +-
softmmu/memory.c                         |   5 +-
softmmu/physmem.c                        |   4 +-
stubs/meson.build                        |   2 +
stubs/qdev.c                             |  23 +++
target/i386/cpu.c                        |  15 +-
target/i386/cpu.h                        |  29 ++--
target/i386/helper.c                     |   3 +
target/i386/hvf/hvf.c                    |   4 +
target/i386/machine.c                    |  24 ++-
target/i386/tcg/excp_helper.c            |  32 ++--
target/i386/tcg/misc_helper.c            |  14 ++
target/i386/tcg/translate.c              |   2 +-
tests/meson.build                        |  11 +-
tests/qtest/fuzz/fuzz.c                  |  11 +-
tests/qtest/fuzz/generic_fuzz.c          |  19 ++-
tests/qtest/fuzz/generic_fuzz_configs.h  |  41 ++++-
util/event_notifier-posix.c              |  16 ++
37 files changed, 468 insertions(+), 250 deletions(-)
create mode 100644 stubs/qdev.c
[PULL 00/36] Misc patches (buildsys, i386, fuzzing) for 2021-01-29
Posted by Paolo Bonzini 3 years, 3 months ago
The following changes since commit 0bcd12fb1513bad44f05f2d3a8eef2a99b3077b6:

  Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2021-01-28 12:30:30 +0000)

are available in the Git repository at:

  https://gitlab.com/bonzini/qemu.git tags/for-upstream

for you to fetch changes up to 6c52f4644c9c8a18b8495e169e539632a897f135:

  accel/kvm/kvm-all: Fix wrong return code handling in dirty log code (2021-01-29 10:38:38 +0100)

----------------------------------------------------------------
* Fuzzing improvements (Qiuhao, Alexander)
* i386: Fix BMI decoding for instructions with the 0x66 prefix (David)
* slirp update (Marc-André)
* initial attempt at fixing event_notifier emulation (Maxim)
* i386: PKS emulation, fix for "qemu-system-i386 -cpu host" (myself)
* meson: RBD test fixes (myself)
* meson: TCI warnings (Philippe)
* Leaner build for --disable-guest-agent, --disable-system and
  --disable-tools (Philippe, Stefan)
* --enable-tcg-interpreter fix (Richard)
* i386: SVM feature bits (Wei)
* HVF bugfix (Alex)
* KVM bugfix (Thomas)

----------------------------------------------------------------
Alexander Bulekov (7):
      fuzz: ignore address_space_map is_write flag
      fuzz: refine the ide/ahci fuzzer configs
      docs/fuzz: fix pre-meson path
      fuzz: log the arguments used to initialize QEMU
      fuzz: enable dynamic args for generic-fuzz configs
      docs/fuzz: add some information about OSS-Fuzz
      fuzz: add virtio-9p configurations for fuzzing

Alexander Graf (1):
      hvf: Fetch cr4 before evaluating CPUID(1)

David Greenaway (1):
      target/i386: Fix decoding of certain BMI instructions

Igor Mammedov (1):
      machine: add missing doc for memory-backend option

Marc-André Lureau (2):
      slirp: update to git master
      build-sys: make libslirp a meson subproject

Maxim Levitsky (2):
      virtio-scsi: don't uninitialize queues that we didn't initialize
      event_notifier: handle initialization failure better

Paolo Bonzini (4):
      target/i386: do not set LM for 32-bit emulation "-cpu host/max"
      meson: accept either shared or static libraries if --disable-static
      meson: honor --enable-rbd if cc.links test fails
      target/i86: implement PKS

Philippe Mathieu-Daudé (13):
      configure: Improve TCI feature description
      meson: Explicit TCG backend used
      meson: Warn when TCI is selected but TCG backend is available
      tests/meson: Only build softfloat objects if TCG is selected
      pc-bios/meson: Only install EDK2 blob firmwares with system emulation
      meson: Restrict block subsystem processing
      meson: Merge trace_events_subdirs array
      meson: Restrict some trace event directories to user/system emulation
      meson: Restrict emulation code
      qapi/meson: Restrict qdev code to system-mode emulation
      qapi/meson: Remove QMP from user-mode emulation
      qapi/meson: Restrict system-mode specific modules
      qapi/meson: Restrict UI module to system emulation and tools

Qiuhao Li (1):
      fuzz: fix wrong index in clear_bits

Richard Henderson (1):
      configure: Fix --enable-tcg-interpreter

Stefan Reiter (1):
      docs: don't install corresponding man page if guest agent is disabled

Thomas Huth (1):
      accel/kvm/kvm-all: Fix wrong return code handling in dirty log code

Wei Huang (1):
      x86/cpu: Populate SVM CPUID feature bits

 .gitmodules                              |   4 +-
 MAINTAINERS                              |   1 +
 accel/kvm/kvm-all.c                      |  21 ++-
 backends/hostmem.c                       |  10 ++
 configure                                |   9 +-
 docs/devel/build-system.rst              |   2 +-
 docs/devel/fuzzing.rst                   |  35 +++-
 docs/meson.build                         |   6 +-
 hw/scsi/virtio-scsi-dataplane.c          |   8 +-
 include/exec/memory.h                    |   8 +-
 include/exec/memory_ldst_cached.h.inc    |   6 +-
 include/qemu/event_notifier.h            |   1 +
 memory_ldst.c.inc                        |   8 +-
 meson.build                              | 277 ++++++++++++++-----------------
 meson_options.txt                        |   2 +-
 pc-bios/meson.build                      |   1 +
 qapi/meson.build                         |  34 ++--
 qemu-options.hx                          |  26 ++-
 scripts/oss-fuzz/minimize_qtest_trace.py |   2 +-
 slirp                                    |   2 +-
 softmmu/memory.c                         |   5 +-
 softmmu/physmem.c                        |   4 +-
 stubs/meson.build                        |   2 +
 stubs/qdev.c                             |  23 +++
 target/i386/cpu.c                        |  15 +-
 target/i386/cpu.h                        |  29 ++--
 target/i386/helper.c                     |   3 +
 target/i386/hvf/hvf.c                    |   4 +
 target/i386/machine.c                    |  24 ++-
 target/i386/tcg/excp_helper.c            |  32 ++--
 target/i386/tcg/misc_helper.c            |  14 ++
 target/i386/tcg/translate.c              |   2 +-
 tests/meson.build                        |  11 +-
 tests/qtest/fuzz/fuzz.c                  |  11 +-
 tests/qtest/fuzz/generic_fuzz.c          |  19 ++-
 tests/qtest/fuzz/generic_fuzz_configs.h  |  41 ++++-
 util/event_notifier-posix.c              |  16 ++
 37 files changed, 468 insertions(+), 250 deletions(-)
 create mode 100644 stubs/qdev.c
-- 
2.29.2


Re: [PULL 00/36] Misc patches (buildsys, i386, fuzzing) for 2021-01-29
Posted by Peter Maydell 3 years, 3 months ago
On Fri, 29 Jan 2021 at 11:33, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> The following changes since commit 0bcd12fb1513bad44f05f2d3a8eef2a99b3077b6:
>
>   Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2021-01-28 12:30:30 +0000)
>
> are available in the Git repository at:
>
>   https://gitlab.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 6c52f4644c9c8a18b8495e169e539632a897f135:
>
>   accel/kvm/kvm-all: Fix wrong return code handling in dirty log code (2021-01-29 10:38:38 +0100)
>
> ----------------------------------------------------------------

Fails to build, OSX:

../../subprojects/libslirp/src/slirp.c:131:17: error: unused variable
'old_stat' [-Werror,-Wunused-variable]
    struct stat old_stat;
                ^
../../subprojects/libslirp/src/slirp.c:143:10: error: unused variable
'buff' [-Werror,-Wunused-variable]
    char buff[512];
         ^

thanks
-- PMM

Re: [PULL 00/36] Misc patches (buildsys, i386, fuzzing) for 2021-01-29
Posted by Paolo Bonzini 3 years, 3 months ago
On 29/01/21 20:49, Peter Maydell wrote:
> On Fri, 29 Jan 2021 at 11:33, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> The following changes since commit 0bcd12fb1513bad44f05f2d3a8eef2a99b3077b6:
>>
>>    Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2021-01-28 12:30:30 +0000)
>>
>> are available in the Git repository at:
>>
>>    https://gitlab.com/bonzini/qemu.git tags/for-upstream
>>
>> for you to fetch changes up to 6c52f4644c9c8a18b8495e169e539632a897f135:
>>
>>    accel/kvm/kvm-all: Fix wrong return code handling in dirty log code (2021-01-29 10:38:38 +0100)
>>
>> ----------------------------------------------------------------
> 
> Fails to build, OSX:
> 
> ../../subprojects/libslirp/src/slirp.c:131:17: error: unused variable
> 'old_stat' [-Werror,-Wunused-variable]
>      struct stat old_stat;
>                  ^
> ../../subprojects/libslirp/src/slirp.c:143:10: error: unused variable
> 'buff' [-Werror,-Wunused-variable]
>      char buff[512];
>           ^

Hmm this is the same slirp failure that in theory should have been fixed 
by Marc-André.  I'll check again on Monday.

Paolo


Re: [PULL 00/36] Misc patches (buildsys, i386, fuzzing) for 2021-01-29
Posted by Marc-André Lureau 3 years, 3 months ago
Hi

On Fri, Jan 29, 2021 at 11:56 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 29/01/21 20:49, Peter Maydell wrote:
> > On Fri, 29 Jan 2021 at 11:33, Paolo Bonzini <pbonzini@redhat.com> wrote:
> >>
> >> The following changes since commit 0bcd12fb1513bad44f05f2d3a8eef2a99b3077b6:
> >>
> >>    Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2021-01-28 12:30:30 +0000)
> >>
> >> are available in the Git repository at:
> >>
> >>    https://gitlab.com/bonzini/qemu.git tags/for-upstream
> >>
> >> for you to fetch changes up to 6c52f4644c9c8a18b8495e169e539632a897f135:
> >>
> >>    accel/kvm/kvm-all: Fix wrong return code handling in dirty log code (2021-01-29 10:38:38 +0100)
> >>
> >> ----------------------------------------------------------------
> >
> > Fails to build, OSX:
> >
> > ../../subprojects/libslirp/src/slirp.c:131:17: error: unused variable
> > 'old_stat' [-Werror,-Wunused-variable]
> >      struct stat old_stat;
> >                  ^
> > ../../subprojects/libslirp/src/slirp.c:143:10: error: unused variable
> > 'buff' [-Werror,-Wunused-variable]
> >      char buff[512];
> >           ^
>
> Hmm this is the same slirp failure that in theory should have been fixed
> by Marc-André.  I'll check again on Monday.
>
>

That's weird, https://patchew.org/QEMU/20210129111814.566629-1-pbonzini@redhat.com/20210129111814.566629-24-pbonzini@redhat.com/

-Subproject commit 8f43a99191afb47ca3f3c6972f6306209f367ece
+Subproject commit 5dce846e3ee82d93462bc637bb0db2fd49f0fc5a

I can't really explain why the submodule wasn't updated to include the fix.

Peter, did this fail on various CI builds or during a manual build?


-- 
Marc-André Lureau

Re: [PULL 00/36] Misc patches (buildsys, i386, fuzzing) for 2021-01-29
Posted by Peter Maydell 3 years, 3 months ago
On Sat, 30 Jan 2021 at 10:11, Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
> That's weird, https://patchew.org/QEMU/20210129111814.566629-1-pbonzini@redhat.com/20210129111814.566629-24-pbonzini@redhat.com/
>
> -Subproject commit 8f43a99191afb47ca3f3c6972f6306209f367ece
> +Subproject commit 5dce846e3ee82d93462bc637bb0db2fd49f0fc5a
>
> I can't really explain why the submodule wasn't updated to include the fix.
>
> Peter, did this fail on various CI builds or during a manual build?

It failed on my usual pre-merge build (which is just make/make check).

thanks
-- PMM