[PATCH v5 0/5] hw/block/nvme: add simple copy command

Klaus Jensen posted 5 patches 3 years, 3 months ago
Failed in applying to current master (apply log)
hw/block/nvme-ns.h    |   4 +
hw/block/nvme.h       |   1 +
include/block/nvme.h  |  45 +++-
hw/block/nvme-ns.c    |   8 +
hw/block/nvme.c       | 494 +++++++++++++++++++++++++++++++-----------
hw/block/trace-events |   7 +
6 files changed, 431 insertions(+), 128 deletions(-)
[PATCH v5 0/5] hw/block/nvme: add simple copy command
Posted by Klaus Jensen 3 years, 3 months ago
From: Klaus Jensen <k.jensen@samsung.com>

Add support for TP 4065 ("Simple Copy Command").

Changes for v5

  * rebased on nvme-next (support for zoned namespaces)

Changes for v4

  * merge for-loops (Keith)

Changes for v3

  * rebased on nvme-next
  * changed the default msrc value to a more reasonable 127 from 255 to
    better align with the default mcl value of 128.

Changes for v2

  * prefer style that aligns with existing NvmeIdCtrl field enums
    (Minwoo)
  * swapped elbat/elbatm fields in copy source range. I've kept the R-b
    and A-b from Minwoo and Stefan since this is a non-functional change
    (the device does not use these fields at all).

Klaus Jensen (5):
  hw/block/nvme: remove unused parameter in check zone write
  hw/block/nvme: refactor zone resource management
  hw/block/nvme: pull write pointer advancement to separate function
  nvme: updated shared header for copy command
  hw/block/nvme: add simple copy command

 hw/block/nvme-ns.h    |   4 +
 hw/block/nvme.h       |   1 +
 include/block/nvme.h  |  45 +++-
 hw/block/nvme-ns.c    |   8 +
 hw/block/nvme.c       | 494 +++++++++++++++++++++++++++++++-----------
 hw/block/trace-events |   7 +
 6 files changed, 431 insertions(+), 128 deletions(-)

-- 
2.30.0


Re: [PATCH v5 0/5] hw/block/nvme: add simple copy command
Posted by Keith Busch 3 years, 2 months ago
Just had the one comment on patch 4, which is really no big deal. I need
to integrate tooling and/or kernel support in order to properly test
this, but just from code inspection, I think it's good.

Reviewed-by: Keith Busch <kbusch@kernel.org>

Re: [PATCH v5 0/5] hw/block/nvme: add simple copy command
Posted by Klaus Jensen 3 years, 2 months ago
On Feb  3 09:27, Keith Busch wrote:
> Just had the one comment on patch 4, which is really no big deal. I need
> to integrate tooling and/or kernel support in order to properly test
> this, but just from code inspection, I think it's good.
> 
> Reviewed-by: Keith Busch <kbusch@kernel.org>
> 

Thanks Keith!

Actually, nvme-cli already has support ;)

  # nvme copy /dev/nvme0n2 --sdlba=0x2000 --slbs=0x0,0x1000 --blocks=0,1