tests/tcg: Replace /bin/true by true (required on macOS)

[PATCH] tests/tcg: Replace /bin/true by true (required on macOS)

Stefan Weil posted 1 patch 3 years, 3 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210128135627.2067003-1-sw@weilnetz.de

Maintainers: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, "Alex Bennée" <alex.bennee@linaro.org>

tests/tcg/Makefile.qemu | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH] tests/tcg: Replace /bin/true by true (required on macOS)

Posted by Stefan Weil 3 years, 3 months ago

/bin/true is missing on macOS, but simply "true" is available as a shell builtin.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---

A similar change might be needed for tests/qemu-iotests.

Regards,
Stefan

 tests/tcg/Makefile.qemu | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/tcg/Makefile.qemu b/tests/tcg/Makefile.qemu
index c096c611a2..a56564660c 100644
--- a/tests/tcg/Makefile.qemu
+++ b/tests/tcg/Makefile.qemu
@@ -90,11 +90,11 @@ run-guest-tests: guest-tests
 
 else
 guest-tests:
-	$(call quiet-command, /bin/true, "BUILD", \
+	$(call quiet-command, true, "BUILD", \
 		"$(TARGET) guest-tests SKIPPED")
 
 run-guest-tests:
-	$(call quiet-command, /bin/true, "RUN", \
+	$(call quiet-command, true, "RUN", \
 		"tests for $(TARGET) SKIPPED")
 endif
 
-- 
2.24.3 (Apple Git-128)

Re: [PATCH] tests/tcg: Replace /bin/true by true (required on macOS)

Posted by Philippe Mathieu-Daudé 3 years, 3 months ago

On 1/28/21 2:56 PM, Stefan Weil wrote:
> /bin/true is missing on macOS, but simply "true" is available as a shell builtin.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> 
> A similar change might be needed for tests/qemu-iotests.
> 
> Regards,
> Stefan
> 
>  tests/tcg/Makefile.qemu | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Re: [PATCH] tests/tcg: Replace /bin/true by true (required on macOS)

Posted by Alex Bennée 3 years, 3 months ago

Stefan Weil <sw@weilnetz.de> writes:

> /bin/true is missing on macOS, but simply "true" is available as a shell builtin.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Queued to testing/next, thanks.

-- 
Alex Bennée

Re: [PATCH] tests/tcg: Replace /bin/true by true (required on macOS)

Posted by Peter Maydell 3 years, 3 months ago

On Thu, 28 Jan 2021 at 13:59, Stefan Weil <sw@weilnetz.de> wrote:
>
> /bin/true is missing on macOS, but simply "true" is available as a shell builtin.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

It's also in /usr/bin/true if you happen to need a real
executable rather than a builtin. Either way we shouldn't
be hardcoding the path here.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM