[PATCH] tests/acceptance: Increase the timeout in the replay tests

Thomas Huth posted 1 patch 3 years, 3 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210127065222.48650-1-thuth@redhat.com
Maintainers: Wainer dos Santos Moschetta <wainersm@redhat.com>, Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, Cleber Rosa <crosa@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
tests/acceptance/replay_kernel.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] tests/acceptance: Increase the timeout in the replay tests
Posted by Thomas Huth 3 years, 3 months ago
Our gitlab-CI just showed a failed test_ppc_mac99 since it was apparently
killed some few seconds before the test finished. Allow it some more
time to complete.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 Seen in this test log:
 https://gitlab.com/qemu-project/qemu/-/jobs/987148065/artifacts/file/build/tests/results/latest/test-results/26-tests_acceptance_replay_kernel.py_ReplayKernelNormal.test_ppc_mac99/debug.log

 tests/acceptance/replay_kernel.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/acceptance/replay_kernel.py b/tests/acceptance/replay_kernel.py
index 772633b01d..c1cb862468 100644
--- a/tests/acceptance/replay_kernel.py
+++ b/tests/acceptance/replay_kernel.py
@@ -31,7 +31,7 @@ class ReplayKernelBase(LinuxKernelTest):
     terminates.
     """
 
-    timeout = 90
+    timeout = 120
     KERNEL_COMMON_COMMAND_LINE = 'printk.time=1 panic=-1 '
 
     def run_vm(self, kernel_path, kernel_command_line, console_pattern,
-- 
2.27.0


Re: [PATCH] tests/acceptance: Increase the timeout in the replay tests
Posted by Philippe Mathieu-Daudé 3 years, 2 months ago
On 1/27/21 7:52 AM, Thomas Huth wrote:
> Our gitlab-CI just showed a failed test_ppc_mac99 since it was apparently
> killed some few seconds before the test finished. Allow it some more
> time to complete.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  Seen in this test log:
>  https://gitlab.com/qemu-project/qemu/-/jobs/987148065/artifacts/file/build/tests/results/latest/test-results/26-tests_acceptance_replay_kernel.py_ReplayKernelNormal.test_ppc_mac99/debug.log
> 
>  tests/acceptance/replay_kernel.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Hopefully this buy us time. Applied to my acceptance-testing tree.


Re: [PATCH] tests/acceptance: Increase the timeout in the replay tests
Posted by Wainer dos Santos Moschetta 3 years, 3 months ago
On 1/27/21 3:52 AM, Thomas Huth wrote:
> Our gitlab-CI just showed a failed test_ppc_mac99 since it was apparently
> killed some few seconds before the test finished. Allow it some more
> time to complete.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   Seen in this test log:
>   https://gitlab.com/qemu-project/qemu/-/jobs/987148065/artifacts/file/build/tests/results/latest/test-results/26-tests_acceptance_replay_kernel.py_ReplayKernelNormal.test_ppc_mac99/debug.log
>
>   tests/acceptance/replay_kernel.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>


>
> diff --git a/tests/acceptance/replay_kernel.py b/tests/acceptance/replay_kernel.py
> index 772633b01d..c1cb862468 100644
> --- a/tests/acceptance/replay_kernel.py
> +++ b/tests/acceptance/replay_kernel.py
> @@ -31,7 +31,7 @@ class ReplayKernelBase(LinuxKernelTest):
>       terminates.
>       """
>   
> -    timeout = 90
> +    timeout = 120
>       KERNEL_COMMON_COMMAND_LINE = 'printk.time=1 panic=-1 '
>   
>       def run_vm(self, kernel_path, kernel_command_line, console_pattern,


Re: [PATCH] tests/acceptance: Increase the timeout in the replay tests
Posted by Pavel Dovgalyuk 3 years, 3 months ago
On 27.01.2021 09:52, Thomas Huth wrote:
> Our gitlab-CI just showed a failed test_ppc_mac99 since it was apparently
> killed some few seconds before the test finished. Allow it some more
> time to complete.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Acked-by: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>

> ---
>   Seen in this test log:
>   https://gitlab.com/qemu-project/qemu/-/jobs/987148065/artifacts/file/build/tests/results/latest/test-results/26-tests_acceptance_replay_kernel.py_ReplayKernelNormal.test_ppc_mac99/debug.log
> 
>   tests/acceptance/replay_kernel.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/acceptance/replay_kernel.py b/tests/acceptance/replay_kernel.py
> index 772633b01d..c1cb862468 100644
> --- a/tests/acceptance/replay_kernel.py
> +++ b/tests/acceptance/replay_kernel.py
> @@ -31,7 +31,7 @@ class ReplayKernelBase(LinuxKernelTest):
>       terminates.
>       """
>   
> -    timeout = 90
> +    timeout = 120
>       KERNEL_COMMON_COMMAND_LINE = 'printk.time=1 panic=-1 '
>   
>       def run_vm(self, kernel_path, kernel_command_line, console_pattern,
>