[v2] vhost-vdpa: add support for configure interrupt

[PATCH v2 0/5] vhost-vdpa: add support for configure interrupt

Cindy Lu posted 5 patches 3 years, 3 months ago

Diff against v1 v3 v4 v5 v6 v7 v8 v9 v10 v11 v12 v13 v14 v15 v16 v17 v18 v20 v21
Download series mbox

Test checkpatch failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210126070351.28575-1-lulu@redhat.com

Maintainers: Jason Wang <jasowang@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

There is a newer version of this series

hw/net/vhost_net.c                | 19 ++++++-
hw/virtio/trace-events            |  2 +
hw/virtio/vhost-vdpa.c            | 37 ++++++++++++-
hw/virtio/virtio-mmio.c           | 16 ++++++
hw/virtio/virtio-pci.c            | 92 +++++++++++++++++++++++++------
hw/virtio/virtio.c                | 26 +++++++++
include/hw/virtio/vhost-backend.h |  4 ++
include/hw/virtio/virtio-bus.h    |  2 +
include/hw/virtio/virtio.h        |  6 ++
9 files changed, 185 insertions(+), 19 deletions(-)

Expand all Fold all

[PATCH v2 0/5] vhost-vdpa: add support for configure interrupt

Posted by Cindy Lu 3 years, 3 months ago

These code are all tested in vp-vdpa (support configure interrupt)
vdpa_sim (not support configure interrupt)

change in v2:
Add support for virtio-mmio bus
Active the notifier while the backend support configure interrupt
Misc fixes form v1

Cindy Lu (5):
  virtio: add support for configure interrupt
  vhost_net: enable configure interrupt when vhost_net start
  virtio-pci: add support for configure interrupt
  virtio-mmio: add support for configure interrupt
  vhost-vdpa: add callback function for configure interrupt

 hw/net/vhost_net.c                | 19 ++++++-
 hw/virtio/trace-events            |  2 +
 hw/virtio/vhost-vdpa.c            | 37 ++++++++++++-
 hw/virtio/virtio-mmio.c           | 16 ++++++
 hw/virtio/virtio-pci.c            | 92 +++++++++++++++++++++++++------
 hw/virtio/virtio.c                | 26 +++++++++
 include/hw/virtio/vhost-backend.h |  4 ++
 include/hw/virtio/virtio-bus.h    |  2 +
 include/hw/virtio/virtio.h        |  6 ++
 9 files changed, 185 insertions(+), 19 deletions(-)

-- 
2.21.3

Re: [PATCH v2 0/5] vhost-vdpa: add support for configure interrupt

Posted by no-reply@patchew.org 3 years, 3 months ago

Patchew URL: https://patchew.org/QEMU/20210126070351.28575-1-lulu@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210126070351.28575-1-lulu@redhat.com
Subject: [PATCH v2 0/5] vhost-vdpa: add support for configure interrupt

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210126070351.28575-1-lulu@redhat.com -> patchew/20210126070351.28575-1-lulu@redhat.com
Switched to a new branch 'test'
ad89485 vhost-vdpa: add callback function for configure interrupt
5418ebe virtio-mmio: add support for configure interrupt
25554b9 virtio-pci: add support for configure interrupt
7181d5a vhost_net: enable configure interrupt when vhost_net start
8912097 virtio: add support for configure interrupt

=== OUTPUT BEGIN ===
1/5 Checking commit 8912097b7139 (virtio: add support for configure interrupt)
2/5 Checking commit 7181d5abe22f (vhost_net: enable configure interrupt when vhost_net start)
3/5 Checking commit 25554b9fa73a (virtio-pci: add support for configure interrupt)
4/5 Checking commit 5418ebee9696 (virtio-mmio: add support for configure interrupt)
5/5 Checking commit ad89485a096a (vhost-vdpa: add callback function for configure interrupt)
ERROR: space required before the open brace '{'
#59: FILE: hw/virtio/vhost-vdpa.c:488:
+    if ((vdev->use_config_notifier) && (start)){

total: 1 errors, 0 warnings, 90 lines checked

Patch 5/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210126070351.28575-1-lulu@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com