[PATCH 0/9] meson: Clarify summary

Philippe Mathieu-Daudé posted 9 patches 4 years, 10 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210119185005.880322-1-philmd@redhat.com
There is a newer version of this series
configure   |   6 +++
meson.build | 132 +++++++++++++++++++++++++++++-----------------------
2 files changed, 81 insertions(+), 57 deletions(-)
[PATCH 0/9] meson: Clarify summary
Posted by Philippe Mathieu-Daudé 4 years, 10 months ago
Reorder stuffs in summary to quicker understand bug reports.

Remove information from deselected features when not necessary.

Philippe Mathieu-Daudé (9):
  meson: Summarize generic information first
  meson: Summarize compilation information altogether
  meson: Summarize host binaries altogether
  meson: Summarize accelerators altogether
  meson: Display if system emulation is selected in summary
  meson: Restrict system-mode specific accelerators
  meson: Do not configure audio if system-mode is not selected
  meson: Display if user-mode emulation is selected in summary
  meson: Summarize block layer information altogether

 configure   |   6 +++
 meson.build | 132 +++++++++++++++++++++++++++++-----------------------
 2 files changed, 81 insertions(+), 57 deletions(-)

-- 
2.26.2


Re: [PATCH 0/9] meson: Clarify summary
Posted by Paolo Bonzini 4 years, 10 months ago
On 19/01/21 19:49, Philippe Mathieu-Daudé wrote:
> Reorder stuffs in summary to quicker understand bug reports.
> 
> Remove information from deselected features when not necessary.
> 
> Philippe Mathieu-Daudé (9):
>    meson: Summarize generic information first
>    meson: Summarize compilation information altogether
>    meson: Summarize host binaries altogether
>    meson: Summarize accelerators altogether
>    meson: Display if system emulation is selected in summary
>    meson: Restrict system-mode specific accelerators
>    meson: Do not configure audio if system-mode is not selected
>    meson: Display if user-mode emulation is selected in summary
>    meson: Summarize block layer information altogether
> 
>   configure   |   6 +++
>   meson.build | 132 +++++++++++++++++++++++++++++-----------------------
>   2 files changed, 81 insertions(+), 57 deletions(-)
> 

Very nice.  (I'm just not sure about patches 5 and 8 since there's 
already the target directories).  A couple nits:

* sparse should go in host binaries

* WIN_SDK should go in compilation information

* It would be nice to have a comment above each of the groups

I have done the changes myself.  I will also send out for review a patch 
to further group dependencies and "other features" (vhost, modules, etc.).

Paolo