hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
TP 4053 says (in section 2.3.1.1) -
... if a Zone Append command specifies a ZSLBA that is not the lowest
logical block address in that zone, then the controller shall abort
that command with a status code of Invalid Field In Command.
In the code, Zone Invalid Write is returned instead, fix this.
Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
---
hw/block/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index a8dc13553d..f64676a930 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -1150,7 +1150,7 @@ static uint16_t nvme_check_zone_write(NvmeCtrl *n, NvmeNamespace *ns,
if (append) {
if (unlikely(slba != zone->d.zslba)) {
trace_pci_nvme_err_append_not_at_start(slba, zone->d.zslba);
- status = NVME_ZONE_INVALID_WRITE;
+ status = NVME_INVALID_FIELD;
}
if (nvme_l2b(ns, nlb) > (n->page_size << n->zasl)) {
trace_pci_nvme_err_append_too_large(slba, nlb, n->zasl);
--
2.28.0
On Jan 18 12:39, Dmitry Fomichev wrote: > TP 4053 says (in section 2.3.1.1) - > ... if a Zone Append command specifies a ZSLBA that is not the lowest > logical block address in that zone, then the controller shall abort > that command with a status code of Invalid Field In Command. > > In the code, Zone Invalid Write is returned instead, fix this. > > Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com> > --- > hw/block/nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index a8dc13553d..f64676a930 100644 > --- a/hw/block/nvme.c > +++ b/hw/block/nvme.c > @@ -1150,7 +1150,7 @@ static uint16_t nvme_check_zone_write(NvmeCtrl *n, NvmeNamespace *ns, > if (append) { > if (unlikely(slba != zone->d.zslba)) { > trace_pci_nvme_err_append_not_at_start(slba, zone->d.zslba); > - status = NVME_ZONE_INVALID_WRITE; > + status = NVME_INVALID_FIELD; > } > if (nvme_l2b(ns, nlb) > (n->page_size << n->zasl)) { > trace_pci_nvme_err_append_too_large(slba, nlb, n->zasl); > -- > 2.28.0 > Thanks, applying!
© 2016 - 2024 Red Hat, Inc.