[v2] net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()

[PATCH v2 0/2] net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()

Philippe Mathieu-Daudé posted 2 patches 3 years, 3 months ago

Diff against v1 v3 v4 v5 v6
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210115151126.3334333-1-philmd@redhat.com

There is a newer version of this series

net/eth.c                      | 37 +++++++++++-------------
tests/qtest/fuzz-e1000e-test.c | 53 ++++++++++++++++++++++++++++++++++
MAINTAINERS                    |  1 +
tests/qtest/meson.build        |  1 +
4 files changed, 72 insertions(+), 20 deletions(-)
create mode 100644 tests/qtest/fuzz-e1000e-test.c

Expand all Fold all

[PATCH v2 0/2] net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()

Posted by Philippe Mathieu-Daudé 3 years, 3 months ago

I had a look at the patch from Miroslav trying to silence a
compiler warning which in fact is a nasty bug. Here is a fix.
https://www.mail-archive.com/qemu-devel@nongnu.org/msg772735.html

v2: Restrict tests so they don't fail when device aren't available

Based-on: <20210115150936.3333282-1-philmd@redhat.com>
          "tests/qtest: Fixes fuzz-tests"

Philippe Mathieu-Daudé (2):
  net/eth: Simplify _eth_get_rss_ex_dst_addr()
  net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()

 net/eth.c                      | 37 +++++++++++-------------
 tests/qtest/fuzz-e1000e-test.c | 53 ++++++++++++++++++++++++++++++++++
 MAINTAINERS                    |  1 +
 tests/qtest/meson.build        |  1 +
 4 files changed, 72 insertions(+), 20 deletions(-)
 create mode 100644 tests/qtest/fuzz-e1000e-test.c

-- 
2.26.2

Re: [PATCH v2 0/2] net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()

Posted by Miroslav Rezanina 3 years, 3 months ago

On Fri, Jan 15, 2021 at 04:11:24PM +0100, Philippe Mathieu-DaudÃ© wrote:
> I had a look at the patch from Miroslav trying to silence a
> compiler warning which in fact is a nasty bug. Here is a fix.
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg772735.html
> 
> v2: Restrict tests so they don't fail when device aren't available
> 
> Based-on: <20210115150936.3333282-1-philmd@redhat.com>
>           "tests/qtest: Fixes fuzz-tests"
> 
> Philippe Mathieu-DaudÃ© (2):
>   net/eth: Simplify _eth_get_rss_ex_dst_addr()
>   net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()
> 
>  net/eth.c                      | 37 +++++++++++-------------
>  tests/qtest/fuzz-e1000e-test.c | 53 ++++++++++++++++++++++++++++++++++
>  MAINTAINERS                    |  1 +
>  tests/qtest/meson.build        |  1 +
>  4 files changed, 72 insertions(+), 20 deletions(-)
>  create mode 100644 tests/qtest/fuzz-e1000e-test.c
> 
> -- 
> 2.26.2
> 
> 
>
Reviewed-by: Miroslav Rezanina <mrezanin@redhat.com>