[PATCH v2 0/7]Fix some style problems in audio

Zhang Han posted 7 patches 3 years, 3 months ago
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210115012431.79533-1-zhanghan64@huawei.com
Maintainers: Gerd Hoffmann <kraxel@redhat.com>
audio/alsaaudio.c      | 15 +++++--------
audio/audio.c          | 26 ++++++++++------------
audio/audio_template.h | 24 +++++++++-----------
audio/coreaudio.c      | 17 +++++++-------
audio/dsoundaudio.c    | 50 +++++++++++++++++++++++++++---------------
audio/jackaudio.c      |  2 +-
audio/ossaudio.c       | 12 ++++------
audio/paaudio.c        |  2 +-
8 files changed, 73 insertions(+), 75 deletions(-)
[PATCH v2 0/7]Fix some style problems in audio
Posted by Zhang Han 3 years, 3 months ago
Some style problems in audio directory are found by checkpatch.pl. Fix these
style problems.

v2:
- fix style problem: redundant spaces between function name and open parenthesis'('
- fix subject of patch[5/7] for email display

Zhang Han (7):
  audio: Add braces for statements/fix braces' position
  audio: Add spaces around operator/delete redundant spaces
  audio: foo* bar" should be "foo *bar".
  audio: Fix lines over 90 characters
  audio: Don't use '%#' in format strings
  audio: Suspect code indent for conditional statements
  audio: space prohibited between function name and parenthesis'('

 audio/alsaaudio.c      | 15 +++++--------
 audio/audio.c          | 26 ++++++++++------------
 audio/audio_template.h | 24 +++++++++-----------
 audio/coreaudio.c      | 17 +++++++-------
 audio/dsoundaudio.c    | 50 +++++++++++++++++++++++++++---------------
 audio/jackaudio.c      |  2 +-
 audio/ossaudio.c       | 12 ++++------
 audio/paaudio.c        |  2 +-
 8 files changed, 73 insertions(+), 75 deletions(-)

-- 
2.29.1.59.gf9b6481aed


Re: [PATCH v2 0/7]Fix some style problems in audio
Posted by no-reply@patchew.org 3 years, 3 months ago
Patchew URL: https://patchew.org/QEMU/20210115012431.79533-1-zhanghan64@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210115012431.79533-1-zhanghan64@huawei.com
Subject: [PATCH v2 0/7]Fix some style problems in audio

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210115012431.79533-1-zhanghan64@huawei.com -> patchew/20210115012431.79533-1-zhanghan64@huawei.com
Switched to a new branch 'test'
aa9fd41 audio: space prohibited between function name and parenthesis'('
f36ebe9 audio: Suspect code indent for conditional statements
a5048b4 audio: Don't use '%#' in format strings
136df5d audio: Fix lines over 90 characters
5cfea16 audio: foo* bar" should be "foo *bar".
0f4324f audio: Add spaces around operator/delete redundant spaces
4a9b916 audio: Add braces for statements/fix braces' position

=== OUTPUT BEGIN ===
1/7 Checking commit 4a9b9160f3c9 (audio: Add braces for statements/fix braces' position)
2/7 Checking commit 0f4324ff6333 (audio: Add spaces around operator/delete redundant spaces)
ERROR: space prohibited between function name and open parenthesis '('
#23: FILE: audio/audio_template.h:211:
+        glue (audio_pcm_hw_free_resources_ , TYPE) (hw);

total: 1 errors, 0 warnings, 32 lines checked

Patch 2/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/7 Checking commit 5cfea163dd87 (audio: foo* bar" should be "foo *bar".)
4/7 Checking commit 136df5d76762 (audio: Fix lines over 90 characters)
5/7 Checking commit a5048b437dad (audio: Don't use '%#' in format strings)
6/7 Checking commit f36ebe97559f (audio: Suspect code indent for conditional statements)
7/7 Checking commit aa9fd41947b4 (audio: space prohibited between function name and parenthesis'(')
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210115012431.79533-1-zhanghan64@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com