[PATCH v2 05/12] Makefile: wrap ctags in quiet-command calls

Alex Bennée posted 12 patches 4 years, 10 months ago
[PATCH v2 05/12] Makefile: wrap ctags in quiet-command calls
Posted by Alex Bennée 4 years, 10 months ago
For prettier output.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 Makefile | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 0c509a7704..bbab640b31 100644
--- a/Makefile
+++ b/Makefile
@@ -250,8 +250,13 @@ find-src-path = find "$(SRC_PATH)/" -path "$(SRC_PATH)/meson" -prune -o \( -name
 
 .PHONY: ctags
 ctags:
-	rm -f "$(SRC_PATH)/"tags
-	$(find-src-path) -exec ctags -f "$(SRC_PATH)/"tags --append {} +
+	$(call quiet-command, 			\
+		rm -f "$(SRC_PATH)/"tags, 	\
+		"CTAGS", "Remove old tags")
+	$(call quiet-command, \
+		$(find-src-path) -exec ctags 		\
+		-f "$(SRC_PATH)/"tags --append {} +,	\
+		"CTAGS", "Re-index $(SRC_PATH)")
 
 .PHONY: gtags
 gtags:
-- 
2.20.1


Re: [PATCH v2 05/12] Makefile: wrap ctags in quiet-command calls
Posted by Philippe Mathieu-Daudé 4 years, 10 months ago
On 1/14/21 5:57 PM, Alex Bennée wrote:
> For prettier output.

Having commit description following patch subject is not very
practical (maybe this is obvious in an emacs client, not in
mine :S).

Anyhow:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  Makefile | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)


Re: [PATCH v2 05/12] Makefile: wrap ctags in quiet-command calls
Posted by Willian Rampazzo 4 years, 10 months ago
On Thu, Jan 14, 2021 at 2:21 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>
> For prettier output.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  Makefile | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>

Reviewed-by: Willian Rampazzo <willianr@redhat.com>