testing/next (tags!, shippable/travis deprecation, regression fixes, checkpatch)

[PATCH v2 04/12] Add newline when generating Dockerfile

Posted by Alex Bennée 4 years, 10 months ago

From: Alessandro Di Federico <ale@rev.ng>

Signed-off-by: Alessandro Di Federico <ale@rev.ng>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <1610080146-14968-36-git-send-email-tsimpson@quicinc.com>
---
 tests/docker/docker.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/docker/docker.py b/tests/docker/docker.py
index 36b7868406..884dfeb29c 100755
--- a/tests/docker/docker.py
+++ b/tests/docker/docker.py
@@ -332,9 +332,9 @@ class Docker(object):
                          (uname, uid, uname))
 
         tmp_df.write("\n")
-        tmp_df.write("LABEL com.qemu.dockerfile-checksum=%s" % (checksum))
+        tmp_df.write("LABEL com.qemu.dockerfile-checksum=%s\n" % (checksum))
         for f, c in extra_files_cksum:
-            tmp_df.write("LABEL com.qemu.%s-checksum=%s" % (f, c))
+            tmp_df.write("LABEL com.qemu.%s-checksum=%s\n" % (f, c))
 
         tmp_df.flush()
 
-- 
2.20.1

Re: [PATCH v2 04/12] Add newline when generating Dockerfile

Posted by Philippe Mathieu-Daudé 4 years, 10 months ago

On 1/14/21 5:57 PM, Alex Bennée wrote:
> From: Alessandro Di Federico <ale@rev.ng>
> 
> Signed-off-by: Alessandro Di Federico <ale@rev.ng>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <1610080146-14968-36-git-send-email-tsimpson@quicinc.com>
> ---
>  tests/docker/docker.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [PATCH v2 04/12] Add newline when generating Dockerfile

Posted by Willian Rampazzo 4 years, 10 months ago

On Thu, Jan 14, 2021 at 2:37 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>
> From: Alessandro Di Federico <ale@rev.ng>
>
> Signed-off-by: Alessandro Di Federico <ale@rev.ng>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <1610080146-14968-36-git-send-email-tsimpson@quicinc.com>
> ---
>  tests/docker/docker.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Willian Rampazzo <willianr@redhat.com>