[v1] net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()

[PATCH 0/2] net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()

Philippe Mathieu-Daudé posted 2 patches 4 years, 10 months ago

Diff against v2 v3 v4 v5 v6
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210114145041.2865440-1-philmd@redhat.com

There is a newer version of this series

net/eth.c | 37 +++++++++++++++++--------------------
1 file changed, 17 insertions(+), 20 deletions(-)

Expand all Fold all

[PATCH 0/2] net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()

Posted by Philippe Mathieu-Daudé 4 years, 10 months ago

I had a look at the patch from Miroslav trying to silence a
compiler warning which in fact is a nasty bug. Here is a fix.
https://www.mail-archive.com/qemu-devel@nongnu.org/msg772735.html

Philippe Mathieu-Daudé (2):
  net/eth: Simplify _eth_get_rss_ex_dst_addr()
  net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()

 net/eth.c | 37 +++++++++++++++++--------------------
 1 file changed, 17 insertions(+), 20 deletions(-)

-- 
2.26.2

Re: [PATCH 0/2] net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()

Posted by Miroslav Rezanina 4 years, 10 months ago

On Thu, Jan 14, 2021 at 03:50:39PM +0100, Philippe Mathieu-DaudÃ© wrote:
> I had a look at the patch from Miroslav trying to silence a
> compiler warning which in fact is a nasty bug. Here is a fix.
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg772735.html
> 
> Philippe Mathieu-DaudÃ© (2):
>   net/eth: Simplify _eth_get_rss_ex_dst_addr()
>   net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()
> 
>  net/eth.c | 37 +++++++++++++++++--------------------
>  1 file changed, 17 insertions(+), 20 deletions(-)
> 
> -- 
> 2.26.2
> 
> 
> 

With qtest chunk included:

Reviewed-by: Miroslav Rezanina <mrezanin@redhat.com>