[PATCH 2/7] iotests/129: Remove test images in tearDown()

Max Reitz posted 7 patches 4 years, 10 months ago
Maintainers: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
[PATCH 2/7] iotests/129: Remove test images in tearDown()
Posted by Max Reitz 4 years, 10 months ago
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 tests/qemu-iotests/129 | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
index 0e13244d85..2fc65ada6a 100755
--- a/tests/qemu-iotests/129
+++ b/tests/qemu-iotests/129
@@ -47,6 +47,8 @@ class TestStopWithBlockJob(iotests.QMPTestCase):
         result = self.vm.qmp("block_set_io_throttle", conv_keys=False,
                              **params)
         self.vm.shutdown()
+        for img in (self.test_img, self.target_img, self.base_img):
+            iotests.try_remove(img)
 
     def do_test_stop(self, cmd, **args):
         """Test 'stop' while block job is running on a throttled drive.
-- 
2.29.2


Re: [PATCH 2/7] iotests/129: Remove test images in tearDown()
Posted by Vladimir Sementsov-Ogievskiy 4 years, 10 months ago
13.01.2021 17:06, Max Reitz wrote:
> Signed-off-by: Max Reitz <mreitz@redhat.com>


Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

> ---
>   tests/qemu-iotests/129 | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
> index 0e13244d85..2fc65ada6a 100755
> --- a/tests/qemu-iotests/129
> +++ b/tests/qemu-iotests/129
> @@ -47,6 +47,8 @@ class TestStopWithBlockJob(iotests.QMPTestCase):
>           result = self.vm.qmp("block_set_io_throttle", conv_keys=False,
>                                **params)
>           self.vm.shutdown()
> +        for img in (self.test_img, self.target_img, self.base_img):
> +            iotests.try_remove(img)
>   
>       def do_test_stop(self, cmd, **args):
>           """Test 'stop' while block job is running on a throttled drive.
> 


-- 
Best regards,
Vladimir

Re: [PATCH 2/7] iotests/129: Remove test images in tearDown()
Posted by Eric Blake 4 years, 10 months ago
On 1/13/21 8:06 AM, Max Reitz wrote:
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  tests/qemu-iotests/129 | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
> index 0e13244d85..2fc65ada6a 100755
> --- a/tests/qemu-iotests/129
> +++ b/tests/qemu-iotests/129
> @@ -47,6 +47,8 @@ class TestStopWithBlockJob(iotests.QMPTestCase):
>          result = self.vm.qmp("block_set_io_throttle", conv_keys=False,
>                               **params)
>          self.vm.shutdown()
> +        for img in (self.test_img, self.target_img, self.base_img):
> +            iotests.try_remove(img)
>  
>      def do_test_stop(self, cmd, **args):
>          """Test 'stop' while block job is running on a throttled drive.
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org