[v2] target/arm: Fix sve pred_desc decoding

[PATCH v2 0/4] target/arm: Fix sve pred_desc decoding

Richard Henderson posted 4 patches 3 years, 3 months ago

Diff against v1
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210113062650.593824-1-richard.henderson@linaro.org

Maintainers: Peter Maydell <peter.maydell@linaro.org>

target/arm/internals.h     |  9 +++++++++
target/arm/sve_helper.c    | 33 +++++++++++++++++----------------
target/arm/translate-sve.c | 31 +++++++++++--------------------
3 files changed, 37 insertions(+), 36 deletions(-)

Expand all Fold all

[PATCH v2 0/4] target/arm: Fix sve pred_desc decoding

Posted by Richard Henderson 3 years, 3 months ago

There was an inconsistency between encoding, which uses
SIMD_DATA_SHIFT, and decoding which used SIMD_OPRSZ_BITS.
This happened to be ok, until e2e7168a214, which reduced
the size of SIMD_OPRSZ_BITS, which lead to truncating all
predicate vector lengths.

Changes in v2:
  * Introduce and use PREDDESC field definitions, rather
    than abusing a different SIMD_* macro.


r~


Richard Henderson (4):
  target/arm: Introduce PREDDESC field definitions
  target/arm: Update PFIRST, PNEXT for pred_desc
  target/arm: Update ZIP, UZP, TRN for pred_desc
  target/arm: Update REV, PUNPK for pred_desc

 target/arm/internals.h     |  9 +++++++++
 target/arm/sve_helper.c    | 33 +++++++++++++++++----------------
 target/arm/translate-sve.c | 31 +++++++++++--------------------
 3 files changed, 37 insertions(+), 36 deletions(-)

-- 
2.25.1

Re: [PATCH v2 0/4] target/arm: Fix sve pred_desc decoding

Posted by Peter Maydell 3 years, 3 months ago

On Wed, 13 Jan 2021 at 06:26, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> There was an inconsistency between encoding, which uses
> SIMD_DATA_SHIFT, and decoding which used SIMD_OPRSZ_BITS.
> This happened to be ok, until e2e7168a214, which reduced
> the size of SIMD_OPRSZ_BITS, which lead to truncating all
> predicate vector lengths.
>
> Changes in v2:
>   * Introduce and use PREDDESC field definitions, rather
>     than abusing a different SIMD_* macro.
>
>
> r~
>
>
> Richard Henderson (4):
>   target/arm: Introduce PREDDESC field definitions
>   target/arm: Update PFIRST, PNEXT for pred_desc
>   target/arm: Update ZIP, UZP, TRN for pred_desc
>   target/arm: Update REV, PUNPK for pred_desc

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

and applied to target-arm.next.

thanks
-- PMM