[PULL 00/20] Misc patches for 2021-01-12

Paolo Bonzini posted 20 patches 1 week ago
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210112171450.791427-1-pbonzini@redhat.com
Maintainers: Laurent Vivier <lvivier@redhat.com>, Thomas Huth <thuth@redhat.com>, Cleber Rosa <crosa@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Christian Schoenebeck <qemu_oss@crudebyte.com>, Gerd Hoffmann <kraxel@redhat.com>, Fam Zheng <fam@euphon.net>, "Daniel P. Berrangé" <berrange@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Max Reitz <mreitz@redhat.com>, Li-Wen Hsu <lwhsu@freebsd.org>, Sunil Muthuswamy <sunilmut@microsoft.com>, Richard Henderson <richard.henderson@linaro.org>, Ed Maste <emaste@freebsd.org>, Greg Kurz <groug@kaod.org>, Eduardo Habkost <ehabkost@redhat.com>
.cirrus.yml                                        | 119 ++++++++++++---------
MAINTAINERS                                        |   6 ++
block/meson.build                                  |   2 +-
configure                                          |  93 ++--------------
docs/devel/rcu.txt                                 |   2 +-
fsdev/meson.build                                  |   2 +-
hw/scsi/trace-events                               |   9 ++
hw/scsi/virtio-scsi.c                              |  30 +++++-
include/sysemu/whpx.h                              |  22 +---
io/meson.build                                     |   2 +-
meson.build                                        |  57 ++++++----
meson_options.txt                                  |   2 +
scripts/qemu-gdb.py                                |   1 +
scripts/qemugdb/coroutine.py                       |  35 +++++-
storage-daemon/meson.build                         |   2 +-
target/i386/cpu.h                                  |   4 +-
target/i386/gdbstub.c                              |   2 +-
target/i386/tcg/seg_helper.c                       |   8 +-
target/i386/tcg/translate.c                        |   6 +-
target/i386/whpx/whpx-all.c                        |   9 +-
target/i386/whpx/whpx-apic.c                       |   9 +-
target/i386/whpx/whpx-cpus.c                       |   4 +-
.../i386/whpx/{whp-dispatch.h => whpx-internal.h}  |  17 ++-
tests/meson.build                                  |   6 +-
tests/qtest/meson.build                            |   4 +-
ui/gtk.c                                           |  16 +--
ui/meson.build                                     |  11 +-
27 files changed, 261 insertions(+), 219 deletions(-)
rename target/i386/whpx/{whp-dispatch.h => whpx-internal.h} (93%)

[PULL 00/20] Misc patches for 2021-01-12

Posted by Paolo Bonzini 1 week ago
The following changes since commit b3f846c59d8405bb87c551187721fc92ff2f1b92:

  Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2021-01-11v2' into staging (2021-01-11 15:15:35 +0000)

are available in the Git repository at:

  https://gitlab.com/bonzini/qemu.git tags/for-upstream

for you to fetch changes up to c117e5b11a21598205f1701a15965e825959d59f:

  target/i386: Use X86Seg enum for segment registers (2021-01-12 17:05:10 +0100)

----------------------------------------------------------------
* UI configury cleanups and Meson conversion
* scripts/gdb improvements
* WHPX cleanups and fixes
* cirrus win32 CI improvements
* meson gnutls workaround

----------------------------------------------------------------
Chris Hofstaedtler (1):
      meson: fix Cocoa option in summary

Hannes Reinecke (1):
      virtio-scsi: trace events

Keqian Zhu (1):
      Docs/RCU: Correct sample code of qatomic_rcu_set

Maxim Levitsky (2):
      scripts/gdb: fix 'qemu coroutine' when users selects a non topmost stack frame
      scripts/gdb: implement 'qemu bt'

Paolo Bonzini (9):
      meson: do not use CONFIG_VIRTFS
      whpx: rename whp-dispatch to whpx-internal.h
      whpx: move internal definitions to whpx-internal.h
      cocoa: do not enable coreaudio automatically
      gtk: remove CONFIG_GTK_GL
      configure: move X11 detection to Meson
      configure: move GTK+ detection to Meson
      configure: move Cocoa incompatibility checks to Meson
      configure: quote command line arguments in config.status

Philippe Mathieu-Daudé (1):
      target/i386: Use X86Seg enum for segment registers

Roman Bolshakov (1):
      meson: Propagate gnutls dependency

Yonggang Luo (4):
      cirrus/msys2: Exit powershell with $LastExitCode
      cirrus/msys2: Cache msys2 mingw in a better way.
      maintainers: Add me as Windows Hosted Continuous Integration maintainer
      whpx: move whpx_lapic_state from header to c file

 .cirrus.yml                                        | 119 ++++++++++++---------
 MAINTAINERS                                        |   6 ++
 block/meson.build                                  |   2 +-
 configure                                          |  93 ++--------------
 docs/devel/rcu.txt                                 |   2 +-
 fsdev/meson.build                                  |   2 +-
 hw/scsi/trace-events                               |   9 ++
 hw/scsi/virtio-scsi.c                              |  30 +++++-
 include/sysemu/whpx.h                              |  22 +---
 io/meson.build                                     |   2 +-
 meson.build                                        |  57 ++++++----
 meson_options.txt                                  |   2 +
 scripts/qemu-gdb.py                                |   1 +
 scripts/qemugdb/coroutine.py                       |  35 +++++-
 storage-daemon/meson.build                         |   2 +-
 target/i386/cpu.h                                  |   4 +-
 target/i386/gdbstub.c                              |   2 +-
 target/i386/tcg/seg_helper.c                       |   8 +-
 target/i386/tcg/translate.c                        |   6 +-
 target/i386/whpx/whpx-all.c                        |   9 +-
 target/i386/whpx/whpx-apic.c                       |   9 +-
 target/i386/whpx/whpx-cpus.c                       |   4 +-
 .../i386/whpx/{whp-dispatch.h => whpx-internal.h}  |  17 ++-
 tests/meson.build                                  |   6 +-
 tests/qtest/meson.build                            |   4 +-
 ui/gtk.c                                           |  16 +--
 ui/meson.build                                     |  11 +-
 27 files changed, 261 insertions(+), 219 deletions(-)
 rename target/i386/whpx/{whp-dispatch.h => whpx-internal.h} (93%)
-- 
2.29.2


Re: [PULL 00/20] Misc patches for 2021-01-12

Posted by no-reply@patchew.org 1 week ago
Patchew URL: https://patchew.org/QEMU/20210112171450.791427-1-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210112171450.791427-1-pbonzini@redhat.com
Subject: [PULL 00/20] Misc patches for 2021-01-12

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210109125811.209870-1-vsementsov@virtuozzo.com -> patchew/20210109125811.209870-1-vsementsov@virtuozzo.com
 * [new tag]         patchew/20210112171450.791427-1-pbonzini@redhat.com -> patchew/20210112171450.791427-1-pbonzini@redhat.com
Switched to a new branch 'test'
4b4de09 target/i386: Use X86Seg enum for segment registers
f36e689 configure: quote command line arguments in config.status
06c6b09 configure: move Cocoa incompatibility checks to Meson
37cb8a4a configure: move GTK+ detection to Meson
6eac7eb configure: move X11 detection to Meson
2b4c62c gtk: remove CONFIG_GTK_GL
5b6d211 cocoa: do not enable coreaudio automatically
e353ea7 virtio-scsi: trace events
a194582 meson: Propagate gnutls dependency
259aabc Docs/RCU: Correct sample code of qatomic_rcu_set
a0cd451 scripts/gdb: implement 'qemu bt'
267f073 scripts/gdb: fix 'qemu coroutine' when users selects a non topmost stack frame
1a77200 meson: fix Cocoa option in summary
24d937b whpx: move whpx_lapic_state from header to c file
5f410d8 maintainers: Add me as Windows Hosted Continuous Integration maintainer
d70a844 cirrus/msys2: Cache msys2 mingw in a better way.
51192e6 cirrus/msys2: Exit powershell with $LastExitCode
f5205e9 whpx: move internal definitions to whpx-internal.h
5b4477c whpx: rename whp-dispatch to whpx-internal.h
753e527 meson: do not use CONFIG_VIRTFS

=== OUTPUT BEGIN ===
1/20 Checking commit 753e52778484 (meson: do not use CONFIG_VIRTFS)
2/20 Checking commit 5b4477cde88a (whpx: rename whp-dispatch to whpx-internal.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#66: 
rename from target/i386/whpx/whp-dispatch.h

total: 0 errors, 1 warnings, 46 lines checked

Patch 2/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/20 Checking commit f5205e9be085 (whpx: move internal definitions to whpx-internal.h)
ERROR: open brace '{' following function declarations go on the next line
#59: FILE: target/i386/whpx/whpx-all.c:1869:
+bool whpx_apic_in_platform(void) {

total: 1 errors, 0 warnings, 63 lines checked

Patch 3/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/20 Checking commit 51192e6f483a (cirrus/msys2: Exit powershell with $LastExitCode)
5/20 Checking commit d70a84414d98 (cirrus/msys2: Cache msys2 mingw in a better way.)
ERROR: trailing whitespace
#144: FILE: .cirrus.yml:147:
+        del -Force -Recurse -ErrorAction SilentlyContinue c:\tools\msys64 $

total: 1 errors, 0 warnings, 140 lines checked

Patch 5/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/20 Checking commit 5f410d85619f (maintainers: Add me as Windows Hosted Continuous Integration maintainer)
7/20 Checking commit 24d937bdf31e (whpx: move whpx_lapic_state from header to c file)
8/20 Checking commit 1a7720081883 (meson: fix Cocoa option in summary)
ERROR: Doubly-encoded UTF-8
#12: 
    Cc: Philippe Mathieu-Daudé <philmd@redhat.com>

total: 1 errors, 0 warnings, 8 lines checked

Patch 8/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/20 Checking commit 267f073936f6 (scripts/gdb: fix 'qemu coroutine' when users selects a non topmost stack frame)
10/20 Checking commit a0cd451f1321 (scripts/gdb: implement 'qemu bt')
11/20 Checking commit 259aabcf3546 (Docs/RCU: Correct sample code of qatomic_rcu_set)
12/20 Checking commit a1945823831a (meson: Propagate gnutls dependency)
13/20 Checking commit e353ea7827f5 (virtio-scsi: trace events)
ERROR: trailing whitespace
#118: FILE: hw/scsi/virtio-scsi.c:797:
+     $

total: 1 errors, 0 warnings, 92 lines checked

Patch 13/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

14/20 Checking commit 5b6d2119a01d (cocoa: do not enable coreaudio automatically)
15/20 Checking commit 2b4c62c148d1 (gtk: remove CONFIG_GTK_GL)
16/20 Checking commit 6eac7ebb35ca (configure: move X11 detection to Meson)
17/20 Checking commit 37cb8a4abf45 (configure: move GTK+ detection to Meson)
18/20 Checking commit 06c6b09067ce (configure: move Cocoa incompatibility checks to Meson)
19/20 Checking commit f36e6892f9bc (configure: quote command line arguments in config.status)
20/20 Checking commit 4b4de091e027 (target/i386: Use X86Seg enum for segment registers)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210112171450.791427-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PULL 00/20] Misc patches for 2021-01-12

Posted by Peter Maydell 1 week ago
On Tue, 12 Jan 2021 at 17:28, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> The following changes since commit b3f846c59d8405bb87c551187721fc92ff2f1b92:
>
>   Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2021-01-11v2' into staging (2021-01-11 15:15:35 +0000)
>
> are available in the Git repository at:
>
>   https://gitlab.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to c117e5b11a21598205f1701a15965e825959d59f:
>
>   target/i386: Use X86Seg enum for segment registers (2021-01-12 17:05:10 +0100)
>
> ----------------------------------------------------------------
> * UI configury cleanups and Meson conversion
> * scripts/gdb improvements
> * WHPX cleanups and fixes
> * cirrus win32 CI improvements
> * meson gnutls workaround
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
for any user-visible changes.

-- PMM