[PATCH 3/6] gitlab-ci: remove redundant GitLab repo URL command

Stefan Hajnoczi posted 6 patches 5 years ago
[PATCH 3/6] gitlab-ci: remove redundant GitLab repo URL command
Posted by Stefan Hajnoczi 5 years ago
It is no longer necessary to point .gitmodules at GitLab repos when
running in GitLab CI since they are now used all the time.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 .gitlab-ci.yml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 01c9e46410..4c2a71b934 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -18,7 +18,6 @@ include:
   image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest
   before_script:
     - JOBS=$(expr $(nproc) + 1)
-    - sed -i s,git.qemu.org/git,gitlab.com/qemu-project, .gitmodules
   script:
     - mkdir build
     - cd build
-- 
2.29.2

Re: [PATCH 3/6] gitlab-ci: remove redundant GitLab repo URL command
Posted by Philippe Mathieu-Daudé 5 years ago
On 1/11/21 12:50 PM, Stefan Hajnoczi wrote:
> It is no longer necessary to point .gitmodules at GitLab repos when
> running in GitLab CI since they are now used all the time.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  .gitlab-ci.yml | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


Re: [PATCH 3/6] gitlab-ci: remove redundant GitLab repo URL command
Posted by Thomas Huth 5 years ago
On 11/01/2021 12.50, Stefan Hajnoczi wrote:
> It is no longer necessary to point .gitmodules at GitLab repos when
> running in GitLab CI since they are now used all the time.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>   .gitlab-ci.yml | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 01c9e46410..4c2a71b934 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -18,7 +18,6 @@ include:
>     image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest
>     before_script:
>       - JOBS=$(expr $(nproc) + 1)
> -    - sed -i s,git.qemu.org/git,gitlab.com/qemu-project, .gitmodules
>     script:
>       - mkdir build
>       - cd build
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>