Commit dfbd0b873a8 inadvertently swapped the arguments
of _aligned_malloc(), correct it to fix [*]:
G_TEST_SRCDIR=C:/Users/ContainerAdministrator/AppData/Local/Temp/cirrus-ci-build/tests
G_TEST_BUILDDIR=C:/Users/ContainerAdministrator/AppData/Local/Temp/cirrus-ci-build/build/tests
tests/test-qht.exe --tap -k
ERROR test-qht - too few tests run (expected 2, got 0)
make: *** [Makefile.mtest:256: run-test-30] Error 1
[*] https://cirrus-ci.com/task/6055645751279616?command=test#L593
Fixes: dfbd0b873a8 ("util/oslib-win32: Use _aligned_malloc for qemu_try_memalign")
Reported-by: Yonggang Luo <luoyonggang@gmail.com>
Reported-by: Volker Rümelin <vr_qemu@t-online.de>
Suggested-by: Volker Rümelin <vr_qemu@t-online.de>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
util/oslib-win32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/oslib-win32.c b/util/oslib-win32.c
index e6f83e10edb..f68b8012bb8 100644
--- a/util/oslib-win32.c
+++ b/util/oslib-win32.c
@@ -59,7 +59,7 @@ void *qemu_try_memalign(size_t alignment, size_t size)
g_assert(size != 0);
g_assert(is_power_of_2(alignment));
- ptr = _aligned_malloc(alignment, size);
+ ptr = _aligned_malloc(size, alignment);
trace_qemu_memalign(alignment, size, ptr);
return ptr;
}
--
2.26.2
On Sun, Jan 10, 2021 at 4:16 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > Commit dfbd0b873a8 inadvertently swapped the arguments > of _aligned_malloc(), correct it to fix [*]: > > G_TEST_SRCDIR=C:/Users/ContainerAdministrator/AppData/Local/Temp/cirrus-ci-build/tests > G_TEST_BUILDDIR=C:/Users/ContainerAdministrator/AppData/Local/Temp/cirrus-ci-build/build/tests > tests/test-qht.exe --tap -k > ERROR test-qht - too few tests run (expected 2, got 0) > make: *** [Makefile.mtest:256: run-test-30] Error 1 > > [*] https://cirrus-ci.com/task/6055645751279616?command=test#L593 > > Fixes: dfbd0b873a8 ("util/oslib-win32: Use _aligned_malloc for qemu_try_memalign") > Reported-by: Yonggang Luo <luoyonggang@gmail.com> > Reported-by: Volker Rümelin <vr_qemu@t-online.de> > Suggested-by: Volker Rümelin <vr_qemu@t-online.de> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > util/oslib-win32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/oslib-win32.c b/util/oslib-win32.c > index e6f83e10edb..f68b8012bb8 100644 > --- a/util/oslib-win32.c > +++ b/util/oslib-win32.c > @@ -59,7 +59,7 @@ void *qemu_try_memalign(size_t alignment, size_t size) > > g_assert(size != 0); > g_assert(is_power_of_2(alignment)); > - ptr = _aligned_malloc(alignment, size); > + ptr = _aligned_malloc(size, alignment); > trace_qemu_memalign(alignment, size, ptr); > return ptr; > } > -- > 2.26.2 > Oh, sorry, you 've fixed this. ignore my patch Reviewed-by: Yonggang Luo <luoyonggang@gmail.com> -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo
© 2016 - 2024 Red Hat, Inc.