[PATCH v2 0/4] s390x/tcg: fix booting Linux kernels compiled with clang-11 and clang-12

David Hildenbrand posted 4 patches 3 years, 4 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210108132049.8501-1-david@redhat.com
Maintainers: Thomas Huth <thuth@redhat.com>, David Hildenbrand <david@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Richard Henderson <richard.henderson@linaro.org>
There is a newer version of this series
target/s390x/insn-data.def | 10 +++++-----
target/s390x/mem_helper.c  |  4 ++--
target/s390x/translate.c   | 33 +++++++++++++++++----------------
3 files changed, 24 insertions(+), 23 deletions(-)
[PATCH v2 0/4] s390x/tcg: fix booting Linux kernels compiled with clang-11 and clang-12
Posted by David Hildenbrand 3 years, 4 months ago
This series fixes booting current upstream Linux kernel compiled by
clang-11 and clang-12 under TCG.

Decided to pull in already separatly sent patches. The last patch is
not required to fix the boot issues, but related to patch #3.

Latest version of the patches available at:
git@github.com:davidhildenbrand/qemu.git clang

v1 -> v2:
- Add 's390x/tcg: Don't ignore content in r0 when not specified via "b" or
  "x"'
- Add 's390x/tcg: Ignore register content if b1/b2 is zero when handling
  EXEUTE'
- "s390x/tcg: Fix ALGSI"
-- Fixup subject
- "s390x/tcg: Fix RISBHG"
-- Rephrase description, stating that it fixes clang-11

David Hildenbrand (4):
  s390x/tcg: Fix ALGSI
  s390x/tcg: Fix RISBHG
  s390x/tcg: Only ignore content in r0 when specified via "b" or "x"
  s390x/tcg: Ignore register content if b1/b2 is zero when handling
    EXECUTE

 target/s390x/insn-data.def | 10 +++++-----
 target/s390x/mem_helper.c  |  4 ++--
 target/s390x/translate.c   | 33 +++++++++++++++++----------------
 3 files changed, 24 insertions(+), 23 deletions(-)

-- 
2.29.2


Re: [PATCH v2 0/4] s390x/tcg: fix booting Linux kernels compiled with clang-11 and clang-12
Posted by Nick Desaulniers via 3 years, 4 months ago
On Fri, Jan 8, 2021 at 5:21 AM David Hildenbrand <david@redhat.com> wrote:
>
> This series fixes booting current upstream Linux kernel compiled by
> clang-11 and clang-12 under TCG.
>
> Decided to pull in already separatly sent patches. The last patch is
> not required to fix the boot issues, but related to patch #3.
>
> Latest version of the patches available at:
> git@github.com:davidhildenbrand/qemu.git clang

Hey looks like we're off to the races!

$ qemu/build/qemu-system-s390x -M s390-ccw-virtio -display none
-initrd /android1/boot-utils/images/s390/rootfs.cpio -kernel
/android0/linux-next/arch/s390/boot/bzImage -m 512m -nodefaults
-serial mon:stdio
...
[    0.365077] Linux version 5.11.0-rc2-01914-g16586f130181-dirty
(ndesaulniers@ndesaulniers1.mtv.corp.google.com) (Nick Desaulniers
clang version 12.0.0 (git@github.com:llvm/llvm-project.git
e75fec2b238f0e26cfb7645f2208baebe3440d41), GNU ld (GNU Binutils for
Debian) 2.35.1) #76 SMP Thu Jan 7 17:51:34 PST 2021
...
/ # cat /proc/version
Linux version 5.11.0-rc2-01914-g16586f130181-dirty
(ndesaulniers@ndesaulniers1.mtv.corp.google.com) (Nick Desaulniers
clang version 12.0.0 (git@github.com:llvm/llvm-project.git
e75fec2b238f0e26cfb7645f2208baebe3440d41), GNU ld (GNU Binutils for
Debian) 2.35.1) #76 SMP Thu Jan 7 17:51:34 PST 2021
/ # uname -a
Linux (none) 5.11.0-rc2-01914-g16586f130181-dirty #76 SMP Thu Jan 7
17:51:34 PST 2021 s390x GNU/Linux

For the series:
Tested-by: Nick Desaulniers <ndesaulniers@google.com>


>
> v1 -> v2:
> - Add 's390x/tcg: Don't ignore content in r0 when not specified via "b" or
>   "x"'
> - Add 's390x/tcg: Ignore register content if b1/b2 is zero when handling
>   EXEUTE'
> - "s390x/tcg: Fix ALGSI"
> -- Fixup subject
> - "s390x/tcg: Fix RISBHG"
> -- Rephrase description, stating that it fixes clang-11
>
> David Hildenbrand (4):
>   s390x/tcg: Fix ALGSI
>   s390x/tcg: Fix RISBHG
>   s390x/tcg: Only ignore content in r0 when specified via "b" or "x"
>   s390x/tcg: Ignore register content if b1/b2 is zero when handling
>     EXECUTE
>
>  target/s390x/insn-data.def | 10 +++++-----
>  target/s390x/mem_helper.c  |  4 ++--
>  target/s390x/translate.c   | 33 +++++++++++++++++----------------
>  3 files changed, 24 insertions(+), 23 deletions(-)
>
> --
> 2.29.2
>


-- 
Thanks,
~Nick Desaulniers

Re: [PATCH v2 0/4] s390x/tcg: fix booting Linux kernels compiled with clang-11 and clang-12
Posted by Guenter Roeck 3 years, 4 months ago
On 1/8/21 5:20 AM, David Hildenbrand wrote:
> This series fixes booting current upstream Linux kernel compiled by
> clang-11 and clang-12 under TCG.
> 
> Decided to pull in already separatly sent patches. The last patch is
> not required to fix the boot issues, but related to patch #3.
> 
> Latest version of the patches available at:
> git@github.com:davidhildenbrand/qemu.git clang
> 
> v1 -> v2:
> - Add 's390x/tcg: Don't ignore content in r0 when not specified via "b" or
>   "x"'
> - Add 's390x/tcg: Ignore register content if b1/b2 is zero when handling
>   EXEUTE'
> - "s390x/tcg: Fix ALGSI"
> -- Fixup subject
> - "s390x/tcg: Fix RISBHG"
> -- Rephrase description, stating that it fixes clang-11
> 
> David Hildenbrand (4):
>   s390x/tcg: Fix ALGSI
>   s390x/tcg: Fix RISBHG
>   s390x/tcg: Only ignore content in r0 when specified via "b" or "x"
>   s390x/tcg: Ignore register content if b1/b2 is zero when handling
>     EXECUTE
> 
>  target/s390x/insn-data.def | 10 +++++-----
>  target/s390x/mem_helper.c  |  4 ++--
>  target/s390x/translate.c   | 33 +++++++++++++++++----------------
>  3 files changed, 24 insertions(+), 23 deletions(-)
> 

FWIW, for the series, with gcc 8.3.0 and 10.2.0, booting Linux kernel
v5.11-rc2-178-gf5e6c330254a:

Tested-by: Guenter Roeck <linux@roeck-us.net>

Guenter

Re: [PATCH v2 0/4] s390x/tcg: fix booting Linux kernels compiled with clang-11 and clang-12
Posted by David Hildenbrand 3 years, 4 months ago
On 08.01.21 20:21, Guenter Roeck wrote:
> On 1/8/21 5:20 AM, David Hildenbrand wrote:
>> This series fixes booting current upstream Linux kernel compiled by
>> clang-11 and clang-12 under TCG.
>>
>> Decided to pull in already separatly sent patches. The last patch is
>> not required to fix the boot issues, but related to patch #3.
>>
>> Latest version of the patches available at:
>> git@github.com:davidhildenbrand/qemu.git clang
>>
>> v1 -> v2:
>> - Add 's390x/tcg: Don't ignore content in r0 when not specified via "b" or
>>   "x"'
>> - Add 's390x/tcg: Ignore register content if b1/b2 is zero when handling
>>   EXEUTE'
>> - "s390x/tcg: Fix ALGSI"
>> -- Fixup subject
>> - "s390x/tcg: Fix RISBHG"
>> -- Rephrase description, stating that it fixes clang-11
>>
>> David Hildenbrand (4):
>>   s390x/tcg: Fix ALGSI
>>   s390x/tcg: Fix RISBHG
>>   s390x/tcg: Only ignore content in r0 when specified via "b" or "x"
>>   s390x/tcg: Ignore register content if b1/b2 is zero when handling
>>     EXECUTE
>>
>>  target/s390x/insn-data.def | 10 +++++-----
>>  target/s390x/mem_helper.c  |  4 ++--
>>  target/s390x/translate.c   | 33 +++++++++++++++++----------------
>>  3 files changed, 24 insertions(+), 23 deletions(-)
>>
> 
> FWIW, for the series, with gcc 8.3.0 and 10.2.0, booting Linux kernel
> v5.11-rc2-178-gf5e6c330254a:
> 
> Tested-by: Guenter Roeck <linux@roeck-us.net>
> 
> Guenter
> 

Thanks Guenter, appreciated!

-- 
Thanks,

David / dhildenb