[v1] Tracing patches

[PULL 0/5] Tracing patches

Posted by Stefan Hajnoczi 3 years, 4 months ago

The following changes since commit 41192db338588051f21501abc13743e62b0a5605:

  Merge remote-tracking branch 'remotes/ehabkost-gl/tags/machine-next-pull-request' into staging (2021-01-01 22:57:15 +0000)

are available in the Git repository at:

  https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request

for you to fetch changes up to 7fb48c0ee1bbf5cc4c905e900b054096250e9f39:

  tracetool: show trace-events filename/lineno in fmt string errors (2021-01-04 14:24:58 +0000)

----------------------------------------------------------------
Pull request

Show trace-events filename/lineno in fmt string errors and send -d trace:help
output to stdout for consistency.

----------------------------------------------------------------

Doug Evans (1):
  trace: Send "-d trace:help" output to stdout

Stefan Hajnoczi (4):
  tracetool: add output filename command-line argument
  tracetool: add out_lineno and out_next_lineno to out()
  tracetool: add input filename and line number to Event
  tracetool: show trace-events filename/lineno in fmt string errors

 docs/devel/tracing.txt              |  3 +-
 meson.build                         |  3 +-
 trace/control.h                     |  3 +-
 trace/control.c                     | 12 +++----
 scripts/tracetool.py                | 12 ++++---
 scripts/tracetool/__init__.py       | 53 +++++++++++++++++++++++++----
 scripts/tracetool/backend/ftrace.py |  4 +++
 scripts/tracetool/backend/log.py    |  4 +++
 scripts/tracetool/backend/syslog.py |  4 +++
 trace/meson.build                   | 21 ++++--------
 10 files changed, 83 insertions(+), 36 deletions(-)

-- 
2.29.2

Re: [PULL 0/5] Tracing patches

Posted by no-reply@patchew.org 3 years, 4 months ago

Patchew URL: https://patchew.org/QEMU/20210104143154.462212-1-stefanha@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210104143154.462212-1-stefanha@redhat.com
Subject: [PULL 0/5] Tracing patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210104143154.462212-1-stefanha@redhat.com -> patchew/20210104143154.462212-1-stefanha@redhat.com
Switched to a new branch 'test'
6b1738f tracetool: show trace-events filename/lineno in fmt string errors
d66a9fc tracetool: add input filename and line number to Event
0262a28 tracetool: add out_lineno and out_next_lineno to out()
95bd058 tracetool: add output filename command-line argument
f8cfb47 trace: Send "-d trace:help" output to stdout

=== OUTPUT BEGIN ===
1/5 Checking commit f8cfb47e3ae2 (trace: Send "-d trace:help" output to stdout)
2/5 Checking commit 95bd058cef88 (tracetool: add output filename command-line argument)
ERROR: line over 90 characters
#73: FILE: scripts/tracetool.py:35:
+Usage: %(script)s --format=<format> --backends=<backends> [<options>] <trace-events> ... <output>

total: 1 errors, 0 warnings, 144 lines checked

Patch 2/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/5 Checking commit 0262a28e87d0 (tracetool: add out_lineno and out_next_lineno to out())
4/5 Checking commit d66a9fc4e62f (tracetool: add input filename and line number to Event)
5/5 Checking commit 6b1738f508ad (tracetool: show trace-events filename/lineno in fmt string errors)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210104143154.462212-1-stefanha@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PULL 0/5] Tracing patches

Posted by Peter Maydell 3 years, 4 months ago

On Mon, 4 Jan 2021 at 14:32, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 41192db338588051f21501abc13743e62b0a5605:
>
>   Merge remote-tracking branch 'remotes/ehabkost-gl/tags/machine-next-pull-request' into staging (2021-01-01 22:57:15 +0000)
>
> are available in the Git repository at:
>
>   https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request
>
> for you to fetch changes up to 7fb48c0ee1bbf5cc4c905e900b054096250e9f39:
>
>   tracetool: show trace-events filename/lineno in fmt string errors (2021-01-04 14:24:58 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> Show trace-events filename/lineno in fmt string errors and send -d trace:help
> output to stdout for consistency.
>
> ----------------------------------------------------------------
>
> Doug Evans (1):
>   trace: Send "-d trace:help" output to stdout
>
> Stefan Hajnoczi (4):
>   tracetool: add output filename command-line argument
>   tracetool: add out_lineno and out_next_lineno to out()
>   tracetool: add input filename and line number to Event
>   tracetool: show trace-events filename/lineno in fmt string errors


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
for any user-visible changes.

-- PMM