[v3] acpi: Some fixes for pxb support for ARM virt machine

[PATCH v3 6/8] Kconfig: Enable PXB for ARM_VIRT by default

Posted by Jiahui Cen 4 years, 10 months ago

PXB is now supported on ARM, so let's enable it by default.

Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
---
 hw/pci-bridge/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/pci-bridge/Kconfig b/hw/pci-bridge/Kconfig
index a51ec716f5..f8df4315ba 100644
--- a/hw/pci-bridge/Kconfig
+++ b/hw/pci-bridge/Kconfig
@@ -5,7 +5,7 @@ config PCIE_PORT
 
 config PXB
     bool
-    default y if Q35
+    default y if Q35 || ARM_VIRT
 
 config XIO3130
     bool
-- 
2.29.2

Re: [PATCH v3 6/8] Kconfig: Enable PXB for ARM_VIRT by default

Posted by Igor Mammedov 4 years, 10 months ago

On Wed, 23 Dec 2020 17:08:34 +0800
Jiahui Cen <cenjiahui@huawei.com> wrote:
subj
s/by default//
s/enable/compile/

> PXB is now supported on ARM, so let's enable it by default.
s/it by default/for arm_virt machine/
s/enable/compile/

> 
> Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
> ---
>  hw/pci-bridge/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/pci-bridge/Kconfig b/hw/pci-bridge/Kconfig
> index a51ec716f5..f8df4315ba 100644
> --- a/hw/pci-bridge/Kconfig
> +++ b/hw/pci-bridge/Kconfig
> @@ -5,7 +5,7 @@ config PCIE_PORT
>  
>  config PXB
>      bool
> -    default y if Q35
> +    default y if Q35 || ARM_VIRT
>  
>  config XIO3130
>      bool

Re: [PATCH v3 6/8] Kconfig: Enable PXB for ARM_VIRT by default

Posted by Jiahui Cen 4 years, 10 months ago


On 2020/12/29 21:50, Igor Mammedov wrote:
> On Wed, 23 Dec 2020 17:08:34 +0800
> Jiahui Cen <cenjiahui@huawei.com> wrote:
> subj
> s/by default//
> s/enable/compile/
> 
>> PXB is now supported on ARM, so let's enable it by default.
> s/it by default/for arm_virt machine/
> s/enable/compile/

Thanks for your review.
I will fix them in the next patches.

Thanks,
Jiahui

>>
>> Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
>> ---
>>  hw/pci-bridge/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/pci-bridge/Kconfig b/hw/pci-bridge/Kconfig
>> index a51ec716f5..f8df4315ba 100644
>> --- a/hw/pci-bridge/Kconfig
>> +++ b/hw/pci-bridge/Kconfig
>> @@ -5,7 +5,7 @@ config PCIE_PORT
>>  
>>  config PXB
>>      bool
>> -    default y if Q35
>> +    default y if Q35 || ARM_VIRT
>>  
>>  config XIO3130
>>      bool
> 
> .
>