[PULL 00/33] QAPI patches patches for 2020-12-19

Markus Armbruster posted 33 patches 3 years, 4 months ago
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201219105532.1734134-1-armbru@redhat.com
Maintainers: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Kevin Wolf <kwolf@redhat.com>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, Max Reitz <mreitz@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, Cornelia Huck <cohuck@redhat.com>, Artyom Tarasenko <atar4qemu@gmail.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Laszlo Ersek <lersek@redhat.com>, Markus Armbruster <armbru@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Fam Zheng <fam@euphon.net>, Stefan Hajnoczi <stefanha@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Michael Roth <michael.roth@amd.com>, Jason Wang <jasowang@redhat.com>, Jason Dillaman <dillaman@redhat.com>, Sarah Harris <S.E.Harris@kent.ac.uk>, Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Andrzej Zaborowski <balrogg@gmail.com>, Halil Pasic <pasic@linux.ibm.com>, Juan Quintela <quintela@redhat.com>, Greg Kurz <groug@kaod.org>, Yuval Shaia <yuval.shaia.ml@gmail.com>, Christian Borntraeger <borntraeger@de.ibm.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>, Laurent Vivier <lvivier@redhat.com>, Stafford Horne <shorne@gmail.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Michael Rolnik <mrolnik@gmail.com>, Thomas Huth <thuth@redhat.com>, Jiri Pirko <jiri@resnulli.us>, David Hildenbrand <david@redhat.com>
docs/devel/writing-qmp-commands.txt |  12 +-
hw/net/rocker/rocker_fp.h           |   2 +-
hw/rdma/rdma_backend_defs.h         |   2 +-
hw/rdma/rdma_utils.h                |  15 ++-
include/migration/vmstate.h         |   7 +-
include/qapi/qmp/json-writer.h      |  35 +++++
include/qapi/qmp/qbool.h            |   2 -
include/qapi/qmp/qdict.h            |   2 -
include/qapi/qmp/qjson.h            |   4 +-
include/qapi/qmp/qlist.h            |   2 -
include/qapi/qmp/qnull.h            |   2 -
include/qapi/qmp/qnum.h             |   3 -
include/qapi/qmp/qobject.h          |   9 +-
include/qapi/qmp/qstring.h          |  14 +-
include/qemu/typedefs.h             |   4 +-
migration/qjson.h                   |  29 -----
monitor/monitor-internal.h          |   2 +-
qobject/qobject-internal.h          |  39 ++++++
block.c                             |  23 ++--
block/gluster.c                     |   4 +-
block/qapi.c                        |   7 +-
block/rbd.c                         |   2 +-
chardev/char.c                      |  20 ++-
hw/core/machine-qmp-cmds.c          |   6 +-
hw/core/machine.c                   |  11 +-
hw/display/virtio-gpu.c             |   2 +-
hw/intc/s390_flic_kvm.c             |   2 +-
hw/net/rocker/rocker.c              |   8 +-
hw/net/rocker/rocker_fp.c           |  17 ++-
hw/net/rocker/rocker_of_dpa.c       |  20 +--
hw/net/virtio-net.c                 |  21 +--
hw/nvram/eeprom93xx.c               |   2 +-
hw/nvram/fw_cfg.c                   |   2 +-
hw/pci/msix.c                       |   2 +-
hw/pci/pci.c                        |   4 +-
hw/pci/shpc.c                       |   2 +-
hw/rdma/rdma_backend.c              |  10 +-
hw/rdma/rdma_utils.c                |  29 +++--
hw/rtc/twl92230.c                   |   2 +-
hw/scsi/scsi-bus.c                  |   2 +-
hw/usb/redirect.c                   |   7 +-
hw/virtio/virtio.c                  |   4 +-
migration/migration.c               |  29 ++---
migration/postcopy-ram.c            |   7 +-
migration/qjson.c                   | 114 -----------------
migration/savevm.c                  |  53 ++++----
migration/vmstate-types.c           |  38 +++---
migration/vmstate.c                 |  52 ++++----
monitor/hmp-cmds.c                  |  13 +-
monitor/misc.c                      |  31 ++---
monitor/monitor.c                   |  20 ++-
monitor/qmp-cmds-control.c          |  10 +-
monitor/qmp.c                       |  46 ++++---
qapi/string-output-visitor.c        |   2 +-
qemu-img.c                          |  38 +++---
qga/commands-posix-ssh.c            |   7 +-
qga/commands-posix.c                |  47 ++-----
qga/commands-win32.c                |  32 ++---
qga/commands.c                      |   6 +-
qga/main.c                          |  22 +---
qobject/json-parser.c               |  30 ++---
qobject/json-writer.c               | 247 ++++++++++++++++++++++++++++++++++++
qobject/qbool.c                     |   1 +
qobject/qdict.c                     |   1 +
qobject/qjson.c                     | 144 +++++----------------
qobject/qlist.c                     |   1 +
qobject/qnull.c                     |   1 +
qobject/qnum.c                      |  28 +---
qobject/qobject.c                   |   1 +
qobject/qstring.c                   | 117 +++--------------
qom/object.c                        |   9 +-
qom/object_interfaces.c             |   4 +-
qom/qom-hmp-cmds.c                  |   7 +-
qom/qom-qmp-cmds.c                  |  29 ++---
target/alpha/machine.c              |   2 +-
target/arm/helper.c                 |   6 +-
target/arm/machine.c                |   6 +-
target/arm/monitor.c                |  13 +-
target/avr/machine.c                |   4 +-
target/hppa/machine.c               |   4 +-
target/i386/cpu.c                   |   6 +-
target/microblaze/machine.c         |   2 +-
target/mips/cpu.c                   |   6 +-
target/mips/machine.c               |   4 +-
target/openrisc/machine.c           |   2 +-
target/ppc/machine.c                |  10 +-
target/s390x/cpu_models.c           |  12 +-
target/sparc/machine.c              |   2 +-
tests/check-qjson.c                 | 195 ++++++++++++++--------------
tests/check-qnum.c                  |   8 +-
tests/check-qobject.c               |   3 +-
tests/check-qstring.c               |  16 ---
tests/qtest/libqtest.c              |  20 ++-
tests/test-clone-visitor.c          |   7 +-
tests/test-qobject-output-visitor.c |  42 +++---
tests/test-string-output-visitor.c  |   4 +-
tests/test-visitor-serialization.c  | 181 ++++++++------------------
trace/qmp.c                         |  22 ++--
ui/input.c                          |  16 +--
ui/vnc.c                            |  21 +--
util/keyval.c                       |  11 +-
util/qemu-config.c                  |  14 +-
target/ppc/translate_init.c.inc     |  12 +-
migration/meson.build               |   1 -
qobject/meson.build                 |   5 +-
105 files changed, 975 insertions(+), 1263 deletions(-)
create mode 100644 include/qapi/qmp/json-writer.h
delete mode 100644 migration/qjson.h
create mode 100644 qobject/qobject-internal.h
delete mode 100644 migration/qjson.c
create mode 100644 qobject/json-writer.c
[PULL 00/33] QAPI patches patches for 2020-12-19
Posted by Markus Armbruster 3 years, 4 months ago
The following changes since commit a05f8ecd88f15273d033b6f044b850a8af84a5b8:

  Merge remote-tracking branch 'remotes/alistair/tags/pull-riscv-to-apply-20201217-1' into staging (2020-12-18 11:12:35 +0000)

are available in the Git repository at:

  git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2020-12-19

for you to fetch changes up to 4ac76ba414ecb94f086d73621775d8b38b6f0a43:

  qobject: Make QString immutable (2020-12-19 10:39:41 +0100)

----------------------------------------------------------------
QAPI patches patches for 2020-12-19

----------------------------------------------------------------
Eric Blake (3):
      rocker: Revamp fp_port_get_info
      migration: Refactor migrate_cap_add
      qapi: Use QAPI_LIST_PREPEND() where possible

Markus Armbruster (30):
      tests/check-qjson: Don't skip funny QNumber to JSON conversions
      tests/check-qjson: Examine QNum more thoroughly
      tests/check-qjson: Cover number 2^63
      tests/check-qjson: Replace redundant large_number()
      tests/check-qnum: Cover qnum_to_string() for "unround" argument
      qobject: Fix qnum_to_string() to use sufficient precision
      test-string-output-visitor: Cover "unround" number
      string-output-visitor: Fix to use sufficient precision
      test-visitor-serialization: Drop insufficient precision workaround
      test-visitor-serialization: Clean up test_primitives()
      hmp: Simplify how qmp_human_monitor_command() gets output
      monitor: Use GString instead of QString for output buffer
      qobject: Make qobject_to_json_pretty() take a pretty argument
      qobject: Use GString instead of QString to accumulate JSON
      qobject: Change qobject_to_json()'s value to GString
      Revert "qstring: add qstring_free()"
      hw/rdma: Replace QList by GQueue
      qobject: Move internals to qobject-internal.h
      qmp: Fix tracing of non-string command IDs
      block: Avoid qobject_get_try_str()
      Revert "qobject: let object_property_get_str() use new API"
      qobject: Drop qobject_get_try_str()
      qobject: Drop qstring_get_try_str()
      qobject: Factor quoted_str() out of to_json()
      qobject: Factor JSON writer out of qobject_to_json()
      migration: Replace migration's JSON writer by the general one
      json: Use GString instead of QString to accumulate strings
      keyval: Use GString to accumulate value strings
      block: Use GString instead of QString to build filenames
      qobject: Make QString immutable

 docs/devel/writing-qmp-commands.txt |  12 +-
 hw/net/rocker/rocker_fp.h           |   2 +-
 hw/rdma/rdma_backend_defs.h         |   2 +-
 hw/rdma/rdma_utils.h                |  15 ++-
 include/migration/vmstate.h         |   7 +-
 include/qapi/qmp/json-writer.h      |  35 +++++
 include/qapi/qmp/qbool.h            |   2 -
 include/qapi/qmp/qdict.h            |   2 -
 include/qapi/qmp/qjson.h            |   4 +-
 include/qapi/qmp/qlist.h            |   2 -
 include/qapi/qmp/qnull.h            |   2 -
 include/qapi/qmp/qnum.h             |   3 -
 include/qapi/qmp/qobject.h          |   9 +-
 include/qapi/qmp/qstring.h          |  14 +-
 include/qemu/typedefs.h             |   4 +-
 migration/qjson.h                   |  29 -----
 monitor/monitor-internal.h          |   2 +-
 qobject/qobject-internal.h          |  39 ++++++
 block.c                             |  23 ++--
 block/gluster.c                     |   4 +-
 block/qapi.c                        |   7 +-
 block/rbd.c                         |   2 +-
 chardev/char.c                      |  20 ++-
 hw/core/machine-qmp-cmds.c          |   6 +-
 hw/core/machine.c                   |  11 +-
 hw/display/virtio-gpu.c             |   2 +-
 hw/intc/s390_flic_kvm.c             |   2 +-
 hw/net/rocker/rocker.c              |   8 +-
 hw/net/rocker/rocker_fp.c           |  17 ++-
 hw/net/rocker/rocker_of_dpa.c       |  20 +--
 hw/net/virtio-net.c                 |  21 +--
 hw/nvram/eeprom93xx.c               |   2 +-
 hw/nvram/fw_cfg.c                   |   2 +-
 hw/pci/msix.c                       |   2 +-
 hw/pci/pci.c                        |   4 +-
 hw/pci/shpc.c                       |   2 +-
 hw/rdma/rdma_backend.c              |  10 +-
 hw/rdma/rdma_utils.c                |  29 +++--
 hw/rtc/twl92230.c                   |   2 +-
 hw/scsi/scsi-bus.c                  |   2 +-
 hw/usb/redirect.c                   |   7 +-
 hw/virtio/virtio.c                  |   4 +-
 migration/migration.c               |  29 ++---
 migration/postcopy-ram.c            |   7 +-
 migration/qjson.c                   | 114 -----------------
 migration/savevm.c                  |  53 ++++----
 migration/vmstate-types.c           |  38 +++---
 migration/vmstate.c                 |  52 ++++----
 monitor/hmp-cmds.c                  |  13 +-
 monitor/misc.c                      |  31 ++---
 monitor/monitor.c                   |  20 ++-
 monitor/qmp-cmds-control.c          |  10 +-
 monitor/qmp.c                       |  46 ++++---
 qapi/string-output-visitor.c        |   2 +-
 qemu-img.c                          |  38 +++---
 qga/commands-posix-ssh.c            |   7 +-
 qga/commands-posix.c                |  47 ++-----
 qga/commands-win32.c                |  32 ++---
 qga/commands.c                      |   6 +-
 qga/main.c                          |  22 +---
 qobject/json-parser.c               |  30 ++---
 qobject/json-writer.c               | 247 ++++++++++++++++++++++++++++++++++++
 qobject/qbool.c                     |   1 +
 qobject/qdict.c                     |   1 +
 qobject/qjson.c                     | 144 +++++----------------
 qobject/qlist.c                     |   1 +
 qobject/qnull.c                     |   1 +
 qobject/qnum.c                      |  28 +---
 qobject/qobject.c                   |   1 +
 qobject/qstring.c                   | 117 +++--------------
 qom/object.c                        |   9 +-
 qom/object_interfaces.c             |   4 +-
 qom/qom-hmp-cmds.c                  |   7 +-
 qom/qom-qmp-cmds.c                  |  29 ++---
 target/alpha/machine.c              |   2 +-
 target/arm/helper.c                 |   6 +-
 target/arm/machine.c                |   6 +-
 target/arm/monitor.c                |  13 +-
 target/avr/machine.c                |   4 +-
 target/hppa/machine.c               |   4 +-
 target/i386/cpu.c                   |   6 +-
 target/microblaze/machine.c         |   2 +-
 target/mips/cpu.c                   |   6 +-
 target/mips/machine.c               |   4 +-
 target/openrisc/machine.c           |   2 +-
 target/ppc/machine.c                |  10 +-
 target/s390x/cpu_models.c           |  12 +-
 target/sparc/machine.c              |   2 +-
 tests/check-qjson.c                 | 195 ++++++++++++++--------------
 tests/check-qnum.c                  |   8 +-
 tests/check-qobject.c               |   3 +-
 tests/check-qstring.c               |  16 ---
 tests/qtest/libqtest.c              |  20 ++-
 tests/test-clone-visitor.c          |   7 +-
 tests/test-qobject-output-visitor.c |  42 +++---
 tests/test-string-output-visitor.c  |   4 +-
 tests/test-visitor-serialization.c  | 181 ++++++++------------------
 trace/qmp.c                         |  22 ++--
 ui/input.c                          |  16 +--
 ui/vnc.c                            |  21 +--
 util/keyval.c                       |  11 +-
 util/qemu-config.c                  |  14 +-
 target/ppc/translate_init.c.inc     |  12 +-
 migration/meson.build               |   1 -
 qobject/meson.build                 |   5 +-
 105 files changed, 975 insertions(+), 1263 deletions(-)
 create mode 100644 include/qapi/qmp/json-writer.h
 delete mode 100644 migration/qjson.h
 create mode 100644 qobject/qobject-internal.h
 delete mode 100644 migration/qjson.c
 create mode 100644 qobject/json-writer.c

-- 
2.26.2


Re: [PULL 00/33] QAPI patches patches for 2020-12-19
Posted by no-reply@patchew.org 3 years, 4 months ago
Patchew URL: https://patchew.org/QEMU/20201219105532.1734134-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201219105532.1734134-1-armbru@redhat.com
Subject: [PULL 00/33] QAPI patches patches for 2020-12-19

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20201219105532.1734134-1-armbru@redhat.com -> patchew/20201219105532.1734134-1-armbru@redhat.com
 * [new tag]         patchew/20201219111934.5540-1-mark.cave-ayland@ilande.co.uk -> patchew/20201219111934.5540-1-mark.cave-ayland@ilande.co.uk
Switched to a new branch 'test'
50cf88f qobject: Make QString immutable
219adc3f block: Use GString instead of QString to build filenames
6b26586 keyval: Use GString to accumulate value strings
c201d84 json: Use GString instead of QString to accumulate strings
7f3b372 migration: Replace migration's JSON writer by the general one
528861f qobject: Factor JSON writer out of qobject_to_json()
2ec5364 qobject: Factor quoted_str() out of to_json()
3c6b4e4 qobject: Drop qstring_get_try_str()
e9a5862 qobject: Drop qobject_get_try_str()
5355c0b Revert "qobject: let object_property_get_str() use new API"
bb79759 block: Avoid qobject_get_try_str()
682d4a2 qmp: Fix tracing of non-string command IDs
94fb9f2 qobject: Move internals to qobject-internal.h
c35e746 hw/rdma: Replace QList by GQueue
ce6552d Revert "qstring: add qstring_free()"
92a214e qobject: Change qobject_to_json()'s value to GString
9300d4f qobject: Use GString instead of QString to accumulate JSON
83c58e9 qobject: Make qobject_to_json_pretty() take a pretty argument
cae34720 monitor: Use GString instead of QString for output buffer
5ce523f hmp: Simplify how qmp_human_monitor_command() gets output
d00c4a9 test-visitor-serialization: Clean up test_primitives()
1f20720 test-visitor-serialization: Drop insufficient precision workaround
08e5179 string-output-visitor: Fix to use sufficient precision
f6b278a test-string-output-visitor: Cover "unround" number
0c5456e qobject: Fix qnum_to_string() to use sufficient precision
99709b5 tests/check-qnum: Cover qnum_to_string() for "unround" argument
b9f996e tests/check-qjson: Replace redundant large_number()
5395cbb tests/check-qjson: Cover number 2^63
772a54f tests/check-qjson: Examine QNum more thoroughly
e4decd9 tests/check-qjson: Don't skip funny QNumber to JSON conversions
3b10bb6 qapi: Use QAPI_LIST_PREPEND() where possible
1a5e6e4 migration: Refactor migrate_cap_add
b197a61 rocker: Revamp fp_port_get_info

=== OUTPUT BEGIN ===
1/33 Checking commit b197a61caecb (rocker: Revamp fp_port_get_info)
2/33 Checking commit 1a5e6e4a2c9f (migration: Refactor migrate_cap_add)
3/33 Checking commit 3b10bb662508 (qapi: Use QAPI_LIST_PREPEND() where possible)
4/33 Checking commit e4decd945ac8 (tests/check-qjson: Don't skip funny QNumber to JSON conversions)
WARNING: Block comments use a leading /* on a separate line
#95: FILE: tests/check-qjson.c:883:
+        { "-32.20e-10", -32.20e-10, "-0" /* BUG */ },

ERROR: spaces required around that '-' (ctx:VxV)
#95: FILE: tests/check-qjson.c:883:
+        { "-32.20e-10", -32.20e-10, "-0" /* BUG */ },
                                ^

total: 1 errors, 1 warnings, 97 lines checked

Patch 4/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/33 Checking commit 772a54f1cf5a (tests/check-qjson: Examine QNum more thoroughly)
6/33 Checking commit 5395cbbe7df9 (tests/check-qjson: Cover number 2^63)
7/33 Checking commit b9f996e8a2e1 (tests/check-qjson: Replace redundant large_number())
8/33 Checking commit 99709b586e03 (tests/check-qnum: Cover qnum_to_string() for "unround" argument)
9/33 Checking commit 0c5456ea8d00 (qobject: Fix qnum_to_string() to use sufficient precision)
WARNING: Block comments use a leading /* on a separate line
#105: FILE: qobject/qnum.c:170:
+        /* FIXME: g_strdup_printf() is locale dependent; but JSON requires

ERROR: spaces required around that '-' (ctx:VxV)
#145: FILE: tests/check-qjson.c:886:
+        { "-32.20e-10", -32.20e-10, "-3.22e-09" },
                                ^

total: 1 errors, 1 warnings, 69 lines checked

Patch 9/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/33 Checking commit f6b278afee74 (test-string-output-visitor: Cover "unround" number)
11/33 Checking commit 08e5179b5f93 (string-output-visitor: Fix to use sufficient precision)
12/33 Checking commit 1f20720448a4 (test-visitor-serialization: Drop insufficient precision workaround)
13/33 Checking commit d00c4a954141 (test-visitor-serialization: Clean up test_primitives())
14/33 Checking commit 5ce523f11a05 (hmp: Simplify how qmp_human_monitor_command() gets output)
15/33 Checking commit cae347203dc0 (monitor: Use GString instead of QString for output buffer)
16/33 Checking commit 83c58e9ffed3 (qobject: Make qobject_to_json_pretty() take a pretty argument)
17/33 Checking commit 9300d4fa9d19 (qobject: Use GString instead of QString to accumulate JSON)
18/33 Checking commit 92a214e26b4a (qobject: Change qobject_to_json()'s value to GString)
19/33 Checking commit ce6552d76f07 (Revert "qstring: add qstring_free()")
20/33 Checking commit c35e74638490 (hw/rdma: Replace QList by GQueue)
21/33 Checking commit 94fb9f20fafc (qobject: Move internals to qobject-internal.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#174: 
new file mode 100644

total: 0 errors, 1 warnings, 154 lines checked

Patch 21/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/33 Checking commit 682d4a256ac4 (qmp: Fix tracing of non-string command IDs)
23/33 Checking commit bb7975901234 (block: Avoid qobject_get_try_str())
24/33 Checking commit 5355c0bf5b9c (Revert "qobject: let object_property_get_str() use new API")
25/33 Checking commit e9a5862af1f9 (qobject: Drop qobject_get_try_str())
26/33 Checking commit 3c6b4e48200a (qobject: Drop qstring_get_try_str())
27/33 Checking commit 2ec536474768 (qobject: Factor quoted_str() out of to_json())
28/33 Checking commit 528861fbbca4 (qobject: Factor JSON writer out of qobject_to_json())
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#27: 
new file mode 100644

total: 0 errors, 1 warnings, 487 lines checked

Patch 28/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/33 Checking commit 7f3b3727f6e9 (migration: Replace migration's JSON writer by the general one)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#287: 
deleted file mode 100644

total: 0 errors, 1 warnings, 751 lines checked

Patch 29/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/33 Checking commit c201d84dff3d (json: Use GString instead of QString to accumulate strings)
31/33 Checking commit 6b2658627db3 (keyval: Use GString to accumulate value strings)
32/33 Checking commit 219adc3f7f9e (block: Use GString instead of QString to build filenames)
33/33 Checking commit 50cf88f55262 (qobject: Make QString immutable)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20201219105532.1734134-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PULL 00/33] QAPI patches patches for 2020-12-19
Posted by Peter Maydell 3 years, 3 months ago
On Sat, 19 Dec 2020 at 10:55, Markus Armbruster <armbru@redhat.com> wrote:
>
> The following changes since commit a05f8ecd88f15273d033b6f044b850a8af84a5b8:
>
>   Merge remote-tracking branch 'remotes/alistair/tags/pull-riscv-to-apply-20201217-1' into staging (2020-12-18 11:12:35 +0000)
>
> are available in the Git repository at:
>
>   git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2020-12-19
>
> for you to fetch changes up to 4ac76ba414ecb94f086d73621775d8b38b6f0a43:
>
>   qobject: Make QString immutable (2020-12-19 10:39:41 +0100)
>
> ----------------------------------------------------------------
> QAPI patches patches for 2020-12-19
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
for any user-visible changes.

-- PMM