tests/docker: Use lower case for centos8 powertools

[PATCH] tests/docker: Use lower case for centos8 powertools

Posted by Jiaxun Yang 3 years, 4 months ago

Our gitlab amd64-centos8-container pipeline constantly fail at:

15.36 Error: No matching repo to modify: PowerTools.

Fix it by convert it to lower case.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 tests/docker/dockerfiles/centos8.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker
index 54bc6d54cd..06b67962fd 100644
--- a/tests/docker/dockerfiles/centos8.docker
+++ b/tests/docker/dockerfiles/centos8.docker
@@ -31,6 +31,6 @@ ENV PACKAGES \
     zlib-devel
 
 RUN dnf install -y dnf-plugins-core && \
-  dnf config-manager --set-enabled PowerTools && \
+  dnf config-manager --set-enabled powertools && \
   dnf install -y $PACKAGES
 RUN rpm -q $PACKAGES | sort > /packages.txt
-- 
2.29.2

Re: [PATCH] tests/docker: Use lower case for centos8 powertools

Posted by Alex Bennée 3 years, 4 months ago

Jiaxun Yang <jiaxun.yang@flygoat.com> writes:

> Our gitlab amd64-centos8-container pipeline constantly fail at:
>
> 15.36 Error: No matching repo to modify: PowerTools.
>
> Fix it by convert it to lower case.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

Thanks for you patch, we already have a similar fix in flight this PR:

  Subject: [PULL v2 00/11] testing and configure updates
  Date: Thu, 17 Dec 2020 09:43:30 +0000
  Message-Id: <20201217094330.17400-1-alex.bennee@linaro.org>

> ---
>  tests/docker/dockerfiles/centos8.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker
> index 54bc6d54cd..06b67962fd 100644
> --- a/tests/docker/dockerfiles/centos8.docker
> +++ b/tests/docker/dockerfiles/centos8.docker
> @@ -31,6 +31,6 @@ ENV PACKAGES \
>      zlib-devel
>  
>  RUN dnf install -y dnf-plugins-core && \
> -  dnf config-manager --set-enabled PowerTools && \
> +  dnf config-manager --set-enabled powertools && \
>    dnf install -y $PACKAGES
>  RUN rpm -q $PACKAGES | sort > /packages.txt


-- 
Alex Bennée

Re: [PATCH] tests/docker: Use lower case for centos8 powertools

Posted by Wainer dos Santos Moschetta 3 years, 4 months ago

Hi,

On 12/17/20 10:11 PM, Jiaxun Yang wrote:
> Our gitlab amd64-centos8-container pipeline constantly fail at:
>
> 15.36 Error: No matching repo to modify: PowerTools.
>
> Fix it by convert it to lower case.

They recently changed the name of some repositories:

https://wiki.centos.org/Manuals/ReleaseNotes/CentOS8.2011#Yum_repo_file_and_repoid_changes

Thanks for working on this fix!

Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>

>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>   tests/docker/dockerfiles/centos8.docker | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker
> index 54bc6d54cd..06b67962fd 100644
> --- a/tests/docker/dockerfiles/centos8.docker
> +++ b/tests/docker/dockerfiles/centos8.docker
> @@ -31,6 +31,6 @@ ENV PACKAGES \
>       zlib-devel
>   
>   RUN dnf install -y dnf-plugins-core && \
> -  dnf config-manager --set-enabled PowerTools && \
> +  dnf config-manager --set-enabled powertools && \
>     dnf install -y $PACKAGES
>   RUN rpm -q $PACKAGES | sort > /packages.txt