[PATCH 5/7] meson: use pkg-config method for libudev

Paolo Bonzini posted 7 patches 4 years, 11 months ago
[PATCH 5/7] meson: use pkg-config method for libudev
Posted by Paolo Bonzini 4 years, 11 months ago
Do not bother asking CMake, this is a pkg-config dependency.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meson.build b/meson.build
index ab622ae8bd..0b36fb38f1 100644
--- a/meson.build
+++ b/meson.build
@@ -399,6 +399,7 @@ endif
 libudev = not_found
 if targetos == 'linux' and (have_system or have_tools)
   libudev = dependency('libudev',
+                       method: 'pkg-config',
                        required: get_option('libudev'),
                        static: enable_static)
 endif
-- 
2.29.2



Re: [PATCH 5/7] meson: use pkg-config method for libudev
Posted by Marc-André Lureau 4 years, 11 months ago
On Wed, Dec 16, 2020 at 8:28 PM Paolo Bonzini <pbonzini@redhat.com> wrote:

> Do not bother asking CMake, this is a pkg-config dependency.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>

What was the problem with the default behaviour? Do we need to set
pkg-config explicitly on all dependencies?

---
>  meson.build | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meson.build b/meson.build
> index ab622ae8bd..0b36fb38f1 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -399,6 +399,7 @@ endif
>  libudev = not_found
>  if targetos == 'linux' and (have_system or have_tools)
>    libudev = dependency('libudev',
> +                       method: 'pkg-config',
>                         required: get_option('libudev'),
>                         static: enable_static)
>  endif
> --
> 2.29.2
>
>
>
>

-- 
Marc-André Lureau