[PATCH v15 00/13] Apply COR-filter to the block-stream permanently

Vladimir Sementsov-Ogievskiy posted 13 patches 3 years, 4 months ago
Test checkpatch passed
Failed in applying to current master (apply log)
qapi/block-core.json           |  38 ++++++-
block/copy-on-read.h           |  32 ++++++
include/block/block.h          |  10 +-
include/block/block_int.h      |  12 ++-
block.c                        |  25 +++++
block/copy-on-read.c           | 184 +++++++++++++++++++++++++++++---
block/io.c                     |  10 +-
block/monitor/block-hmp-cmds.c |   7 +-
block/stream.c                 | 185 ++++++++++++++++++++-------------
blockdev.c                     |  69 +++++++++---
tests/qemu-iotests/030         |  12 ++-
tests/qemu-iotests/141.out     |   2 +-
tests/qemu-iotests/245         |  20 ++--
tests/qemu-iotests/310         | 116 +++++++++++++++++++++
tests/qemu-iotests/310.out     |  15 +++
tests/qemu-iotests/group       |   1 +
16 files changed, 608 insertions(+), 130 deletions(-)
create mode 100644 block/copy-on-read.h
create mode 100755 tests/qemu-iotests/310
create mode 100644 tests/qemu-iotests/310.out
[PATCH v15 00/13] Apply COR-filter to the block-stream permanently
Posted by Vladimir Sementsov-Ogievskiy 3 years, 4 months ago
Hi all!

Here is a new version of cor-filter in block-stream series. Main change
is freezing the chain in cor-filter itself.

v15:
02: s/ =  / = /
    add Max's r-b
03: add Max's r-b
04: since: 6.0
    indent comment
    add Max's r-b
05: changed commit msg
    wording
    document the default
    since: 6.0
    use bdrv_find_node(), fix errp overwriting
    freeze the chain
    check bottom is not filter
    ref bottom_bs
06: limit to qcow2 to not care
    use qemu-img rebase -u -b ''
07: use assert instead of abort
    add Max's r-b
08: add Max's r-b
09: changed commit msg (was "stream: skip filters when writing backing file name to QCOW2 header")
    keep mostly same logic for the case when backing-file is specified, don't do bdrv_find_backing_image()
10: don't restrict backing-file for now
11: add Max's r-b
12: add Max's r-b
13: chain is now frozen in filter, so the logic changed around add/remove fitlter

Andrey Shinkevich (10):
  copy-on-read: support preadv/pwritev_part functions
  block: add API function to insert a node
  copy-on-read: add filter drop function
  qapi: add filter-node-name to block-stream
  qapi: copy-on-read filter: add 'bottom' option
  iotests: add #310 to test bottom node in COR driver
  block: include supported_read_flags into BDS structure
  copy-on-read: skip non-guest reads if no copy needed
  stream: rework backing-file changing
  block: apply COR-filter to block-stream jobs

Vladimir Sementsov-Ogievskiy (3):
  qapi: block-stream: add "bottom" argument
  iotests: 30: prepare to COR filter insertion by stream job
  block/stream: add s->target_bs

 qapi/block-core.json           |  38 ++++++-
 block/copy-on-read.h           |  32 ++++++
 include/block/block.h          |  10 +-
 include/block/block_int.h      |  12 ++-
 block.c                        |  25 +++++
 block/copy-on-read.c           | 184 +++++++++++++++++++++++++++++---
 block/io.c                     |  10 +-
 block/monitor/block-hmp-cmds.c |   7 +-
 block/stream.c                 | 185 ++++++++++++++++++++-------------
 blockdev.c                     |  69 +++++++++---
 tests/qemu-iotests/030         |  12 ++-
 tests/qemu-iotests/141.out     |   2 +-
 tests/qemu-iotests/245         |  20 ++--
 tests/qemu-iotests/310         | 116 +++++++++++++++++++++
 tests/qemu-iotests/310.out     |  15 +++
 tests/qemu-iotests/group       |   1 +
 16 files changed, 608 insertions(+), 130 deletions(-)
 create mode 100644 block/copy-on-read.h
 create mode 100755 tests/qemu-iotests/310
 create mode 100644 tests/qemu-iotests/310.out

-- 
2.25.4


Re: [PATCH v15 00/13] Apply COR-filter to the block-stream permanently
Posted by Max Reitz 3 years, 3 months ago
On 16.12.20 07:16, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
> 
> Here is a new version of cor-filter in block-stream series. Main change
> is freezing the chain in cor-filter itself.

Thanks, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block


Re: [PATCH v15 00/13] Apply COR-filter to the block-stream permanently
Posted by Vladimir Sementsov-Ogievskiy 3 years, 3 months ago
05.01.2021 19:08, Max Reitz wrote:
> On 16.12.20 07:16, Vladimir Sementsov-Ogievskiy wrote:
>> Hi all!
>>
>> Here is a new version of cor-filter in block-stream series. Main change
>> is freezing the chain in cor-filter itself.
> 
> Thanks, applied to my block branch:
> 
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block
> 

Great! Thanks a lot!

-- 
Best regards,
Vladimir