[PATCH v2 0/3] pc: Support configuration of SMBIOS entry point type

Eduardo Habkost posted 3 patches 4 years, 11 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201214205029.2991222-1-ehabkost@redhat.com
There is a newer version of this series
qapi/qapi-schema.json        |  1 +
qapi/smbios.json             | 11 +++++++++++
include/hw/firmware/smbios.h | 10 ++--------
include/hw/i386/pc.h         |  3 +++
hw/arm/virt.c                |  2 +-
hw/i386/pc.c                 | 26 ++++++++++++++++++++++++++
hw/i386/pc_piix.c            |  2 +-
hw/i386/pc_q35.c             |  2 +-
hw/smbios/smbios.c           |  8 ++++----
qapi/meson.build             |  1 +
10 files changed, 51 insertions(+), 15 deletions(-)
create mode 100644 qapi/smbios.json
[PATCH v2 0/3] pc: Support configuration of SMBIOS entry point type
Posted by Eduardo Habkost 4 years, 11 months ago
This includes code previously submitted[1] by Daniel P. Berrangé
to add a "smbios-ep" machine property on PC.

SMBIOS 3.0 is necessary to support more than ~720 VCPUs, as a
large number of VCPUs can easily hit the table size limit of
SMBIOS 2.1 entry points.

[1] https://lore.kernel.org/qemu-devel/20200908165438.1008942-5-berrange@redhat.com
    https://lore.kernel.org/qemu-devel/20200908165438.1008942-6-berrange@redhat.com

Daniel P. Berrangé (1):
  hw/i386: expose a "smbios-ep" PC machine property

Eduardo Habkost (2):
  smbios: Rename SMBIOS_ENTRY_POINT_* enums
  hw/smbios: Use qapi for SmbiosEntryPointType

 qapi/qapi-schema.json        |  1 +
 qapi/smbios.json             | 11 +++++++++++
 include/hw/firmware/smbios.h | 10 ++--------
 include/hw/i386/pc.h         |  3 +++
 hw/arm/virt.c                |  2 +-
 hw/i386/pc.c                 | 26 ++++++++++++++++++++++++++
 hw/i386/pc_piix.c            |  2 +-
 hw/i386/pc_q35.c             |  2 +-
 hw/smbios/smbios.c           |  8 ++++----
 qapi/meson.build             |  1 +
 10 files changed, 51 insertions(+), 15 deletions(-)
 create mode 100644 qapi/smbios.json

-- 
2.28.0



Re: [PATCH v2 0/3] pc: Support configuration of SMBIOS entry point type
Posted by Igor Mammedov 4 years, 10 months ago
On Mon, 14 Dec 2020 15:50:26 -0500
Eduardo Habkost <ehabkost@redhat.com> wrote:

> This includes code previously submitted[1] by Daniel P. Berrangé
> to add a "smbios-ep" machine property on PC.
> 
> SMBIOS 3.0 is necessary to support more than ~720 VCPUs, as a
> large number of VCPUs can easily hit the table size limit of
> SMBIOS 2.1 entry points.

Eduardo,
do you plan to submit Seabios patches for SMBIOS 3.0?
will OVMF pick up new tables automatically?

> 
> [1] https://lore.kernel.org/qemu-devel/20200908165438.1008942-5-berrange@redhat.com
>     https://lore.kernel.org/qemu-devel/20200908165438.1008942-6-berrange@redhat.com
> 
> Daniel P. Berrangé (1):
>   hw/i386: expose a "smbios-ep" PC machine property
> 
> Eduardo Habkost (2):
>   smbios: Rename SMBIOS_ENTRY_POINT_* enums
>   hw/smbios: Use qapi for SmbiosEntryPointType
> 
>  qapi/qapi-schema.json        |  1 +
>  qapi/smbios.json             | 11 +++++++++++
>  include/hw/firmware/smbios.h | 10 ++--------
>  include/hw/i386/pc.h         |  3 +++
>  hw/arm/virt.c                |  2 +-
>  hw/i386/pc.c                 | 26 ++++++++++++++++++++++++++
>  hw/i386/pc_piix.c            |  2 +-
>  hw/i386/pc_q35.c             |  2 +-
>  hw/smbios/smbios.c           |  8 ++++----
>  qapi/meson.build             |  1 +
>  10 files changed, 51 insertions(+), 15 deletions(-)
>  create mode 100644 qapi/smbios.json
> 


Re: [PATCH v2 0/3] pc: Support configuration of SMBIOS entry point type
Posted by Eduardo Habkost 4 years, 10 months ago
On Tue, Dec 29, 2020 at 02:20:01PM +0100, Igor Mammedov wrote:
> On Mon, 14 Dec 2020 15:50:26 -0500
> Eduardo Habkost <ehabkost@redhat.com> wrote:
> 
> > This includes code previously submitted[1] by Daniel P. Berrangé
> > to add a "smbios-ep" machine property on PC.
> > 
> > SMBIOS 3.0 is necessary to support more than ~720 VCPUs, as a
> > large number of VCPUs can easily hit the table size limit of
> > SMBIOS 2.1 entry points.
> 
> Eduardo,
> do you plan to submit Seabios patches for SMBIOS 3.0?
> will OVMF pick up new tables automatically?

OVMF will pick the new tables automatically.

SeaBIOS patches are at:
https://www.mail-archive.com/search?l=mid&q=20201210212640.2023885-1-ehabkost@redhat.com

-- 
Eduardo


Re: [PATCH v2 0/3] pc: Support configuration of SMBIOS entry point type
Posted by Philippe Mathieu-Daudé 4 years, 10 months ago
On 12/14/20 9:50 PM, Eduardo Habkost wrote:
> This includes code previously submitted[1] by Daniel P. Berrangé
> to add a "smbios-ep" machine property on PC.
> 
> SMBIOS 3.0 is necessary to support more than ~720 VCPUs, as a
> large number of VCPUs can easily hit the table size limit of
> SMBIOS 2.1 entry points.
> 
> [1] https://lore.kernel.org/qemu-devel/20200908165438.1008942-5-berrange@redhat.com
>     https://lore.kernel.org/qemu-devel/20200908165438.1008942-6-berrange@redhat.com
> 
> Daniel P. Berrangé (1):
>   hw/i386: expose a "smbios-ep" PC machine property
> 
> Eduardo Habkost (2):
>   smbios: Rename SMBIOS_ENTRY_POINT_* enums
>   hw/smbios: Use qapi for SmbiosEntryPointType
> 
>  qapi/qapi-schema.json        |  1 +
>  qapi/smbios.json             | 11 +++++++++++
>  include/hw/firmware/smbios.h | 10 ++--------
>  include/hw/i386/pc.h         |  3 +++
>  hw/arm/virt.c                |  2 +-
>  hw/i386/pc.c                 | 26 ++++++++++++++++++++++++++
>  hw/i386/pc_piix.c            |  2 +-
>  hw/i386/pc_q35.c             |  2 +-
>  hw/smbios/smbios.c           |  8 ++++----
>  qapi/meson.build             |  1 +
>  10 files changed, 51 insertions(+), 15 deletions(-)
>  create mode 100644 qapi/smbios.json

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>