[PATCH 2/2] include/hw/sparc/grlib.h: Remove unused set_pil_in_fn typedef

Peter Maydell posted 2 patches 5 years, 1 month ago
Maintainers: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, KONRAD Frederic <frederic.konrad@adacore.com>, Fabien Chouteau <chouteau@adacore.com>, Artyom Tarasenko <atar4qemu@gmail.com>
[PATCH 2/2] include/hw/sparc/grlib.h: Remove unused set_pil_in_fn typedef
Posted by Peter Maydell 5 years, 1 month ago
The grlib.h header defines a set_pil_in_fn typedef which is never
used; remove it.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 include/hw/sparc/grlib.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/hw/sparc/grlib.h b/include/hw/sparc/grlib.h
index e1d1beaa73f..2104f493f32 100644
--- a/include/hw/sparc/grlib.h
+++ b/include/hw/sparc/grlib.h
@@ -34,8 +34,6 @@
 /* IRQMP */
 #define TYPE_GRLIB_IRQMP "grlib,irqmp"
 
-typedef void (*set_pil_in_fn) (void *opaque, uint32_t pil_in);
-
 void grlib_irqmp_ack(DeviceState *dev, int intno);
 
 /* GPTimer */
-- 
2.20.1


Re: [PATCH 2/2] include/hw/sparc/grlib.h: Remove unused set_pil_in_fn typedef
Posted by Philippe Mathieu-Daudé 5 years, 1 month ago
On 12/12/20 3:41 PM, Peter Maydell wrote:
> The grlib.h header defines a set_pil_in_fn typedef which is never
> used; remove it.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  include/hw/sparc/grlib.h | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Re: [PATCH 2/2] include/hw/sparc/grlib.h: Remove unused set_pil_in_fn typedef
Posted by Fred Konrad 5 years, 1 month ago

Le 12/12/20 à 3:41 PM, Peter Maydell a écrit :
> The grlib.h header defines a set_pil_in_fn typedef which is never
> used; remove it.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   include/hw/sparc/grlib.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/include/hw/sparc/grlib.h b/include/hw/sparc/grlib.h
> index e1d1beaa73f..2104f493f32 100644
> --- a/include/hw/sparc/grlib.h
> +++ b/include/hw/sparc/grlib.h
> @@ -34,8 +34,6 @@
>   /* IRQMP */
>   #define TYPE_GRLIB_IRQMP "grlib,irqmp"
>   
> -typedef void (*set_pil_in_fn) (void *opaque, uint32_t pil_in);
> -
>   void grlib_irqmp_ack(DeviceState *dev, int intno);
>   
>   /* GPTimer */
> 

Reviewed-by: KONRAD Frederic <frederic.konrad@adacore.com>