[PATCH 3/3] tests/acceptance/machine_s390_ccw_virtio: Test the virtio-balloon device

Thomas Huth posted 3 patches 5 years, 1 month ago
There is a newer version of this series
[PATCH 3/3] tests/acceptance/machine_s390_ccw_virtio: Test the virtio-balloon device
Posted by Thomas Huth 5 years, 1 month ago
Inflate the balloon and check whether the size of the memory changes.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/acceptance/machine_s390_ccw_virtio.py | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/tests/acceptance/machine_s390_ccw_virtio.py b/tests/acceptance/machine_s390_ccw_virtio.py
index 7d0a78139b..81f6c066c7 100644
--- a/tests/acceptance/machine_s390_ccw_virtio.py
+++ b/tests/acceptance/machine_s390_ccw_virtio.py
@@ -70,7 +70,8 @@ class S390CCWVirtioMachine(Test):
                          '-device', 'zpci,uid=5,target=zzz',
                          '-device', 'virtio-net-pci,id=zzz',
                          '-device', 'zpci,uid=0xa,fid=12,target=serial',
-                         '-device', 'virtio-serial-pci,id=serial')
+                         '-device', 'virtio-serial-pci,id=serial',
+                         '-device', 'virtio-balloon-ccw')
         self.vm.launch()
 
         shell_ready = "sh: can't access tty; job control turned off"
@@ -140,3 +141,12 @@ class S390CCWVirtioMachine(Test):
         exec_command_and_wait_for_pattern(self,
                                           'ls /sys/bus/ccw/devices/0.0.4711',
                                           'No such file or directory')
+        # test the virtio-balloon device
+        exec_command_and_wait_for_pattern(self, 'head -n 1 /proc/meminfo',
+                                          'MemTotal:         115640 kB')
+        self.vm.command('human-monitor-command', command_line='balloon 96')
+        exec_command_and_wait_for_pattern(self, 'head -n 1 /proc/meminfo',
+                                          'MemTotal:          82872 kB')
+        self.vm.command('human-monitor-command', command_line='balloon 128')
+        exec_command_and_wait_for_pattern(self, 'head -n 1 /proc/meminfo',
+                                          'MemTotal:         115640 kB')
-- 
2.27.0


Re: [PATCH 3/3] tests/acceptance/machine_s390_ccw_virtio: Test the virtio-balloon device
Posted by Wainer dos Santos Moschetta 5 years, 1 month ago
On 12/11/20 2:31 PM, Thomas Huth wrote:
> Inflate the balloon and check whether the size of the memory changes.
Yeah, because a true balloon should inflate :D
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/acceptance/machine_s390_ccw_virtio.py | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)

Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>

>
> diff --git a/tests/acceptance/machine_s390_ccw_virtio.py b/tests/acceptance/machine_s390_ccw_virtio.py
> index 7d0a78139b..81f6c066c7 100644
> --- a/tests/acceptance/machine_s390_ccw_virtio.py
> +++ b/tests/acceptance/machine_s390_ccw_virtio.py
> @@ -70,7 +70,8 @@ class S390CCWVirtioMachine(Test):
>                            '-device', 'zpci,uid=5,target=zzz',
>                            '-device', 'virtio-net-pci,id=zzz',
>                            '-device', 'zpci,uid=0xa,fid=12,target=serial',
> -                         '-device', 'virtio-serial-pci,id=serial')
> +                         '-device', 'virtio-serial-pci,id=serial',
> +                         '-device', 'virtio-balloon-ccw')
>           self.vm.launch()
>   
>           shell_ready = "sh: can't access tty; job control turned off"
> @@ -140,3 +141,12 @@ class S390CCWVirtioMachine(Test):
>           exec_command_and_wait_for_pattern(self,
>                                             'ls /sys/bus/ccw/devices/0.0.4711',
>                                             'No such file or directory')
> +        # test the virtio-balloon device
> +        exec_command_and_wait_for_pattern(self, 'head -n 1 /proc/meminfo',
> +                                          'MemTotal:         115640 kB')
> +        self.vm.command('human-monitor-command', command_line='balloon 96')
> +        exec_command_and_wait_for_pattern(self, 'head -n 1 /proc/meminfo',
> +                                          'MemTotal:          82872 kB')
> +        self.vm.command('human-monitor-command', command_line='balloon 128')
> +        exec_command_and_wait_for_pattern(self, 'head -n 1 /proc/meminfo',
> +                                          'MemTotal:         115640 kB')