1. Patchew
  2. QEMU
  3. [RFC PATCH 0/2] gitlab-ci: Maintain a public runner, allow manual pipeline
  4. View patch

[RFC PATCH 1/2] gitlab-ci: Step in to maintain the fedora-i386-cross runner

Philippe Mathieu-Daudé posted 2 patches 5 years, 1 month ago
[RFC PATCH 1/2] gitlab-ci: Step in to maintain the fedora-i386-cross runner
Posted by Philippe Mathieu-Daudé 5 years, 1 month ago 
As I am interested in using the runner based on the fedora-i386-cross
docker image, add a smoke test job to be sure this image is usable,
and set the JOB_MAINTAINER_NAME/JOB_MAINTAINER_EMAIL variables so
other developers can contact me in case there is a problem with the
public runner based on this image.

We will eventually send a patch to make script/checkpatch.pl parse
the Gitlab YAML jobs to understand the JOB_MAINTAINER_NAME and
JOB_MAINTAINER_EMAIL variables.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 .gitlab-ci.d/crossbuilds.yml | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml
index bd6473a75a7..864cad7cec5 100644
--- a/.gitlab-ci.d/crossbuilds.yml
+++ b/.gitlab-ci.d/crossbuilds.yml
@@ -39,6 +39,13 @@
       ../configure --enable-werror $QEMU_CONFIGURE_OPTS --disable-system
     - make -j$(expr $(nproc) + 1) all check-build
 
+.cross_sanity_check_job:
+  stage: build
+  image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest
+  timeout: 3m
+  script:
+    - /bin/true
+
 cross-armel-system:
   extends: .cross_system_build_job
   variables:
@@ -69,6 +76,14 @@ cross-arm64-user:
   variables:
     IMAGE: debian-arm64-cross
 
+cross-i386-sanity-check:
+  extends: .cross_sanity_check_job
+  variables:
+    JOB_MAINTAINER_NAME: "Philippe Mathieu-Daudé"
+    JOB_MAINTAINER_EMAIL: philmd@redhat.com
+    GIT_SUBMODULE_STRATEGY: none
+    IMAGE: fedora-i386-cross
+
 cross-mips-system:
   extends: .cross_system_build_job
   variables:
-- 
2.26.2
Re: [RFC PATCH 1/2] gitlab-ci: Step in to maintain the fedora-i386-cross runner
Posted by Thomas Huth 5 years, 1 month ago 
On 11/12/2020 18.17, Philippe Mathieu-Daudé wrote:
> As I am interested in using the runner based on the fedora-i386-cross
> docker image, add a smoke test job to be sure this image is usable,
> and set the JOB_MAINTAINER_NAME/JOB_MAINTAINER_EMAIL variables so
> other developers can contact me in case there is a problem with the
> public runner based on this image.
> 
> We will eventually send a patch to make script/checkpatch.pl parse
> the Gitlab YAML jobs to understand the JOB_MAINTAINER_NAME and
> JOB_MAINTAINER_EMAIL variables.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  .gitlab-ci.d/crossbuilds.yml | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml
> index bd6473a75a7..864cad7cec5 100644
> --- a/.gitlab-ci.d/crossbuilds.yml
> +++ b/.gitlab-ci.d/crossbuilds.yml
> @@ -39,6 +39,13 @@
>        ../configure --enable-werror $QEMU_CONFIGURE_OPTS --disable-system
>      - make -j$(expr $(nproc) + 1) all check-build
>  
> +.cross_sanity_check_job:
> +  stage: build
> +  image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest
> +  timeout: 3m
> +  script:
> +    - /bin/true

I guess it makes more sense if I respin my patch here instead:

https://www.mail-archive.com/qemu-devel@nongnu.org/msg762919.html

?

 Thomas
Re: [RFC PATCH 1/2] gitlab-ci: Step in to maintain the fedora-i386-cross runner
Posted by Philippe Mathieu-Daudé 5 years, 1 month ago 
On 12/14/20 1:35 PM, Thomas Huth wrote:
> On 11/12/2020 18.17, Philippe Mathieu-Daudé wrote:
>> As I am interested in using the runner based on the fedora-i386-cross
>> docker image, add a smoke test job to be sure this image is usable,
>> and set the JOB_MAINTAINER_NAME/JOB_MAINTAINER_EMAIL variables so
>> other developers can contact me in case there is a problem with the
>> public runner based on this image.
>>
>> We will eventually send a patch to make script/checkpatch.pl parse
>> the Gitlab YAML jobs to understand the JOB_MAINTAINER_NAME and
>> JOB_MAINTAINER_EMAIL variables.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  .gitlab-ci.d/crossbuilds.yml | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml
>> index bd6473a75a7..864cad7cec5 100644
>> --- a/.gitlab-ci.d/crossbuilds.yml
>> +++ b/.gitlab-ci.d/crossbuilds.yml
>> @@ -39,6 +39,13 @@
>>        ../configure --enable-werror $QEMU_CONFIGURE_OPTS --disable-system
>>      - make -j$(expr $(nproc) + 1) all check-build
>>  
>> +.cross_sanity_check_job:
>> +  stage: build
>> +  image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest
>> +  timeout: 3m
>> +  script:
>> +    - /bin/true
> 
> I guess it makes more sense if I respin my patch here instead:
> 
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg762919.html
> 
> ?

I think these are different. The idea of testing /bin/true is to be
able to make the distinction between a broken runner and a broken
test.

> 
>  Thomas
>
Re: [RFC PATCH 1/2] gitlab-ci: Step in to maintain the fedora-i386-cross runner
Posted by Daniel P. Berrangé 5 years, 1 month ago 
On Mon, Dec 14, 2020 at 06:52:31PM +0100, Philippe Mathieu-Daudé wrote:
> On 12/14/20 1:35 PM, Thomas Huth wrote:
> > On 11/12/2020 18.17, Philippe Mathieu-Daudé wrote:
> >> As I am interested in using the runner based on the fedora-i386-cross
> >> docker image, add a smoke test job to be sure this image is usable,
> >> and set the JOB_MAINTAINER_NAME/JOB_MAINTAINER_EMAIL variables so
> >> other developers can contact me in case there is a problem with the
> >> public runner based on this image.
> >>
> >> We will eventually send a patch to make script/checkpatch.pl parse
> >> the Gitlab YAML jobs to understand the JOB_MAINTAINER_NAME and
> >> JOB_MAINTAINER_EMAIL variables.
> >>
> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> >> ---
> >>  .gitlab-ci.d/crossbuilds.yml | 15 +++++++++++++++
> >>  1 file changed, 15 insertions(+)
> >>
> >> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml
> >> index bd6473a75a7..864cad7cec5 100644
> >> --- a/.gitlab-ci.d/crossbuilds.yml
> >> +++ b/.gitlab-ci.d/crossbuilds.yml
> >> @@ -39,6 +39,13 @@
> >>        ../configure --enable-werror $QEMU_CONFIGURE_OPTS --disable-system
> >>      - make -j$(expr $(nproc) + 1) all check-build
> >>  
> >> +.cross_sanity_check_job:
> >> +  stage: build
> >> +  image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest
> >> +  timeout: 3m
> >> +  script:
> >> +    - /bin/true
> > 
> > I guess it makes more sense if I respin my patch here instead:
> > 
> > https://www.mail-archive.com/qemu-devel@nongnu.org/msg762919.html
> > 
> > ?
> 
> I think these are different. The idea of testing /bin/true is to be
> able to make the distinction between a broken runner and a broken
> test.

I don't see any point in this job.  /bin/true will always succeeed
if we've successfully created the container image if the container
build job.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.