[v2] hw/core: Restrict 'fw-path-provider.c' to system mode emulation

[PATCH v2] hw/core: Restrict 'fw-path-provider.c' to system mode emulation

Philippe Mathieu-Daudé posted 1 patch 4 years, 11 months ago

Diff against v1
Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201207220709.4017938-1-philmd@redhat.com

hw/core/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH v2] hw/core: Restrict 'fw-path-provider.c' to system mode emulation

Posted by Philippe Mathieu-Daudé 4 years, 11 months ago

fw-path-provider.c is only consumed by qdev-fw.c, which itself
is in softmmu_ss[], so we can restrict fw-path-provider.c to
softmmu too.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v2: Fix author email.
---
 hw/core/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/core/meson.build b/hw/core/meson.build
index 4a744f3b5e7..032576f5717 100644
--- a/hw/core/meson.build
+++ b/hw/core/meson.build
@@ -1,7 +1,6 @@
 # core qdev-related obj files, also used by *-user and unit tests
 hwcore_files = files(
   'bus.c',
-  'fw-path-provider.c',
   'hotplug.c',
   'qdev-properties.c',
   'qdev.c',
@@ -25,6 +24,7 @@
 common_ss.add(when: 'CONFIG_XILINX_AXI', if_true: files('stream.c'))
 
 softmmu_ss.add(files(
+  'fw-path-provider.c',
   'loader.c',
   'machine-hmp-cmds.c',
   'machine.c',
-- 
2.26.2

Re: [PATCH v2] hw/core: Restrict 'fw-path-provider.c' to system mode emulation

Posted by Paolo Bonzini 4 years, 11 months ago

On 07/12/20 23:07, Philippe Mathieu-Daudé wrote:
> fw-path-provider.c is only consumed by qdev-fw.c, which itself
> is in softmmu_ss[], so we can restrict fw-path-provider.c to
> softmmu too.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: Fix author email.
> ---
>   hw/core/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/core/meson.build b/hw/core/meson.build
> index 4a744f3b5e7..032576f5717 100644
> --- a/hw/core/meson.build
> +++ b/hw/core/meson.build
> @@ -1,7 +1,6 @@
>   # core qdev-related obj files, also used by *-user and unit tests
>   hwcore_files = files(
>     'bus.c',
> -  'fw-path-provider.c',
>     'hotplug.c',
>     'qdev-properties.c',
>     'qdev.c',
> @@ -25,6 +24,7 @@
>   common_ss.add(when: 'CONFIG_XILINX_AXI', if_true: files('stream.c'))
>   
>   softmmu_ss.add(files(
> +  'fw-path-provider.c',
>     'loader.c',
>     'machine-hmp-cmds.c',
>     'machine.c',
> 

Queued, thanks.

paolo